[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
The proposal to merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Approve code review -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Approve code review Hi, Alex, Thanks for the changes. Indeed, in contributors section of the documentation, there's still a reference to add it at the end of the description. Initial intention was to get a dedicated section under the key 'contributors' of the manifest file to be displayed on module list, but this is something still not possible, so that way is for now the valid one. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Hi Pedro, thank you for your review, my comments are in line. > Contributors are put on 'contributors' key in manifest file as a list, not in > description. As far as I can see here https://doc.openerp.com/contribute/05_developing_modules/#modules-description it's written differently. > I prefer to add purchase as dependency Done in my last commit. Cheers. -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Needs Fixing code review Hi, Alex, some remarks: - Contributors are put on 'contributors' key in manifest file as a list, not in description. - I prefer to add purchase as dependency that changes the place where the menu is displayed, because this query is not useful if you don't use purchase module. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Lorenzo,
following are listed the reasons:
'images': this key doesn't compare in
https://doc.openerp.com/trunk/server/03_module_dev_01/#manifest-file-openerp-py:
also comparing https://www.openerp.com/apps/7.0/product_by_supplier/ and
https://www.openerp.com/apps/7.0/product_supplier_info/ I noticed the image in
the first one has broken link. So I gathered was a good solution to remove it;
'sequence': using https://github.com/nbessi/openerp-conventions I get ' O600
Warning unknown Manifest key ('sequence')' so I thought to remove it.
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Review: Needs Information Thanks Alex, why did you remove the 'images' and 'sequence' items? -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is requested to review the proposed merge of lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl
Alex Comba - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
Commit message:
[FIX] bug #1312024
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
This branch contains the fix for
https://bugs.launchpad.net/purchase-wkfl/+bug/1312024 and a bit of flake8
cleanup.
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
=== modified file 'product_by_supplier/__openerp__.py'
--- product_by_supplier/__openerp__.py 2014-02-06 19:59:12 +
+++ product_by_supplier/__openerp__.py 2014-04-24 14:30:21 +
@@ -24,21 +24,27 @@
'name': 'Product by supplier info',
'version': '1.0',
'category': 'purchase',
-'sequence': 19,
'summary': 'Show products grouped by suppliers',
'description': """
+Product Supplier Info
+==
This module categorizes each product item by supplier.
-==
-* It allows for users to be able to view a compiled list of products supplied \
-by the supplier.
-* Users can also directly add new products to the supplier's list.
-""",
+It allows for users to be able to view a compiled list
+of products supplied by the supplier.
+
+Users can also directly add new products to the supplier's list.
+
+Contributors
+
+
+* Alex Comba
+""",
'author': 'Elico Corp',
'website': 'http://www.elico-corp.com',
-'images': [
- 'static/images/product_supplier_info.png'
- ],
-'depends': ['product', 'stock'],
+'license': 'AGPL-3',
+'depends': [
+'product', 'stock'
+],
'data': [
'product_view.xml',
],
=== modified file 'product_by_supplier/product.py'
--- product_by_supplier/product.py 2013-11-12 01:44:31 +
+++ product_by_supplier/product.py 2014-04-24 14:30:21 +
@@ -20,7 +20,6 @@
#
##
from openerp.osv import orm, fields
-import openerp.addons.decimal_precision as dp
class product_supplierinfo(orm.Model):
@@ -33,7 +32,8 @@
product_obj = self.pool.get('product.product')
for record in self.browse(cr, uid, ids, context=context):
res[record.id] = {}
-product = product_obj.browse(cr, uid, record.product_id.id, context=context)
+product = product_obj.browse(
+cr, uid, record.product_id.id, context=context)
res[record.id]['qty_available'] = product.qty_available
res[record.id]['virtual_available'] = product.virtual_available
return res
@@ -47,10 +47,13 @@
'virtual_available': fields.function(
_product_available, multi='virtual_available', type='float',
string="Forecasted Quantity"),
-'delay' : fields.integer('Delivery Lead Time', required=True,
- group_operator="avg",
- help="Lead time in days between the confirmation of the purchase order and the reception of the products in your warehouse. Used by the scheduler for automatic computation of the purchase order planning."
- ),
+'delay': fields.integer(
+'Delivery Lead Time', required=True, group_operator="avg",
+help="Lead time in days between the confirmation of the"
+" purchase order and the reception of the products in your"
+" warehouse. Used by the scheduler for automatic computation of"
+" the purchase order planning."
+),
}
# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== modified file 'product_by_supplier/product_view.xml'
--- product_by_supplier/product_view.xml 2014-02-06 19:59:12 +
+++ product_by_supplier/product_view.xml 2014-04-24 14:30:21 +
@@ -70,6 +70,6 @@
name="Product by Suppliers"
sequence="15"
action="action_product_supplier_info"
-parent="purchase.menu_procurement_management_product"/>
+parent="stock.menu_stock_product"/>
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
