Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Sergio Corato]

Hi Nicola, Lorenzo, Holger,
what about delete commercial_month field and put this code instead?
if line.months != 0:

And in the view set the field days required if months if false and 
viceversa:

field name=months attrs={'required':[('days','=',False)]}/

and

xpath expr=/form/group/group/field[@name='days'] position=attributes
attribute name=attrs{'required':[('months','=',False)]}/attribute
/xpath
-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Nicola Riolini - Micronaet]

Review: Resubmit

Holger, Lorenzo made the requested correction (thanks Lorenzo :) )., merge 
approved for me, see diff of the mp:
https://code.launchpad.net/~agilebg/account-invoicing/add_module_account_payment_term_month_improvements/+merge/221124
-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Nicola Riolini - Micronaet]

Review: Approve

Sorry, review type was approve not resubmit (Lorenzo told me the difference 
:) )
-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Ciao Nicola.
Just refactored the compute method and added tests with
https://code.launchpad.net/~agilebg/account-invoicing/add_module_account_payment_term_month_improvements/+merge/221124

-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Holger Brunn (Therp)]

Review: Needs Fixing

#197ff, #202ff missing spaces at end of strings
@218ff can't you avoid code duplication and breaking inheritance by using 
super's result and simply adding the months as applicable?
-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

See discussion at
https://code.launchpad.net/~icsergio/account-payment/commercial-year-payment/+merge/210700
-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is requested to review the proposed merge of 
lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into 
lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp