Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-todo-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Needs Fixing It seems that some of the changes of this branch is already there in the main project branch, update your branch and remove unwanted changes for this merge proposal also update the description of the proposal listing the only improvements of this proposal -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-todo-aag/+merge/62440 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-784363-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-784363-ron/+merge/61554 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-784363-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-779064-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-779064-ron/+merge/61216 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-779064-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-783837-ron into lp:openobject-addons
Review: Needs Fixing the fix is incomplete, double check the bug description, also need to fix the untranslated string of new view -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-783837-ron/+merge/61250 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-783837-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-tool-tip-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Approve the points which are done seems ok , just a little improvement: Remove two spaces between the all in tooltip of language thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-tool-tip-aag/+merge/61550 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework-tool-tip-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Fixing Change the name of new object and put name field as required -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-tool-tip-aag/+merge/61551 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-783837-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-783837-ron/+merge/61250 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-783837-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-improvements-write-rpa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-temporal-db-improvements-write-rpa into
lp:~openerp-dev/openobject-server/trunk-temporal-db.
Requested reviews:
qdp (OpenERP) (qdp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-improvements-write-rpa/+merge/61571
Improvement in write function, and computation of temporal date to
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-improvements-write-rpa/+merge/61571
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-temporal-db.
=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py 2011-04-29 05:38:31 +
+++ openerp/osv/orm.py 2011-05-19 13:41:24 +
@@ -4285,20 +4285,40 @@
def set_date(self, obj, cr, uid, ids, name, args, context=None):
res = {}
for record in obj.browse(cr, uid, ids, context=context):
-if record.temporal_parent_id:
-res[record.id] = context.get('temporal_date_from', record.temporal_parent_id.temporal_date_from)
-else:
-res[record.id] = False
-return res
+context.update({'all_temporal': True})
+next_id = self.get_next_id_in_timeline(obj, cr, uid, [record.id], context=context)
+res[record.id] = next_id and obj.read(cr, uid, next_id, ['temporal_date_from'])[0]['temporal_date_from'] or False
+return res
+
+def get_ids_of_same_group(self, cr, uid, ids, context=None):
+res = {}
+for record in self.browse(cr, uid, ids, context=context):
+search_ids = [record.id]
+if record.temporal_parent_id.id:
+search_ids.append(record.temporal_parent_id.id)
+res[record.id] = self.search(cr, uid, ['|',('temporal_parent_id', 'in', search_ids), ('id', 'in', search_ids)], context=context)
+return res
+
+def get_next_id_in_timeline(self, obj, cr, uid, ids, context=None):
+res = obj.get_ids_of_same_group(cr, uid, ids, context)
+for record in obj.browse(cr, uid, ids, context=context):
+search_id = obj.search(cr, uid, [('id', 'in', res[record.id]), ('temporal_date_from', '', record.temporal_date_from)], order='temporal_date_from asc', limit=1, context={'all_temporal': True})
+return search_id
+
+def get_previous_id_in_timeline(self, obj, cr, uid, ids, context=None):
+res = obj.get_ids_of_same_group(cr, uid, ids, context)
+for record in obj.browse(cr, uid, ids, context=context):
+search_id = obj.search(cr, uid, [('id', 'in', res[record.id]), ('temporal_date_from', '', record.temporal_date_from)], order='temporal_date_from desc', limit=1, context={'all_temporal': True})
+return search_id + ids
def __init__(self, cr):
self._columns.update({
-'temporal_date_from': fields.datetime('Temporal From Date'),
-'temporal_date_to': fields.function(self.set_date, method=True, string='Temporal To Date', type='datetime',
+'temporal_date_from': fields.datetime('Temporal From Date', select=True),
+'temporal_date_to': fields.function(self.set_date, method=True, select=True, string='Temporal To Date', type='datetime',
store = {
-self._name: (lambda self, cr, uid, ids, c={}: ids, ['temporal_date_from'], 10),
+self._name: (self.get_previous_id_in_timeline , ['temporal_date_from'], 10),
}),
-'temporal_parent_id': fields.many2one(self._name, 'Temporal Parent ID', ondelete='cascade')
+'temporal_parent_id': fields.many2one(self._name, 'Temporal Parent ID', select=True, ondelete='cascade')
})
return super(orm_temporal, self).__init__(cr)
@@ -4312,12 +4332,19 @@
context = {}
if isinstance(ids, (int, long)):
ids = [ids]
-timenow = time.strftime('%Y-%m-%d %H:%M:%S')
-context.update({'temporal_date_from': timenow}) # get current time when make new copy of the current record
-vals.update({'temporal_date_from': timenow})
-for record in self.browse(cr, uid, ids, context=context):
-defaults = {'temporal_date_from': record.temporal_date_from,'temporal_parent_id': record.id}
-orm.copy(self, cr, uid, record.id, defaults, context=context)
+if vals.get('temporal_date_from'):
+return super(orm_temporal, self).write(cr, uid, ids, vals, context=context) # if temporal_date_from pass in vals just call super without any copy
+
+if context.get('temporal_mode', True) and not vals.get('temporal_date_from'):
+for record in self.browse(cr, uid, ids, context=context):
+#avoid creating history records when writing on a reocrd that is already an history record
+if record.temporal_parent_id:
+ continue
+
+vals.update
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-product-terminlg-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Needs Fixing
its working nice as per functionality but some improvements are needed, here
they are:
1) We need only one selection box in this wizard so remove the text box for
Products
2) Need to put good help for this wizard (left side below the image) saying
what this wizard will do
3) def trnslate_create
is this a typo?
4) def trnslate_create
if res_id == False :
res_id = 0
no need to use this code
5) def trnslate_create
instead of removing already existing translation and creating new
translation again for the same, can't we update the existing one?
6) def execute
if context is None:
context = {}
this can be removed as context isn't used later in the code of the function
7) def execute
Put all self.pool.get.. outside loop
too many variables.. too many useless assignation(res_id = m_id),
inconsistent mixtures of spaces and commas
variable name ir_model for model ir_model_fields is misleading, improve
variables
variables used for result of search will be list of ids so it will be good
if you put _ids instead of _id
8) def execute
164 + if ir_menu_partner_id:
165 + for m_id in ir_menu_partner_id:
ir_menu_partner_id is a list, and no indexing is done for this variable in
code, so no need to use if, you can directly use loop, it won't simply loop
if the list is empty
9) def execute
[('field_description','like','Product')]
this will only replace term Product, we want to replace product ,
Products, products too,
use ilike, also find these terms too: Product Categories , Product
Type ...
10) def execute
155 + for p_id in ir_model_partner_id:
156 + brw_ir_model = ir_model.browse(cr ,uid ,p_id , context=context)
157 + name1 = brw_ir_model.field_description
158 + name2 = name1.replace('Partner',o.partner)
159 + obj2 = brw_ir_model.model_id.model
160 + field = brw_ir_model.name
161 + partner_name = obj2 +',' + field
I don't understand why you replace old name with new name and then use it..
simply use it without any operations on it (as said in comment 7 remove useless
variable assignations)
11) this wizard is working only once, if I run again its not working.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-product-terminlg-aag/+merge/61345
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-778473-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-778473-ron/+merge/60457 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-778473-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-781718-ron into lp:openobject-addons
Review: Needs Fixing
1) 'name' : _('Incoming Shipments'),
this wizard will be called for all type of picking so it must be improved
according to picking type
2) res.keys()[0] res.values()[0]
indexing such a way is not good, can be improved in order to avoid
tracebacks if in case we didn't get any values in res
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-781718-ron/+merge/61068
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-781718-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-781718-ron into lp:openobject-addons
Review: Needs Fixing pick_type = pick_obj.browse(cr, uid, picking_ids, context=context)[0].type you can use value of picking_type at stock_partial_picking.py: line 153 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-781718-ron/+merge/61068 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-781718-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Resubmit -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa/+merge/60784 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-server-ksa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
yes, it will work -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa
into lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
Requested reviews:
qdp (OpenERP) (qdp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60892
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60892
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-configuration-rework.
=== modified file 'base_setup/base_setup_installer.xml'
--- base_setup/base_setup_installer.xml 2011-05-10 04:44:56 +
+++ base_setup/base_setup_installer.xml 2011-05-13 10:33:07 +
@@ -217,7 +217,7 @@
field name=typeform/field
field name=inherit_id ref=base.view_company_form /
field name=arch type=xml
-field name=currency_id position=after
+field name=rml_footer2 position=after
newline/
separator string= colspan=4/
group colspan=4 col=2
=== modified file 'base_setup/base_setup_todo.xml'
--- base_setup/base_setup_todo.xml 2011-05-12 19:36:33 +
+++ base_setup/base_setup_todo.xml 2011-05-13 10:33:07 +
@@ -1,53 +1,5 @@
openerp
data
-record id=view_base_setup_company model=ir.ui.view
- field name=nameCompany Configuration/field
- field name=modelbase.setup.company/field
- field name=typeform/field
- field name=inherit_id ref=base.res_config_view_base/
- field name=arch type=xml
-data
- form position=attributes
-attribute name=stringCompany Configuration/attribute
- /form
- xpath expr=//label[@string='description'] position=attributes
-attribute name=stringYour company information will be used to personalize documents issued with OpenERP such as invoices, sales orders and much more./attribute
- /xpath
- xpath expr='//separator[@string=title]' position='attributes'
-attribute name='string'Configure Your Company Information/attribute
- /xpath
- xpath expr='//separator[@string=vsep]' position='attributes'
-attribute name='rowspan'25/attribute
-attribute name='string'/attribute
- /xpath
- group string=res_config_contents position=replace
- group colspan=5
- group colspan=2
-field name=company_id invisible=1/
-field name=name required=True/field name=website/
-field name=street/field name=street2/
-field name=zip/
-field name=city/
-field name=country_id/
-field name=state_id/
-field name=phone/
-field name=email/
-field name=account_no/
-field name=currency widget=selection/
-/group
-newline/
-group colspan=2
-field name=rml_header1 colspan=5 invisible=1 groups=base.group_extended/
-field name=rml_footer1 colspan=5 invisible=1 groups=base.group_extended/
-field name=rml_footer2 colspan=5 invisible=1 groups=base.group_extended/
- /group
-/group
- /group
-
- xpath expr='//button[@name=action_skip]' position='replace'/
-/data
- /field
-/record
record id=action_base_setup_company model=ir.actions.act_window
field name=nameCompany Configuration/field
=== modified file 'base_setup/installer.py'
--- base_setup/installer.py 2011-05-12 12:39:20 +
+++ base_setup/installer.py 2011-05-13 10:33:07 +
@@ -105,17 +105,7 @@
progress = 10.
return {'value':value}
-
-
-def default_get(self, cr, uid, fields_list, context=None):
-#Skipping default value as checked for main application, if already installed
-return super(osv.osv_memory, self).default_get(
-cr, uid, fields_list, context=context)
-
-def fields_get(self, cr, uid, fields=None, context=None, write_access=True):
-#Skipping readonly value for main application, if already installed
-return super(osv.osv_memory, self).fields_get(
-cr, uid, fields, context, write_access)
+
def execute(self, cr, uid, ids, context=None):
if context is None:
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-delivery-improvement-rha into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-delivery-improvement-rha/+merge/60782 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Rucha (Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework. Requested reviews: qdp (OpenERP) (qdp) For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60783 Company config wizard improvement -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60783 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. === modified file 'base_setup/base_setup_todo.xml' --- base_setup/base_setup_todo.xml 2011-04-29 06:40:08 + +++ base_setup/base_setup_todo.xml 2011-05-12 13:42:18 + @@ -53,10 +53,9 @@ field name=nameCompany Configuration/field field name=typeir.actions.act_window/field field name=res_modelbase.setup.company/field - field name=view_id ref=view_base_setup_company/ + field name=view_id ref=base.view_company_form/ field name=view_typeform/field field name=view_modeform/field - field name=targetnew/field /record record id=base_setup_company_todo model=ir.actions.todo ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-imp-wizard-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Needs Fixing Constraint for account_followup is wrong.. improve it -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-imp-wizard-aag/+merge/60785 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing
1) line 21-22, context has to be removed as per previous comment
2) def set_date...
if this function is called for ids [1, 2] its finding for the recent child
records for 1 and 2 and assigns result to that ids, not to ids 1 and 2
3) def get_next_id_in_timeline..
('temporal_date_from', '=', record.temporal_date_from) should be
('temporal_date_to', '=', record.temporal_date_from)
as we need to find the previous record
4) def write..
remove context.update({'temporal_date_from': timenow}) if not used anywhere
5) def write..
Improve function to remove ids.pop()
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/60367
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-temporal-db.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Disapprove As the idea of displaying wizards such a way was dropped, I am rejecting this for the shake of clarity thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Disapprove As the idea of displaying wizards such a way was dropped, I am rejecting this for the shake of clarity thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59332 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59332 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59332 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Disapprove as we don't need this change now, I am rejecting this... -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-780668-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-780668-ron/+merge/60603 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-780668-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-777121-rha into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777121-rha/+merge/60356 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-777121-rha. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron into lp:openobject-addons
Review: Needs Fixing if line.shipped == True: Don't compare boolean values to True or False -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-776983-ron/+merge/60140 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-776983-ron/+merge/60140 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-773128-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-773128-ron/+merge/60165 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-773128-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777803-ron/+merge/60147 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron into lp:openobject-addons
Review: Needs Fixing 1) combine to for loops into one for id in ids: for line in self.browse(cr, uid, ids, context=context): 2) use for record in line.order_line: only if line is shipped, otherwise it will loop useless for all purchase lines -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-776983-ron/+merge/60140 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-776983-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-774057-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-774057-ron/+merge/60017 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-774057-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-771377-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-771377-ron/+merge/59921 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-771377-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-770168-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-770168-ron/+merge/59742 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-770168-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron into lp:openobject-addons
1) Create a new database without demo data 2) Remove Product Category All Products 3) Go to product view and try to create new product -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-768430-ron/+merge/59170 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
its because of these 2 reasons (stated on the bug):
* attrs={'required':[('tracking','=',True)]} is missing in the tree view:
we didn't put it because it still allows to process the picking even if we
have red fields in editable tree, really strange but it gives warning only if
we have it required on form! (so for the sake of fixing this bug, we removed
that!)
* add on each line a button split in lot like on each line of the inventory:
this is not possible as we discussed before
can be done on the picking view before going to process
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/6.0-opw-5267-project_mrp-ach into lp:openobject-addons/6.0
+ proj_uom_ids = self.pool.get(cr,uid,[('name','=','Hour')]) ??
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-5267-project_mrp-ach/+merge/59732
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.0-opw-5267-project_mrp-ach.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-770168-ron into lp:openobject-addons
Review: Needs Fixing
date_expected = time.strftime('%Y-%m-%d'),
^
its taking wrong value as , after value makes it as tuple
also, its a datetime field, so you need to include time values too
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-770168-ron/+merge/59742
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-770168-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-765559-ron into lp:openobject-addons
Review: Needs Fixing this is to fix the sorting of locations... isn't it? I didn't find the sorting... -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-765559-ron/+merge/59498 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-765559-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-768430-ron/+merge/59170 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-770392-ron into lp:openobject-addons
Review: Needs Fixing Need to fix for those products for which supplier delay is greater than 7 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-770392-ron/+merge/59213 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-770392-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons
Review: Needs Fixing
supposed to remove the domain [('purchase_ok', '=', 1)] otherwise it will
still not display all the products
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons
sorry for inconvenience ! -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Rucha (Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework. Requested reviews: qdp (OpenERP) (qdp) For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59332 Improved view of Application Installation wizard Improvement in design of view of project config wizard -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59332 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. === modified file 'base_setup/base_setup_installer.xml' --- base_setup/base_setup_installer.xml 2011-04-27 13:35:18 + +++ base_setup/base_setup_installer.xml 2011-04-28 08:46:27 + @@ -26,24 +26,42 @@ /separator group colspan=8 -field name=crm on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=sale on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=project on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=knowledge on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=stock on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=mrp on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=account_voucher on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=account_accountant on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=purchase on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=hr on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=profile_tools on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=marketing groups=base.group_extended on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=point_of_sale groups=base.group_extended on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ -field name=report_designer groups=base.group_extended on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ +field name=crm colspan=2 on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ +newline/ +field name=sale colspan=2 on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ +newline/ +field name=project colspan=2 on_change=onchange_moduleselection(crm,sale,project,knowledge,stock,mrp,account_accountant,purchase,hr,point_of_sale,marketing,profile_tools,report_designer,association,auction,product_expiry)/ +newline/ +field name
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-server-ksa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-server-ksa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-server/trunk-configuration-server-ksa into lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing 1) Improve code: On a fresh installation of DB i got following error: [2011-04-28 18:45:49,596][readd] ERROR:web-services:[52]: return super(orm_temporal, self).read(cr, uid, data, fields=original_fields, context=context, load=load) [2011-04-28 18:45:49,596][readd] ERROR:web-services:[53]: UnboundLocalError: local variable 'original_fields' referenced before assignment 2) 2 returns in function search at one indentation level? last will never be reached :-D -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
3) args.append(['temporal_date_from', '', context['temporal_date']] *and* ['temporal_date_to', '', context['temporal_date']]) is it working? should be ['', (), ()] -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
4) Another great idea by qdp, we don't need unlink method, set ondelete=cascade on temporal_parent_id, its working cool -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/59368 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-rpa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-temporal-db-rpa into
lp:~openerp-dev/openobject-server/trunk-temporal-db.
Requested reviews:
qdp (OpenERP) (qdp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-rpa/+merge/59450
Fixed wrong operation for args, adding tuple in list was causing problem as it
was adding items of tuple directly in the list
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-rpa/+merge/59450
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-temporal-db.
=== modified file 'bin/addons/base/i18n/vi.po'
--- bin/addons/base/i18n/vi.po 2011-04-19 04:50:43 +
+++ bin/addons/base/i18n/vi.po 2011-04-29 05:42:28 +
@@ -8,13 +8,13 @@
Project-Id-Version: openobject-addons\n
Report-Msgid-Bugs-To: supp...@openerp.com\n
POT-Creation-Date: 2011-01-11 11:14+\n
-PO-Revision-Date: 2011-01-11 08:47+\n
-Last-Translator: OpenERP Administrators Unknown\n
+PO-Revision-Date: 2011-04-26 05:28+\n
+Last-Translator: Phong Nguyen-Thanh Unknown\n
Language-Team: Vietnamese v...@li.org\n
MIME-Version: 1.0\n
Content-Type: text/plain; charset=UTF-8\n
Content-Transfer-Encoding: 8bit\n
-X-Launchpad-Export-Date: 2011-04-19 04:48+\n
+X-Launchpad-Export-Date: 2011-04-27 04:37+\n
X-Generator: Launchpad (build 12758)\n
#. module: base
@@ -118,6 +118,8 @@
You can not write in this document (%s) ! Be sure your user belongs to one
of these groups: %s.
msgstr
+Bạn không thá» viết trong tà i liá»u nà y (% s) ! Hãy chắc chắn ngÆ°á»i dùng của
+bạn thuá»c má»t trong các nhóm: %s.
#. module: base
#: help:ir.model.fields,domain:0
=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py 2011-04-28 17:38:18 +
+++ openerp/osv/orm.py 2011-04-29 05:42:28 +
@@ -4333,7 +4333,7 @@
a, b, c = item
if a == 'id':
new_args += ['|', ('temporal_parent_id', b, c)]
-new_args += item
+new_args.append(item)
#add the time constraint
timenow = time.strftime('%Y-%m-%d %H:%M:%S')
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing 1) needed some code refactoring and optimization, 2) make sure your changes doesn't touch other code (line: 23, 31, 103, 112 of diff of this merge proposal) 3) Put some nice comments in code, so on a quick read of code, one can understand the logic/reason of code (low priority for now) 4) Move unlink to other feature branch (Improve it: 1. Avoid too many looping + for id in ids: + for data in self.browse(cr, uid, ids ,context=context): 2. return inside loop is not good at all) -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-ksa/+merge/59035 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing in write list of ids are passed, but in return only one record is written: this = self.browse(cr, uid, ids[0], context=context) ... return super(orm_temporal, self).write(cr, uid, this.id, vals, context=context) what if I have called write for 3 records? only one will be updated -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-ksa/+merge/59035 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-ksa/+merge/59035 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Rucha (Open ERP) has proposed merging lp:~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework. Requested reviews: qdp (OpenERP) (qdp) For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59222 Reviewed config wizards of all modules and changed type + state in order to follow the behaviour described qdp Improved code -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-reworknew-changesrpa/+merge/59222 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. === modified file 'account/configurable_account_chart.xml' --- account/configurable_account_chart.xml 2011-04-08 12:28:11 + +++ account/configurable_account_chart.xml 2011-04-27 13:41:05 + @@ -616,7 +616,6 @@ record id=action_wizard_multi_chart_todo model=ir.actions.todo field name=nameGenerate Chart of Accounts from a Chart Template/field field name=action_id ref=account.action_wizard_multi_chart/ - field name=stateopen/field field name=typespecial/field /record === modified file 'account_analytic_plans/account_analytic_plans_installer_view.xml' --- account_analytic_plans/account_analytic_plans_installer_view.xml 2011-04-11 13:17:19 + +++ account_analytic_plans/account_analytic_plans_installer_view.xml 2011-04-27 13:41:05 + @@ -13,7 +13,8 @@ record id=account_analytic_plan_installer_todo model=ir.actions.todo field name=action_id ref=account_analytic_plan_form_action_installer/ field name=sequence15/field -field name=typenormal_recurring/field +field name=typenormal/field +field name=stateskip/field /record /data === modified file 'account_sequence/account_sequence_installer_view.xml' --- account_sequence/account_sequence_installer_view.xml 2011-04-08 12:28:11 + +++ account_sequence/account_sequence_installer_view.xml 2011-04-27 13:41:05 + @@ -51,6 +51,7 @@ field name=action_id ref=action_account_seq_installer/ field name=sequence3/field field name=typespecial/field + field name=stateskip/field /record /data === modified file 'association/profile_association.xml' --- association/profile_association.xml 2011-04-08 12:28:11 + +++ association/profile_association.xml 2011-04-27 13:41:05 + @@ -50,7 +50,7 @@ id=config_install_module field name=action_id ref=action_config_install_module/ field name=sequence3/field -field name=typenormal_recurring/field +field name=typespecial/field /record menuitem === modified file 'base_contact/base_contact_installer_view.xml' --- base_contact/base_contact_installer_view.xml 2011-01-14 00:11:01 + +++ base_contact/base_contact_installer_view.xml 2011-04-27 13:41:05 + @@ -53,6 +53,7 @@ field name=action_id ref=action_base_contact_installer/ field name=sequence3/field field name=stateskip/field +field name=typespecial/field /record /data === modified file 'base_report_designer/base_report_designer_installer.xml' --- base_report_designer/base_report_designer_installer.xml 2011-04-08 12:28:11 + +++ base_report_designer/base_report_designer_installer.xml 2011-04-27 13:41:05 + @@ -57,7 +57,7 @@ record id=report_designer_installer_todo model=ir.actions.todo field name=action_id ref=action_report_designer_installer/ field name=sequence3/field -field name=typenormal_recurring/field +field name=typespecial/field /record record id=action_report_designer_wizard model=ir.actions.act_window === modified file 'base_setup/base_setup_installer.xml' --- base_setup/base_setup_installer.xml 2011-04-13 10:50:56 + +++ base_setup/base_setup_installer.xml 2011-04-27 13:41:05 + @@ -112,6 +112,7 @@ record id=migrade_application_installer_modules_todo model=ir.actions.todo field name=action_id ref=action_migrade_application_installer_modules/ field name=typenormal/field + field name=stateskip/field /record !-- Import or create customers configartion view -- @@ -160,7 +161,7 @@ !-- register configuration wizard -- record id=config_wizard_res_product_installer model=ir.actions.todo field name=action_id ref=action_import_create_installer/ - field name=typenormal_recurring/field + field name=typenormal/field field name=stateskip/field /record @@ -214,6 +215,7 @@ record id=config_action_user_preferences_config_form model=ir.actions.todo field name=action_id ref=action_user_preferences_config_form/ field name=typenormal/field + field name=stateskip/field /record !-- Config Wiz Give access
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework-imp-rpa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-server/trunk-configuration-rework-imp-rpa into
lp:~openerp-dev/openobject-server/trunk-configuration-rework.
Requested reviews:
qdp (OpenERP) (qdp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-imp-rpa/+merge/59224
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-imp-rpa/+merge/59224
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-configuration-rework.
=== modified file 'openerp/addons/base/module/wizard/base_module_shortcut_data.xml'
--- openerp/addons/base/module/wizard/base_module_shortcut_data.xml 2011-01-11 06:27:56 +
+++ openerp/addons/base/module/wizard/base_module_shortcut_data.xml 2011-04-27 13:41:09 +
@@ -3,7 +3,7 @@
data noupdate=1
record id=ir_ui_view_sc_configuration model=ir.ui.view_sc
-field name=nameReconfigure/field
+field name=nameAdd More Features/field
field name=resourceir.ui.menu/field
field name=user_id ref=base.user_root/
field name=res_id ref=menu_view_base_module_configuration/
=== modified file 'openerp/addons/base/res/res_config.py'
--- openerp/addons/base/res/res_config.py 2011-04-11 12:25:09 +
+++ openerp/addons/base/res/res_config.py 2011-04-27 13:41:09 +
@@ -77,7 +77,12 @@
cr.execute(select 1 from res_groups_users_rel where uid=%s and gid IN %s,(uid, tuple(todo_groups),))
dont_skip_todo = bool(cr.fetchone())
if dont_skip_todo:
-return todos.browse(cr, uid, active_todos[0], context=None)
+res = todos.browse(cr, uid, active_todos[0], context=None)
+# Wizards that directly opens a form stays in Todo state even if its called,
+# as next_action is not called, so, setting state as done 'manually'
+if res.action_id.target == 'current':
+res.write({'state': 'done'})
+return res
else:
todos.write(cr, uid, active_todos[0], {'state':'skip'}, context=None)
return self._next_action(cr, uid)
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-765901-ron into lp:openobject-addons
Review: Needs Fixing 1) ...If you are using Push/Pull flows than type must be 'on Order' than?? = then will be good if you improve the sentence, also its confusing in sale, as push/pull rules are applicable only after stock_location module is installed 2) +* Pull/Push flows are only triggered when the sale order line is in 'on Order' Sale order line or procurement method of the sale order line? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-765901-ron/+merge/58928 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-765901-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:openobject-server
The proposal to merge lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:openobject-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59020 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59020 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
what is that??? Let me remind: according to the discussion we have to make the following screen, |Customer Relationship Management | |Sales Management | |Project Management| |HR Management | | Attendances Payroll | | Holidays Timesheet| | ... | We have current screen with col=4, so we need to make it with col=2 in order to display the view properly So its just a little change for that, Please don't bother for the look (as you said it will be completely reviewed and changed later) hope this helps :-) -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Disapprove its a mess with latest changes of addons, please refer to another merge proposal -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Approve seems ok for me, still to be validated... (I would like to have a better comment in code in order to increase readability of the code, can you please add proper comment) -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-767039-aag into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-767039-aag/+merge/58615 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-767039-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-766916-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-766916-ron/+merge/58644 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-766916-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag into lp:openobject-addons
Review: Needs Fixing Double check the bug description, We should have company field in group by as well as a search parameter, so: 1) Add company_id field in Extended filter (after a vertical separator), and with widget=selection 2) put a separator between type and company buttons 3) no need to display this field in tree view -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag into lp:openobject-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-755456-ron into lp:openobject-addons
Review: Abstain
by this changes now we have inconsistency between:
para style=terp_headerPacking List: [[ (picking.type == 'out' or
removeParentNode('para')) and '' ]] [[ picking.name ]] /para
para style=terp_headerPicking List: [[ (picking.type == 'internal' or
removeParentNode('para')) and '' ]] [[ picking.name ]]/para
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-755456-ron/+merge/57438
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-755456-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Needs Fixing Need to test more with costing method=average -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-crm-fixes-rpa into lp:~openerp-dev/openobject-addons/trunk-bugfixes-Ind
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-crm-fixes-rpa into
lp:~openerp-dev/openobject-addons/trunk-bugfixes-Ind.
Requested reviews:
OpenERP RD Team (openerp-dev)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-crm-fixes-rpa/+merge/57632
• Fixed missing functionality for Allow unlink in case sections
• Meeting recurrency option, Way to end reccurency, End date, then field
Repeat Until must be set as required
• Fix: Meeting recurrency option, Repeat Until is not working properly, if I
set 15 th as until date, it must include 15th , but it takes meetings till 14th
only
• Sales/Meetings/Synchronyze this calendar should have atleast ok or cancel
button
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-crm-fixes-rpa/+merge/57632
Your team OpenERP RD Team is requested to review the proposed merge of
lp:~openerp-dev/openobject-addons/trunk-crm-fixes-rpa into
lp:~openerp-dev/openobject-addons/trunk-bugfixes-Ind.
=== modified file 'base_calendar/base_calendar.py'
--- base_calendar/base_calendar.py 2011-02-18 10:09:57 +
+++ base_calendar/base_calendar.py 2011-04-14 08:32:32 +
@@ -1296,7 +1296,7 @@
if name == UNTIL:
is_until = True
value = parser.parse(value)
-rrule_until_date = parser.parse(value.strftime(%Y-%m-%d))
+rrule_until_date = parser.parse(value.strftime(%Y-%m-%d %H:%M:%S))
if until_date and until_date = rrule_until_date:
until_date = rrule_until_date
if until_date:
=== modified file 'caldav/wizard/caldav_browse_view.xml'
--- caldav/wizard/caldav_browse_view.xml 2011-01-17 22:03:45 +
+++ caldav/wizard/caldav_browse_view.xml 2011-04-14 08:32:32 +
@@ -15,8 +15,10 @@
separator string=Description colspan=4/
field name=description colspan=4 nolabel=1/
separator colspan=4/
-
-
+ group col=4 colspan=4
+label string= colspan=2/
+button special=cancel string=_Close icon=gtk-close/
+ /group
/group
/form
/field
=== modified file 'crm/crm.py'
--- crm/crm.py 2011-03-04 12:53:34 +
+++ crm/crm.py 2011-04-14 08:32:32 +
@@ -199,6 +199,13 @@
user = self.pool.get('res.users').browse(cr, uid, uid, context=context)
return user.context_section_id.id or False
+def unlink(self, cr, uid, ids, context={}):
+for case in self.browse(cr, uid, ids, context):
+if (not case.section_id.allow_unlink) and (case.state 'draft'):
+raise osv.except_osv(_('Warning !'),
+_('You can not delete this case. You should better cancel it.'))
+return super(crm_case, self).unlink(cr, uid, ids, context)
+
def _find_next_stage(self, cr, uid, stage_list, index, current_seq, stage_pool, context=None):
if index + 1 == len(stage_list):
return False
=== modified file 'crm/crm_meeting_view.xml'
--- crm/crm_meeting_view.xml 2011-04-07 06:19:38 +
+++ crm/crm_meeting_view.xml 2011-04-14 08:32:32 +
@@ -179,7 +179,7 @@
field name=count attrs={'invisible' : [('end_type', '!=', 'count')] }/
label string= colspan=2 /
newline /
-field name=end_date attrs={'invisible' : [('end_type', '!=', 'end_date')] }/
+field name=end_date attrs={'invisible' : [('end_type', '!=', 'end_date')], 'required': [('end_type', '=', 'end_date')]}/
newline /
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Needs Fixing -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/6.0-bug_725908-ach into lp:openobject-addons/6.0
please refer: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-725908-ksa/+merge/52519 -- https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-bug_725908-ach/+merge/56554 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-bug_725908-ach. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Needs Fixing 1) the field production lot should be required based on the values of Track Incoming or Track Outgoing + type of picking, not by the value of Track Manufacturing REMOVE: fields.related with track_prodlot of product ADD: fields.function which will be True/False based on the values of Track Incoming or Track Outgoing + type of picking 2) processing of product with different uom is not working fine: I have a product PC1 with default uom=PCE, 10 products in stock I make a delivery order of 8 PCE of PC1 I process 1 pack of 5 of PC1 (uom with category unit, 5 times bigger than reference uom) I see that the picking has 7 PCE of PC1 to be processed, which is wrong, it must be 3, 3) needs some better validation for uom: I have a picking with 8 PCE and if I select 8 pack of 5 while processing, it MUST not allow to process -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag/+merge/56691 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag/+merge/56691 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag/+merge/56689 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag/+merge/56689 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Needs Fixing Point 2 seems not fixed yet... -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/6.0-opw_bug-747379-rpa into lp:openobject-addons/6.0
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/6.0-opw_bug-747379-rpa into
lp:openobject-addons/6.0.
Requested reviews:
OpenERP Core Team (openerp)
Related bugs:
Bug #747379 in OpenERP Addons: [6.0] inventory : wrong stocks moves
generated when using production lot
https://bugs.launchpad.net/openobject-addons/+bug/747379
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw_bug-747379-rpa/+merge/56936
Fixed validating inventory with production lot
--
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw_bug-747379-rpa/+merge/56936
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/6.0-opw_bug-747379-rpa.
=== modified file 'stock/product.py'
--- stock/product.py 2011-01-14 00:11:01 +
+++ stock/product.py 2011-04-08 13:38:13 +
@@ -248,6 +248,7 @@
date_str = date=%s
date_values = [to_date]
+prodlot_id = context.get('prodlot_id', False)
# TODO: perhaps merge in one query.
if date_values:
@@ -257,10 +258,11 @@
cr.execute(
'select sum(product_qty), product_id, product_uom '\
'from stock_move '\
-'where location_id NOT IN %s'\
-'and location_dest_id IN %s'\
-'and product_id IN %s'\
-'and state IN %s' + (date_str and 'and '+date_str+' ' or '') +''\
+'where location_id NOT IN %s '\
+'and location_dest_id IN %s '\
+'and product_id IN %s '\
+'' + (prodlot_id and ('and prodlot_id = ' + str(prodlot_id)) or '') + ' '\
+'and state IN %s ' + (date_str and 'and '+date_str+' ' or '') +' '\
'group by product_id,product_uom',tuple(where))
results = cr.fetchall()
if 'out' in what:
@@ -268,10 +270,11 @@
cr.execute(
'select sum(product_qty), product_id, product_uom '\
'from stock_move '\
-'where location_id IN %s'\
+'where location_id IN %s '\
'and location_dest_id NOT IN %s '\
-'and product_id IN %s'\
-'and state in %s' + (date_str and 'and '+date_str+' ' or '') + ''\
+'and product_id IN %s '\
+'' + (prodlot_id and ('and prodlot_id = ' + str(prodlot_id)) or '') + ' '\
+'and state in %s ' + (date_str and 'and '+date_str+' ' or '') + ' '\
'group by product_id,product_uom',tuple(where))
results2 = cr.fetchall()
uom_obj = self.pool.get('product.uom')
=== modified file 'stock/stock.py'
--- stock/stock.py 2011-04-04 10:02:08 +
+++ stock/stock.py 2011-04-08 13:38:13 +
@@ -2556,7 +2556,7 @@
move_ids = []
for line in inv.inventory_line_id:
pid = line.product_id.id
-product_context.update(uom=line.product_uom.id,date=inv.date)
+product_context.update(uom=line.product_uom.id, date=inv.date, prodlot_id=line.prod_lot_id.id)
amount = location_obj._product_get(cr, uid, line.location_id.id, [pid], product_context)[pid]
change = line.product_qty - amount
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-747379-rpa into lp:openobject-addons
Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-747379-rpa into
lp:openobject-addons.
Requested reviews:
qdp (OpenERP) (qdp)
Related bugs:
Bug #747379 in OpenERP Addons: [6.0] inventory : wrong stocks moves
generated when using production lot
https://bugs.launchpad.net/openobject-addons/+bug/747379
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-747379-rpa/+merge/56515
Fixed wrong qty in stock move(posted inventory) when confirming inventory for
the products which have earlier moves with production lot and we use the same
prodlot
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-747379-rpa/+merge/56515
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-747379-rpa.
=== modified file 'stock/product.py'
--- stock/product.py 2011-01-14 00:11:01 +
+++ stock/product.py 2011-04-06 06:56:31 +
@@ -248,6 +248,7 @@
date_str = date=%s
date_values = [to_date]
+prodlot_id = context.get('prodlot_id', False)
# TODO: perhaps merge in one query.
if date_values:
@@ -257,10 +258,11 @@
cr.execute(
'select sum(product_qty), product_id, product_uom '\
'from stock_move '\
-'where location_id NOT IN %s'\
-'and location_dest_id IN %s'\
-'and product_id IN %s'\
-'and state IN %s' + (date_str and 'and '+date_str+' ' or '') +''\
+'where location_id NOT IN %s '\
+'and location_dest_id IN %s '\
+'and product_id IN %s '\
+'' + (prodlot_id and ('and prodlot_id = ' + str(prodlot_id)) or '') + ' '\
+'and state IN %s ' + (date_str and 'and '+date_str+' ' or '') +' '\
'group by product_id,product_uom',tuple(where))
results = cr.fetchall()
if 'out' in what:
@@ -268,10 +270,11 @@
cr.execute(
'select sum(product_qty), product_id, product_uom '\
'from stock_move '\
-'where location_id IN %s'\
+'where location_id IN %s '\
'and location_dest_id NOT IN %s '\
-'and product_id IN %s'\
-'and state in %s' + (date_str and 'and '+date_str+' ' or '') + ''\
+'and product_id IN %s '\
+'' + (prodlot_id and ('and prodlot_id = ' + str(prodlot_id)) or '') + ' '\
+'and state in %s ' + (date_str and 'and '+date_str+' ' or '') + ' '\
'group by product_id,product_uom',tuple(where))
results2 = cr.fetchall()
uom_obj = self.pool.get('product.uom')
=== modified file 'stock/stock.py'
--- stock/stock.py 2011-03-31 10:07:25 +
+++ stock/stock.py 2011-04-06 06:56:31 +
@@ -2580,7 +2580,7 @@
move_ids = []
for line in inv.inventory_line_id:
pid = line.product_id.id
-product_context.update(uom=line.product_uom.id,date=inv.date)
+product_context.update(uom=line.product_uom.id, date=inv.date, prodlot_id=line.prod_lot_id.id)
amount = location_obj._product_get(cr, uid, line.location_id.id, [pid], product_context)[pid]
change = line.product_qty - amount
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-734191-ron into lp:openobject-addons
Review: Disapprove ok, so I am rejecting this proposal for the clarity -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-734191-ron/+merge/55121 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-734191-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-734191-ron into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-734191-ron into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-734191-ron/+merge/55121 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-734191-ron/+merge/55121 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-734191-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron into lp:openobject-addons
Review: Needs Fixing
Working perfect now.. needs some refactoring:
sale/sale.py
+ if not uom:
+ uom =product_obj.uom_id and product_obj.uom_id.id
above part of code is none of use as we already have if conditions for uom
before this code:
1. if (not uom) and (not uos):
2. elif uos and not uom:
should be like:
price = self.pool.get('product.pricelist').price_get(cr, uid, [pricelist],
product, qty or 1.0, partner_id, {
-'uom': uom,
+'uom': uom or result.get('product_uom'),
'date': date_order,
})[pricelist]
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag/+merge/55709 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag/+merge/55709 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag into lp:openobject-addons
Review: Disapprove not in addons -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag/+merge/55709 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-rework-addons-23-march-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron into lp:openobject-addons
Review: Needs Fixing the fix doesn't fix the problem totally... still its giving wrong values if the product have UOS -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-740202-ron into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-740202-ron/+merge/55315 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-740202-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Fixing 1) need to return the same wizard when we click on Schedule Upgrade 2) Improve help text for module's menu to describe the new steps to install a module -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag/+merge/54673 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Also, it skips the installation of Application from config wizard (its only changing the status instead of installing the module) fix it too -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-server-23-mar-aag/+merge/54673 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742336-ksa into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742336-ksa/+merge/55111 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742336-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-739474-ksa into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739474-ksa/+merge/54509 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-739474-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons
Review: Needs Fixing does active field name suit here? its not actively speaking its purpose to put it as related with tracking/lot stuff, I am quite disappointed... please fix is asap, active is a special field, never use it unless the field is really meant for activeness of record, -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa into lp:openobject-addons
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-followup-multi-currencies-improvement-ron into lp:~openerp-dev/openobject-addons/trunk-followup-multi-currencies
Review: Approve -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-followup-multi-currencies-improvement-ron/+merge/54326 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-followup-multi-currencies. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
