Re: [PATCH] rfkill: Regulator consumer driver for rfkill
On Don, 2011-04-07 at 12:09 +0200, Johannes Berg wrote: > On Thu, 2011-04-07 at 12:01 +0200, Bernd Petrovitsch wrote: > > On Mit, 2011-04-06 at 20:46 +0200, Johannes Berg wrote: > > > On Wed, 2011-04-06 at 20:12 +0200, Paul Bolle wrote: > > [...] > > > > But doesn't > > > > depends on RFKILL || !RFKILL > > > > > > > > always evaluate to true when running "make *config"? (Even if RFKILL is > > > > an unknown symbol when that expression is parsed!) > > > > > > No, it will not, you're forgetting that these things are tristate. > > > > Boolean operators for tristate logic isn't intuitive at all IMHO. > > *shrug*. You're free to propose patches to the kconfig system to make it > more intuitive. :-) FullACK;-) But no intuitive tristate logic operators come to my mind (otherwise I would have mentioned them above). And there are more logic implications in "depends on RFKILL". Hmm, I have to think more about it Bernd -- Bernd Petrovitsch Email : be...@petrovitsch.priv.at LUGA : http://www.luga.at
Re: [PATCH] rfkill: Regulator consumer driver for rfkill
On Mit, 2011-04-06 at 20:46 +0200, Johannes Berg wrote: > On Wed, 2011-04-06 at 20:12 +0200, Paul Bolle wrote: [...] > > But doesn't > > depends on RFKILL || !RFKILL > > > > always evaluate to true when running "make *config"? (Even if RFKILL is > > an unknown symbol when that expression is parsed!) > > No, it will not, you're forgetting that these things are tristate. Boolean operators for tristate logic isn't intuitive at all IMHO. Bernd -- Bernd Petrovitsch Email : be...@petrovitsch.priv.at LUGA : http://www.luga.at
Re: [PATCH] rfkill: Regulator consumer driver for rfkill
On Thu, 2011-04-07 at 12:01 +0200, Bernd Petrovitsch wrote: > On Mit, 2011-04-06 at 20:46 +0200, Johannes Berg wrote: > > On Wed, 2011-04-06 at 20:12 +0200, Paul Bolle wrote: > [...] > > > But doesn't > > > depends on RFKILL || !RFKILL > > > > > > always evaluate to true when running "make *config"? (Even if RFKILL is > > > an unknown symbol when that expression is parsed!) > > > > No, it will not, you're forgetting that these things are tristate. > > Boolean operators for tristate logic isn't intuitive at all IMHO. *shrug*. You're free to propose patches to the kconfig system to make it more intuitive. :-) johannes
