Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
Hello. On 10-05-2011 0:11, Antonio Ospite wrote: Don't wrap regulator_get() inside an #ifdef CONFIG_REGULATOR anymore, as now (since be1a50d) Need the summary of that commit cited too -- for the human readers. it correctly degenerates and returns NULL when the regulator framework is disabled. Signed-off-by: Antonio Ospiteosp...@studenti.unina.it WBR, Sergei
Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote: I was blindly trusting code already in mainline again, and for that I apologize, I finally took the time to look at the implementation of IS_ERR() and test its use, and being IS_ERR(NULL) true it is not what we want indeed, see the attached test program. So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL(); how does that sound? Am I still missing anything? That sounds a lot better, and should avoid the issue which caused me to throw out the original patch.
Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote: So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL(); how does that sound? Am I still missing anything? Looks good to me. Or changing the regulator_get() stub to return an error (-ENOSYS?) might be worth it? No, the whole point of stubbing out the API is that it allows most consumers which just do simple enables and disables to run without needing to worry if the regulator API is compiled in or not.
