Re: [Openipmi-developer] [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe_new()

[Corey Minyard]

On Fri, Nov 18, 2022 at 11:45:39PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König 
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.

Thanks, queued for next release.

-corey

> 
> Signed-off-by: Uwe Kleine-König 
> ---
>  drivers/char/ipmi/ssif_bmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
> index 2d8069386398..caee848261e9 100644
> --- a/drivers/char/ipmi/ssif_bmc.c
> +++ b/drivers/char/ipmi/ssif_bmc.c
> @@ -797,7 +797,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum 
> i2c_slave_event event, u8
>   return ret;
>  }
>  
> -static int ssif_bmc_probe(struct i2c_client *client, const struct 
> i2c_device_id *id)
> +static int ssif_bmc_probe(struct i2c_client *client)
>  {
>   struct ssif_bmc_ctx *ssif_bmc;
>   int ret;
> @@ -860,7 +860,7 @@ static struct i2c_driver ssif_bmc_driver = {
>   .name   = DEVICE_NAME,
>   .of_match_table = ssif_bmc_match,
>   },
> - .probe  = ssif_bmc_probe,
> + .probe_new  = ssif_bmc_probe,
>   .remove = ssif_bmc_remove,
>   .id_table   = ssif_bmc_id,
>  };
> -- 
> 2.38.1
> 


___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer

[Openipmi-developer] [PATCH 605/606] ipmi: ssif_bmc: Convert to i2c's .probe_new()

[Uwe Kleine-König]

From: Uwe Kleine-König 

The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.

Signed-off-by: Uwe Kleine-König 
---
 drivers/char/ipmi/ssif_bmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index 2d8069386398..caee848261e9 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -797,7 +797,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum 
i2c_slave_event event, u8
return ret;
 }
 
-static int ssif_bmc_probe(struct i2c_client *client, const struct 
i2c_device_id *id)
+static int ssif_bmc_probe(struct i2c_client *client)
 {
struct ssif_bmc_ctx *ssif_bmc;
int ret;
@@ -860,7 +860,7 @@ static struct i2c_driver ssif_bmc_driver = {
.name   = DEVICE_NAME,
.of_match_table = ssif_bmc_match,
},
-   .probe  = ssif_bmc_probe,
+   .probe_new  = ssif_bmc_probe,
.remove = ssif_bmc_remove,
.id_table   = ssif_bmc_id,
 };
-- 
2.38.1



___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer