[8u60] Request for review: RT-40385: [Mac] NPE in window close unit tests
David and Kevin, Please review my fix for the recent regression caused by my fix for RT-39813. Both changes crop up in the systemTests and are necessary to adjust for the close sequence timing change introduced in RT-39813. Tested using: gradle -PFULL_TEST=true :systemTests:test Thanks much. --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-40385.01/ JIRA - https://javafx-jira.kenai.com/browse/RT-40385
9-dev and 8u-dev unlocked following this week's sanity testing eom
Re: [8u60] Request for review: RT-40385: [Mac] NPE in window close unit tests
As a reminder, bug fixes should go into 9-dev before (or at the same time) as into 8u-dev. -- Kevin Morris Meyer wrote: David and Kevin, Please review my fix for the recent regression caused by my fix for RT-39813. Both changes crop up in the systemTests and are necessary to adjust for the close sequence timing change introduced in RT-39813. Tested using: gradle -PFULL_TEST=true :systemTests:test Thanks much. --morris WEBREV - http://cr.openjdk.java.net/~morris/RT-40385.01/ JIRA - https://javafx-jira.kenai.com/browse/RT-40385
Re: Debugging CSS
On 6-4-2015 00:58, David Grieve wrote: On 4/5/15 3:56 AM, Tom Eugelink wrote: I have another interesting behavior involving CSS. The gauge has a text representation of the value of the needle, which can be formatted using DecimalFormat. The format string can be set with a styleable property. In the example this property is set, via setStyle(), to something with a unit postfix, e.g. ##0.0W so the gauge will show watts. This works. But as soon as totally unrelated classes are removed from the gauge, the styleable property reverts to its initial value, but the style string is unchanged! This behavior is introduced in 8u20, in 8u00 it works as intended. And in 8u40? The behavior is still present in 8u40. It is easy to see; checkout JFXtras labs from github, open the project in you favorite IDE, and start the SimpleMetroArcGaugeTrail1 class. It's the gauge with the W in the text, at first :-) Tom
Re: Debugging CSS
You should file an issue in jira for this. On 4/6/15 3:31 AM, Tom Eugelink wrote: On 6-4-2015 00:58, David Grieve wrote: On 4/5/15 3:56 AM, Tom Eugelink wrote: I have another interesting behavior involving CSS. The gauge has a text representation of the value of the needle, which can be formatted using DecimalFormat. The format string can be set with a styleable property. In the example this property is set, via setStyle(), to something with a unit postfix, e.g. ##0.0W so the gauge will show watts. This works. But as soon as totally unrelated classes are removed from the gauge, the styleable property reverts to its initial value, but the style string is unchanged! This behavior is introduced in 8u20, in 8u00 it works as intended. And in 8u40? The behavior is still present in 8u40. It is easy to see; checkout JFXtras labs from github, open the project in you favorite IDE, and start the SimpleMetroArcGaugeTrail1 class. It's the gauge with the W in the text, at first :-) Tom
Re: Debugging CSS
https://javafx-jira.kenai.com/browse/RT-40437 On 6-4-2015 16:25, David Grieve wrote: You should file an issue in jira for this. On 4/6/15 3:31 AM, Tom Eugelink wrote: On 6-4-2015 00:58, David Grieve wrote: On 4/5/15 3:56 AM, Tom Eugelink wrote: I have another interesting behavior involving CSS. The gauge has a text representation of the value of the needle, which can be formatted using DecimalFormat. The format string can be set with a styleable property. In the example this property is set, via setStyle(), to something with a unit postfix, e.g. ##0.0W so the gauge will show watts. This works. But as soon as totally unrelated classes are removed from the gauge, the styleable property reverts to its initial value, but the style string is unchanged! This behavior is introduced in 8u20, in 8u00 it works as intended. And in 8u40? The behavior is still present in 8u40. It is easy to see; checkout JFXtras labs from github, open the project in you favorite IDE, and start the SimpleMetroArcGaugeTrail1 class. It's the gauge with the W in the text, at first :-) Tom
