[8u60] Request for review: RT-39297: FXM player fails to exit

2015-04-17 Thread Kirill Kirichenko

Hi Alexander.
Could you please review this fix for flvdemux.c.
gst_pad_pull_range in the code above the change may return FLOW_ERROR is 
the buffer is of some enormous size. We should react to the error.


Also some files play well but don't receive EOS or Error because is 
coming with presentation timestamp which is far ahead te current time. 
So this isn't a erroneous situation but takes time to finish.


webrev: https://javafx-jira.kenai.com/browse/RT-39297
jira: http://cr.openjdk.java.net/~stayer/RT-38079


Re: [8u60] Request for review: RT-39297: FXM player fails to exit

2015-04-17 Thread Kirill Kirichenko

Correct jira link: https://javafx-jira.kenai.com/browse/RT-38079

On 17.04.2015 15:47, Kirill Kirichenko wrote:

Hi Alexander.
Could you please review this fix for flvdemux.c.
gst_pad_pull_range in the code above the change may return FLOW_ERROR is
the buffer is of some enormous size. We should react to the error.

Also some files play well but don't receive EOS or Error because is
coming with presentation timestamp which is far ahead te current time.
So this isn't a erroneous situation but takes time to finish.

webrev: https://javafx-jira.kenai.com/browse/RT-39297
jira: http://cr.openjdk.java.net/~stayer/RT-38079


Re: Some questions about participating in development

2015-04-17 Thread Kevin Rushforth

Hi Robert,

Glad to hear it. The reason for the test failure is that the webkit 
native library (jfxwebkit) isn't built by default, but is copied from 
the JDK you use to build the rest of FX. Any number of interesting 
errors can happen if you have a mismatch in the native library versus 
the rest of WebKit. This particular unit test changed as part of the 
wekbkit upgrade, so I guess you have an old (pre-upgrade) version of the 
native library and a new (post-update) version of the Java code and unit 
tests for WebView. The solution would be to use JDK 8u60-b08 or later to 
build FX.


As for IDE, I use NetBeans, but not the gradle plugin for NB. I open the 
projects under rt/netbeans with NB 8 and it works for me. Others on our 
team use IntelliJ.


If you have a patch for a specific issue, it might be easiest to e-mail 
the patch to the assignee and they can attach it (just like we ask bug 
reporters to do for images, larger test programs, etc). Also, I will 
volunteer to attach a patch you send to any issue.


-- Kevin


Robert Lichtenberger wrote:
Hello everyone, since I recently spammed https://javafx-jira.kenai.com 
with bug reports :-), I decided it's time to take the next step and 
contribute patches.


With the help of 
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX I was 
able to checkout  build the rt module and execute gradle test, which 
BTW reported:
Exception in thread JavaFX Application Thread Exception in thread 
JavaFX Application Thread

javafx.scene.web.JavaScriptBridgeTest  testBridgeBadOverloading FAILED
java.lang.AssertionError: caught unexpected exception: 
netscape.javascript.JSException: TypeError: 'undefined' is not a 
function (evaluating 'sb['append)int)'](123)')

at org.junit.Assert.fail(Assert.java:91)
at 
javafx.scene.web.JavaScriptBridgeTest.executeShouldFail(JavaScriptBridgeTest.java:370) 

at 
javafx.scene.web.JavaScriptBridgeTest.executeShouldFail(JavaScriptBridgeTest.java:374) 

at 
javafx.scene.web.JavaScriptBridgeTest.lambda$testBridgeBadOverloading$84(JavaScriptBridgeTest.java:424) 



All other tests (loads of them, very nice!) have executed successfully.

I have also successfully executed gradle zips.

Now I wanted to start using an IDE. Under 
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX there 
are gradle tasks under section IDE tasks for IDEA and Netbeans 
project creation. These tasks are missing from my output of gradle 
tasks. Is there anything I forgot to install? Any unseen dependencies? 
What is the recommended / most used IDE of JavaFX developers?


Also how do I submit patches? I already have signed (but still need to 
send ...) the OCA. There is no way (for me) to attach anything in 
JIRA. Should I send patches to this list?


Best regards,
Robert Lichtenberger



In(Sanity) Testing Mondays

2015-04-17 Thread Vadim Pakhnushev

Reminder, Monday is our weekly sanity testing.

You can find your testing assignment at:

https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing

Also please remember that the repo will be locked from 1am PDT until 1pm 
PDT.


Happy testing!

Thanks,
Vadim


[9] post-commit notification: RT-40529 Java crashes when trying to render go.com

2015-04-17 Thread Anton Tarasov

JIRA: https://javafx-jira.kenai.com/browse/RT-40529
webrev: http://cr.openjdk.java.net/~ant/RT-40529/webrev.0

Regards,
Anton.