Code Review Request For JDK-8140306: Add regression test for JDK-8136495
Hi Kevin, Please review the proposed robot test: http://cr.openjdk.java.net/~ckyang/JDK-8140306/webrev.00/ I have verified that it works well on Mac, Linux and Windows. Thanks, - Chien
Re: [9] Request for API review: 8143158 [Text, TextFlow] Make public API from internal "impl" APIs
Just a reminder. The proposed API for TextFlow is kept simple as described in JIRA. Thanks, Leif On 2015-11-29 16:30, Leif Samuelsson wrote: Kevin, Phil, et al, Please review the proposed new API for Text and TextFlow to open up existing internal methods for text selection, etc. Most of the new Text API is simply renaming of formerly deprecated methods, while the TextFlow API is added to expose underlying layout functionality and matches the corresponding Text API. https://bugs.openjdk.java.net/browse/JDK-8143158 Code review will follow. Thanks, Leif
review for: 8148489: conditional execution of unstable tests
Kevin,
https://bugs.openjdk.java.net/browse/JDK-8148489
webrev: http://cr.openjdk.java.net/~ddhill/8148489/
@Test public void unstable_test_check() {
assumeTrue(Boolean.getBoolean("unstable.test"));
assertTrue(false);
}
ignored by default, failed as expected with -PUNSTABLE_TEST=true
--
David Hill
Java Embedded Development
"A man's feet should be planted in his country, but his eyes should survey the
world."
-- George Santayana (1863 - 1952)
In(Sanity) Testing Mondays
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim
Re: TableCellSkinBase: columnVisibility/Width should be protected
just noticed that I can't even compile any subclass, so filed a bug: https://bugs.openjdk.java.net/browse/JDK-8148573 Zitat von faste...@swingempire.de: On the move into public, its abstract methods columnVisibility/Width/Property changed scope from protected to package - this makes the base class rather useless for extension: it's main job is sync'ing the cell's visible property to the column's visible property and triggering and doing the cell's layout. Both are possible only, if subclasses provide the column properties. Would suggest to change scope back to protected. Or any special reasons for not doing it? Cheers Jeanette
TableCellSkinBase: columnVisibility/Width should be protected
On the move into public, its abstract methods columnVisibility/Width/Property changed scope from protected to package - this makes the base class rather useless for extension: it's main job is sync'ing the cell's visible property to the column's visible property and triggering and doing the cell's layout. Both are possible only, if subclasses provide the column properties. Would suggest to change scope back to protected. Or any special reasons for not doing it? Cheers Jeanette
