Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
Thanks for the reminder. I have just resent it with the main Bug ID and 
updated the JIRA.


- Chien


On 08/05/16 13:47, Kevin Rushforth wrote:
This review request is using the wrong Bug ID. We never use the 
backport ID for anything (ever), so please resend with the correct 
subject line, which should have the Bug ID of the main bug: 8156078


Thanks.

-- Kevin


Chien Yang wrote:

Hi Kevin,

Please review the proposed backport:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302

Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/

Thanks,

- Chien





[8udev (backport)] Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang

Hi Kevin,

Please review the proposed backport:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078

Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/backport.00/

Thanks,

- Chien



Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Kevin Rushforth
This review request is using the wrong Bug ID. We never use the backport 
ID for anything (ever), so please resend with the correct subject line, 
which should have the Bug ID of the main bug: 8156078


Thanks.

-- Kevin


Chien Yang wrote:

Hi Kevin,

Please review the proposed backport:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302

Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/

Thanks,

- Chien



[8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang

Hi Kevin,

Please review the proposed backport:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302

Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/

Thanks,

- Chien



Re: In(Sanity) Testing Mondays

2016-08-05 Thread Kevin Rushforth

+1

If you aren't testing in JIGSAW mode then you aren't testing what we ship.

Further, once Dave implements 
https://bugs.openjdk.java.net/browse/JDK-8161704 then legacy mode will 
necessarily go away.


-- Kevin


David Hill wrote:

On 8/5/16, 10:32 AM, Vadim Pakhnushev wrote:

Reminder, Monday is our weekly sanity testing.

I just updated the OpenJFX Wiki - the section onSandbox Testing with 
JDK9 
 



It would be good for us to transitioning to using modules when testing 
as that is what we will be delivering.


Using "built" or downloaded modules is really easy with the 
@xpatch.args mechanism which is detailed on the wiki page.


As an added bonus - any of the internal test scripts that use jfxrun 
will now honor the JFX_XPATCH if JIGSAW_HOME is set.





Re: In(Sanity) Testing Mondays

2016-08-05 Thread David Hill

On 8/5/16, 10:32 AM, Vadim Pakhnushev wrote:

Reminder, Monday is our weekly sanity testing.


I just updated the OpenJFX Wiki - the section onSandbox Testing with JDK9 


It would be good for us to transitioning to using modules when testing as that 
is what we will be delivering.

Using "built" or downloaded modules is really easy with the @xpatch.args 
mechanism which is detailed on the wiki page.

As an added bonus - any of the internal test scripts that use jfxrun will now 
honor the JFX_XPATCH if JIGSAW_HOME is set.


--
David Hill
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the 
world."
-- George Santayana (1863 - 1952)



In(Sanity) Testing Mondays

2016-08-05 Thread Vadim Pakhnushev

Reminder, Monday is our weekly sanity testing.

You can find your testing assignment at:
https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing

Also please remember that the repo will be locked from 1am PST until 1pm 
PST.


Happy testing!

Thanks,
Vadim