MarlinFX upgrade 0.7.5
Hi, Please review this MarlinFX upgrade to Marlin 0.7.5: JBS: no bug yet for OpenJFX 10 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-075.0/ Changes: - Renderers: fixed block processing - dead code & few comment removals in Strokers - fixed all floating-point number literals to be x.0f or x.0d to simplify the conversion between float & double variants PS: I plan to run later FindBugs, Netbeans & IntelliJ code analysis tools to fix any warning Cheers, Laurent
[10] Code Review Request For 8178837: Potential performance drawback due to type mismatch
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8178837 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8178837/webrev.00/ Thanks, - Chien
[9] Review request: 8091730: Enable -Xdoclint:all to treat all javadoc warnings as errors
Please review the following to enable building the FX docs with "javadoc -Xdoclint:all". https://bugs.openjdk.java.net/browse/JDK-8091730 http://cr.openjdk.java.net/~kcr/8091730/webrev.00/ This will allow to catch doc warnings early before delivering them to the JDK 9 build, and will allow the unified JDK javadoc build to use -Xdoclint for javafx.* modules. -- Kevin
[9] Code Review Request For 8178804: Excessive memory consumption in TriangleMesh/MeshView
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8178804 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8178804/webrev.00/ Thanks, - Chien
Re: Review: Remove Lens code (finally)
As a note, once the review is completed this will only go into OpenJFX 10. It will not be backported to 9 or 8. -- Kevin Chris Newland wrote: Thanks for the heads-up David. I've checked my chriswhocodes.com web server logs and around 90 unique IPs per week are still downloading the ARM OpenJFX overlay builds so before this patch is merged I'll take a snapshot of the last working ARM build and keep that available. Kind regards, Chris On Tue, April 18, 2017 21:47, David Hill wrote: Here is the change to remove the Lens code. caviots: There were some minor gradle fixes required to cross build. I removed all of the arm*gradle files except for armv6hf. Arm is not a supported platform anymore and by reducing to the most likely to be used (because of the Pi), I can concentrate what few resources I can to checking that platform still builds. Armv6hf builds cleanly. I don't have a working Pi configuration to test it, and need to figure out building the JDK for ARM before I really can test it even then. We have not been using Lens for JDK 8,9 so this should be safe. https://bugs.openjdk.java.net/browse/JDK-8090969 webrev: http://cr.openjdk.java.net/~ddhill/8090969 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)
Re: Review: Remove Lens code (finally)
Thanks for the heads-up David. I've checked my chriswhocodes.com web server logs and around 90 unique IPs per week are still downloading the ARM OpenJFX overlay builds so before this patch is merged I'll take a snapshot of the last working ARM build and keep that available. Kind regards, Chris On Tue, April 18, 2017 21:47, David Hill wrote: > > Here is the change to remove the Lens code. > > > caviots: > There were some minor gradle fixes required to cross build. > > > I removed all of the arm*gradle files except for armv6hf. Arm is not a > supported platform anymore and by reducing to the most likely to be used > (because of the Pi), I can concentrate what few resources I can to > checking that platform still builds. > > Armv6hf builds cleanly. I don't have a working Pi configuration to test > it, and need to figure out building the JDK for ARM before I really can > test it even then. > > We have not been using Lens for JDK 8,9 so this should be safe. > > > https://bugs.openjdk.java.net/browse/JDK-8090969 > webrev: http://cr.openjdk.java.net/~ddhill/8090969 > > > -- > David Hill > Java Embedded Development > > > "A man's feet should be planted in his country, but his eyes should > survey the world." -- George Santayana (1863 - 1952) > > >
