Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Please review the updated version

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
Now we are postponing actual window closing, it happens only after we 
ensure that native window pointer is valid on Swing side.


Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed while we 
use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
< Dispose the peer
if (ownerWindowPtr != 0) {
    //Place window above JavaFX stage
    CWrapper.NSWindow.addChildWindow(
    ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
 as JDK counterpart 
of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be 
included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug 
below is confidential.



I agree with what Kevin pointed out off-line that as in the dialog 
case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: Error on build

[javafx]

Hi,

I possess an AMD 64 bit machine.

My JDK_HOME points to a 64 bit JDK.

MS C++ redistributables reported as installed on my machine (determined 
by control panel -> uninstall a program -> reviewing resulting list of 
installed sw) report both 32 and 64 installations.


MS VS was installed as I reported below.

AFAIK Cygwin is not versioned x86 or 64-bit or if it is (can't actually 
recall) it cannot effect the result of the build. 


Are they any other factors at play I am unaware of?

Cheers.

 
On Sunday, October 8, 2017 6:45 AM, David Bimamisa 
 wrote:

 

Which version of JDK are you using? 64-bit or 32-bit? 
I remember getting these types of errors only if there was a mismatch 
between the JDK and c++ compiler machine type
As noted in  wiki: "the version of the JDK you have set as JDK_HOME 
will determine whether you build 32 or 64 bit binaries"

 
Regards
David
 
2017-10-07 1:09 GMT+02:00 :
This is the result of using *VS 2017 CE- every option selected, 
downloaded and installed*


I would say  there is an external symbol _fltused (float used?) and 
a few other such errors and also the assumption that the builder is 
on a 32 bit machine ?? (see final error).



_fltused
__GSHandlerCheck
__security_check_cookie
powf
__imp_IsProcessorFeaturePresent 
_DllMainCRTStartup

and 

C:/Program Files (x86)/Microsoft Visual Studio 
14.0/VC/LIB\MSVCRT.lib : warning LNK4272: library machine type 'X86' 
conflicts with target machine type 'x64'
C:\cygwin64\home\mdbg\rt\modules\javafx.graphics\build\libs\jsl-decora\win\decora_sse.dll 
: fatal error LNK1120: 7 unresolved externals

:graphics:linkDecoraNativeShadersWin FAILED


MS Studio 2017 CE doesn't ask you if you want a 32 bit or 64 bit 
installation, only WHERE you want it installed.


The user choice of Program Files vs Program FIles x(86 ) might 
constitute a choice of sorts so after failing with the default x86 
place, I uninstalled everything and tried the other only to have it 
fail much sooner. The first fail (x86) actually got through building 
part or most of  .graphics, which gave me false hope. 


That non-question usually means the install itself knows what to do 
or has a preference and in this context especially  - VS 
2017,install- should not lead to x86  vs 64 bit  type problems . 


Also, the instructions on the wiki , outdated I am told, also say 
the default project is sdk. I do not think this is the case. It 
seems mandatory to type "sdk" after gradle to hit the sdk build 
task.


Any help or experiences from anyone is much appreciated. 



Full output:

SSEPhongLighting_POINTPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEPhongLighting_SPOTPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSESepiaTonePeer.obj : error LNK2001: unresolved external symbol 
_fltused

SSEUtils.obj : error LNK2001: unresolved external symbol _fltused
SSELinearConvolvePeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSELinearConvolveShadowPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEPerspectiveTransformPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEPhongLighting_DISTANTPeer.obj : error LNK2001: unresolved 
external symbol _fltused
SSEBrightpassPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEColorAdjustPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEDisplacementMapPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEInvertMaskPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_SRC_INPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_SRC_OUTPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_SRC_OVERPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBoxShadowPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_REDPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_SCREENPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_SOFT_LIGHTPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_SRC_ATOPPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_HARD_LIGHTPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_LIGHTENPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_MULTIPLYPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_OVERLAYPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_DARKENPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_DIFFERENCEPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_EXCLUSIONPeer.obj : error LNK2001: unresolved external 
symbol _fltused
SSEBlend_GREENPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_ADDPeer.obj : error LNK2001: unresolved external symbol 
_fltused
SSEBlend_BLUEPeer.obj : error LNK2001: unresolved external symbol 
_fltused

Re: Gradle test fail; DLLS are missing (Windows 10)

[David Bimamisa]

I'm wondering if it possible to build Webkit on Windows anyway? Just by
build openJDK?
Also, according to [1] JDK 8u152 has been already released.

1. http://jdk.java.net/8/
2. http://openjdk.java.net/projects/jdk8u/

Regards

2017-09-26 22:59 GMT+02:00 Kevin Rushforth :

> I presume you aren't building WebKit? If not, then you will have a
> mismatch between the Java .class files and the native library. Possible
> solutions are:
>
> 1) Build WebKit yourself
>
> 2) Avoid running WebView tests
>
> 3) Wait for 3 weeks until JDK 8u152 is released (at which time the .class
> files and native libraries will be in sync again)
>
> -- Kevin
>
>
> David Bimamisa wrote:
>
>> Now I'm having issues when running unit tests of the webkit module.
>>
>> :web:test
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x69c6f73d,
>> pid=8240, tid=0x337c
>> #
>> # JRE version: Java(TM) SE Runtime Environment (8.0_144-b01) (build
>> 1.8.0_144-b01)
>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.144-b01 mixed mode
>> windows-amd64 compressed oops)
>> # Problematic frame:
>> # V  [jvm.dll+0x14f73d]
>> #
>> # Failed to write core dump. Minidumps are not enabled by default on
>> client
>> versions of Windows
>> #
>> # An error report file with more information is saved as:
>> #
>> C:\Users\~\Documents\projects-shaka-in_process\rt\modules\we
>> b\hs_err_pid8240.log
>> #
>> # If you would like to submit a bug report, please visit:
>> #   http://bugreport.java.com/bugreport/crash.jsp
>> #
>> Exception in thread "JavaFX Application Thread" Unexpected exception
>> thrown.
>> org.gradle.messaging.remote.internal.MessageIOException: Could not write
>> message [EndOfStream] to '/127.0.0.1:64074'.
>> at
>> org.gradle.messaging.remote.internal.inet.SocketConnection.
>> dispatch(SocketConnection.java:115)
>> at
>> org.gradle.messaging.remote.internal.hub.MessageHub$Connecti
>> onDispatch.run(MessageHub.java:279)
>> at
>> org.gradle.internal.concurrent.DefaultExecutorFactory$Stoppa
>> bleExecutorImpl$1.run(DefaultExecutorFactory.java:66)
>> at
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1149)
>> at
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:624)
>> at java.lang.Thread.run(Thread.java:748)
>>
>> And the corresponding report file:
>>
>> #
>> # A fatal error has been detected by the Java Runtime Environment:
>> #
>> #  EXCEPTION_ACCESS_VIOLATION (0xc005) at pc=0x69c6f73d,
>> pid=4728, tid=0x2690
>> #
>> # JRE version: Java(TM) SE Runtime Environment (8.0_144-b01) (build
>> 1.8.0_144-b01)
>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.144-b01 mixed mode
>> windows-amd64 compressed oops)
>> # Problematic frame:
>> # V  [jvm.dll+0x14f73d]
>> #
>> # Failed to write core dump. Minidumps are not enabled by default on
>> client
>> versions of Windows
>> #
>> # If you would like to submit a bug report, please visit:
>> #   http://bugreport.java.com/bugreport/crash.jsp
>> #
>>
>> ---  T H R E A D  ---
>>
>> Current thread (0x1ec34800):  JavaThread "JavaFX Application
>> Thread" [_thread_in_vm, id=9872,
>> stack(0x2180,0x2190)]
>>
>> siginfo: ExceptionCode=0xc005, reading address 0x
>>
>> Registers:
>> RAX=0x, RBX=0x1ec34800, RCX=0x0480,
>> RDX=0x1dd9dd68
>> RSP=0x218fcca0, RBP=0x218fcd98, RSI=0x,
>> RDI=0x1ec349f8
>> R8 =0x, R9 =0x218fcd98, R10=0x1b25bc60,
>> R11=0x0262a970
>> R12=0x1dd9dd68, R13=0x, R14=0x1ec349f8,
>> R15=0x20f915a0
>> RIP=0x69c6f73d, EFLAGS=0x00010246
>>
>> Top of Stack: (sp=0x218fcca0)
>> 0x218fcca0:   218fcc89 00080001
>> 0x218fccb0:    0006c53eff70
>> 0x218fccc0:   36cea0d95ca8 0001
>> 0x218fccd0:   6b322620 69c648fd
>> 0x218fcce0:   1e5bc888 6a126ee0
>> 0x218fccf0:   1ec34800 
>> 0x218fcd00:   0262a6d0 1ec34800
>> 0x218fcd10:   000e 69c64a0b
>> 0x218fcd20:   20f915a0 1ec349f8
>> 0x218fcd30:    
>> 0x218fcd40:    67c2b55c
>> 0x218fcd50:   1ec349f8 685f7ae0
>> 0x218fcd60:   009d5450 1f247978
>> 0x218fcd70:   1ec349f8 67c4ee80
>> 0x218fcd80:   685f7ae0 1ec349f8
>> 0x218fcd90:    1f247978
>>
>> Instructions: (pc=0x69c6f73d)
>> 0x69c6f71d:   00 48 83 7b 08 00 

Re: Error on build

[David Bimamisa]

Which version of JDK are you using? 64-bit or 32-bit?
I remember getting these types of errors only if there was a mismatch
between the JDK and c++ compiler machine type
As noted in  wiki: *"the version of the JDK you have set as JDK_HOME will
determine whether you build 32 or 64 bit binaries"*

Regards
David

2017-10-07 1:09 GMT+02:00 :

> This is the result of using *VS 2017 CE- every option selected, downloaded
> and installed*
>
> I would say  there is an external symbol _fltused (float used?) and a few
> other such errors and also the assumption that the builder is on a 32 bit
> machine ?? (see final error).
>
>
> _fltused
> __GSHandlerCheck
> __security_check_cookie
> powf
> __imp_IsProcessorFeaturePresent
> _DllMainCRTStartup
>
> and
>
> C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/LIB\MSVCRT.lib :
> warning LNK4272: library machine type 'X86' conflicts with target machine
> type 'x64'
> C:\cygwin64\home\mdbg\rt\modules\javafx.graphics\build\libs\jsl-decora\win\decora_sse.dll
> : fatal error LNK1120: 7 unresolved externals
> :graphics:linkDecoraNativeShadersWin FAILED
>
>
> MS Studio 2017 CE doesn't ask you if you want a 32 bit or 64 bit
> installation, only WHERE you want it installed.
>
> The user choice of Program Files vs Program FIles x(86 ) might constitute
> a choice of sorts so after failing with the default x86 place, I
> uninstalled everything and tried the other only to have it fail much
> sooner. The first fail (x86) actually got through building part or most of
> .graphics, which gave me false hope.
>
> That non-question usually means the install itself knows what to do or has
> a preference and in this context especially  - VS 2017,install- should not
> lead to x86  vs 64 bit  type problems .
>
> Also, the instructions on the wiki , outdated I am told, also say the
> default project is sdk. I do not think this is the case. It seems mandatory
> to type "sdk" after gradle to hit the sdk build task.
>
> Any help or experiences from anyone is much appreciated.
>
>
>
> Full output:
>
> SSEPhongLighting_POINTPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEPhongLighting_SPOTPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSESepiaTonePeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEUtils.obj : error LNK2001: unresolved external symbol _fltused
> SSELinearConvolvePeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSELinearConvolveShadowPeer.obj : error LNK2001: unresolved external
> symbol _fltused
> SSEPerspectiveTransformPeer.obj : error LNK2001: unresolved external
> symbol _fltused
> SSEPhongLighting_DISTANTPeer.obj : error LNK2001: unresolved external
> symbol _fltused
> SSEBrightpassPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEColorAdjustPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEDisplacementMapPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEInvertMaskPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_SRC_INPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_SRC_OUTPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_SRC_OVERPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBoxShadowPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_REDPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_SCREENPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_SOFT_LIGHTPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_SRC_ATOPPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_HARD_LIGHTPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_LIGHTENPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_MULTIPLYPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_OVERLAYPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_DARKENPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_DIFFERENCEPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_EXCLUSIONPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_GREENPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_ADDPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_BLUEPeer.obj : error LNK2001: unresolved external symbol _fltused
> SSEBlend_COLOR_BURNPeer.obj : error LNK2001: unresolved external symbol
> _fltused
> SSEBlend_COLOR_DODGEPeer.obj : error LNK2001: unresolved external symbol
> _fltused
>
> SSEPerspectiveTransformPeer.obj : error LNK2001: unresolved external
> symbol __GSHandlerCheck
> SSEBoxShadowPeer.obj : error LNK2001: unresolved external symbol
> __GSHandlerCheck
> SSEDisplacementMapPeer.obj : error LNK2001: unresolved external symbol
> __GSHandlerCheck
> SSELinearConvolvePeer.obj :