Re: CFV: New OpenJFX Committer: Rajath Kamath

[Kevin Rushforth]

Hi Ankit,

If you read my response to your first email, I thought I was clear that 
we don't count test bugs the same as product fixes, but neither are they 
worth 0. Meaning that a few test fixes can certainly count towards 
"making up the difference" as I said.


As for your two other points:

I'm still sure that cosmic changes in Editor file should be awarded as 
0.5 instead of 1.

Saying a patch consist of coding, testing and etc, is just play of words.
All those activities are part of code changes and every body does 
that, nothing special about it.

I don't see them as separate activities.


I understand what you are saying here, and there is no objective 
criteria by which a patch is considered significant...it will always be 
a judgment call. The reason I pointed out analysis and testing is to 
distinguish it, for example, from a hypothetical patch to add a null 
check to avoid an NPE, but without any analysis or testing to make sure 
that it isn't just masking a symptom.


I think that all 7 of the ones I listed can be considered significant 
(even though a couple might be on the bubble). Still, to satisfy your 
point, I will wait for one more product fix before putting forth 
Rajath's nomination again.


For 
patch http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/dc2963c3f7d1 
  , I 
can see 5 contributors.
I don't know the exact contribution from Rajath, it could be as small 
as a comment change or could be the whole patch itself [ In that case 
why do we have 4 other contributors ].
Considering equal efforts by all contributors [ taking the best case 
], Individual contribution = [1/5] --> 0.2.   For Committer status 
round off --> 0.

So that patch is 0 for me, unless actual code changes can be shown.


I'm sorry, but saying that this changeset doesn't count (for anyone 
according to your math) is quite simply a fallacious argument that isn't 
backed up by any precedent in the OpenJDK community.


-- Kevin


ankit srivastav wrote:



I have no idea when/why test bugs started to get counted for committer 
status.
The last time I checked, number of lines of patch matters the most 
irrespective of the significance of the patch [ that was a very 
strange and funny way of judging a patch, must be an idea from a non 
technical person].


If that would be the it;s way too easy to become committer in Javafx 
community.
Looks like Javafx community does't have any proper way to judge patch 
significance or  the rules can be tailored as per the circumstances.



1) 
Two of my DRT Media patches were counted as 0.5  and those were not 
cosmic changes.[ May be now you give me a reason for that ? I also did 
coding, testing and etc for those patches]


I'm still sure that cosmic changes in Editor file should be awarded as 
0.5 instead of 1.

Saying a patch consist of coding, testing and etc, is just play of words.
All those activities are part of code changes and every body does 
that, nothing special about it.

I don't see them as separate activities.

2)
For 
patch http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/dc2963c3f7d1 
  , I 
can see 5 contributors.
I don't know the exact contribution from Rajath, it could be as small 
as a comment change or could be the whole patch itself [ In that case 
why do we have 4 other contributors ].
Considering equal efforts by all contributors [ taking the best case 
], Individual contribution = [1/5] --> 0.2.   For Committer status 
round off --> 0.

So that patch is 0 for me, unless actual code changes can be shown.


Rest of the things look fine to me.

--Ankit













On Wed, Feb 28, 2018 at 10:34 AM, ankit srivastav > wrote:


Dear Kevin,

I will get back to you on this shortly with substantial claims.


--Ankit

On 28 Feb 2018 2:23 a.m., "Kevin Rushforth"
mailto:kevin.rushfo...@oracle.com>>
wrote:

Hi Ankit,

In response to your veto, I took the opportunity to look at
the the list of changes, and believe that my earlier
nomination of Rajath to OpenJFX Project Committer was
justified, if perhaps barely so.

While there is no objective criteria by which one can say a
particular changeset is worth 0.5 of a fix, we do often look
at 2 to 4 trivial fixes or test-only fixes to "make up the
difference" in case only 6 or 7 are deemed "significant". This
is why we usually want 10 or 12 fixes before we nominate
someone for Committer -- to avoid quibbling over whether one
or two are worthy of being counted.

Rather than respond to each of your comments individually
(although I do have one point below), I will instead list the
fixes I consider significant.

In looking at the list of fixes again, I would consider the
following 7 non-test fixes to be significant,

[11] Review request: 8198354: [macOS] Corrupt Thai characters displayed in word wrapped label

[Dipak Kumar]

Hi Phil/Kevin,

Please review the below fix - 

Webrev : http://cr.openjdk.java.net/~mbilla/8198354/webrev.00/ 

JBS : https://bugs.openjdk.java.net/browse/JDK-8198354 

Details about the fix has been updated in JBS.

Thanks,
Dipak