Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-10-04 Thread Kevin Rushforth 
On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth  wrote:

> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao  
> wrote:
> 
>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth  wrote:
>> 
>>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao 
>>>  wrote:
>>> 
 https://bugs.openjdk.java.net/browse/JDK-8225571
 
 To run tests (on the root of the source tree):
 ./gradlew apps
 java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar 
 dragdrop.DragDropWithControls
 java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar 
 dragdrop.DragDropColor
 
 java -Djdk.gtk.version=2 @build/run.args -cp 
 apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls
 java -Djdk.gtk.version=2 @build/run.args -cp 
 apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
 
 
 
 Commits:
  - 3d650b2b: Gtk DND port for Linux
 
 Changes: https://git.openjdk.java.net/jfx/pull/4/files
  Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00
   Issue: https://bugs.openjdk.java.net/browse/JDK-8225571
   Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod
   Patch: https://git.openjdk.java.net/jfx/pull/4.diff
   Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4
>>> 
>>> @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK ID 
>>> so should do this instead:
>>> 
 If you already are an OpenJDK 
 [Author](https://openjdk.java.net/bylaws#author), 
 [Committer](https://openjdk.java.net/bylaws#committer) or 
 [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click 
 [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300=1)
  to open a new issue so that we can record that fact. Please use "Add 
 GitHub user tsayao" as summary for the issue.
>> 
>> Yes, noticed that while reading the comment again. I have opened an issue. 
>> Thanks.
> 
> @pankaj-bansal can you review this as well?

Preliminary review was here: 
[javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490)

PR: https://git.openjdk.java.net/jfx/pull/4

Re: RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-04 Thread Kevin Rushforth 
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir  wrote:

> Allright, this is a fix for JDK-8207957
> 
> 
> 
> Commits:
>  - 969ebb51: Fixing TableColumnHeaderTest
>  - 9d379619: Removing Tablecolumnbasehelper
>  - 4fe020fc: Fix javadoc for TableColumnHeader
>  - c422c80f: Minor modification and uni test added.
>  - b2bdfb5b: Change resizeColumn to protected without static in order to be 
> able to override
>  - 3b9b7903: Second option for resizeColumnToFitContent in TableColumnHeader
>  - d91c56e5: First attempt to extract resizeColumnToFitContent
> 
> Changes: https://git.openjdk.java.net/jfx/pull/6/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/6/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
>   Stats: 523 lines in 4 files changed: 330 ins; 187 del; 6 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/6.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6

JBS bug: [JDK-8207957](https://bugs.openjdk.java.net/browse/JDK-8207957)

Review comments from preliminary review: 
[javafxports/openjdk-jfx/pull/289](https://github.com/javafxports/openjdk-jfx/pull/289)

PR: https://git.openjdk.java.net/jfx/pull/6

RE: Custom Fonts in User Agent Stylesheets

2019-10-04 Thread David Grieve 
This seems like a bug. Certainly overriding Region#getUserAgentStylesheet() is 
the preferred way of customizing styles for a control.  Maybe the styles from 
the Region UA stylesheet aren’t being considered when doing a font lookup. That 
would for sure be a bug.

But there are a lot of moving parts.

Are there other stylesheets that might take precedence? Are there other styles 
in the custom stylesheet that are/are not working? Do you have a short example 
that reproduces the issue?

Sent from Mail for Windows 10


From: openjfx-dev  on behalf of Dirk 
Lemmermann 
Sent: Friday, October 4, 2019 5:59:17 AM
To: openjfx-dev@openjdk.java.net Mailing 
Subject: Custom Fonts in User Agent Stylesheets

I noticed today that the custom fonts I defined in a user agent stylesheet of a 
custom control are not being used. It only started working when I “manually” 
added the stylesheet to the control via getStylesheets().add() instead of 
overriding getUserAgentStylesheet().

Does anyone know if this is intentional or a bug? Are there certain things that 
JavaFX does not support depending on the “type” of stylesheet?

Dirk

Re: [Integrated] RFR: 8231854: Change Mercurial to git in various README files

2019-10-04 Thread duke 
Changeset: c6eb0918
Author:Kevin Rushforth 
Date:  2019-10-04 12:59:35 +
URL:   https://git.openjdk.java.net/jfx/commit/c6eb0918

8231854: Change Mercurial to git in various README files

Reviewed-by: ghb

! apps/samples/Ensemble8/UPDATING-lucene.txt
! modules/javafx.media/src/main/legal/glib.md
! modules/javafx.media/src/main/legal/gstreamer.md
! modules/javafx.web/src/main/legal/webkit.md

Re: [Approved] RFR: 8231854: Change Mercurial to git in various README files

2019-10-04 Thread Guru Hb 
On Thu, 3 Oct 2019 23:15:56 GMT, Kevin Rushforth  wrote:

> https://bugs.openjdk.java.net/browse/JDK-8231854
> 
> Follow-on fix to 
> [JDK-8231590](https://bugs.openjdk.java.net/browse/JDK-8231590) -- PR #3 -- 
> to change Mercurial or hg to git in a few README files where appropriate.
> 
> 
> 
> Commits:
>  - bb9544ac: 8231854: Change Mercurial to git in various README files
> 
> Changes: https://git.openjdk.java.net/jfx/pull/7/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/7/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8231854
>   Stats: 7 lines in 4 files changed: 0 ins; 0 del; 7 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/7.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/7/head:pull/7

Approved by ghb (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/7

Re: RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-04 Thread Kevin Rushforth 
There is no longer a need to manually send RFR emails. Once your OCA 
status has been re-confirmed and entered into the Skara configuration, 
which is a one-time step, the Skara bot will send the RFR. Until then, 
we cannot review it.


Thank you for your patience.

-- Kevin


On 10/4/2019 1:43 AM, Dell Green wrote:


Please review the fix for Updated armv6hf crosslibs script with new
domains:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8231870
https://github.com/openjdk/jfx/pull/8

Custom Fonts in User Agent Stylesheets

2019-10-04 Thread Dirk Lemmermann 
I noticed today that the custom fonts I defined in a user agent stylesheet of a 
custom control are not being used. It only started working when I “manually” 
added the stylesheet to the control via getStylesheets().add() instead of 
overriding getUserAgentStylesheet(). 

Does anyone know if this is intentional or a bug? Are there certain things that 
JavaFX does not support depending on the “type” of stylesheet?

Dirk

Subject: RFR: 8087980: Add property to disable Monocle cursor

2019-10-04 Thread Dell Green 
Please review the fix for Add property to disable Monocle cursor:
https://bugs.openjdk.java.net/browse/JDK-8087980
https://github.com/openjdk/jfx/pull/5

RFR: 8231870: Updated armv6hf crosslibs script with new domains

2019-10-04 Thread Dell Green 


Please review the fix for Updated armv6hf crosslibs script with new
domains:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8231870
https://github.com/openjdk/jfx/pull/8

RFR: 8207957: TableSkinUtils should not contain actual code implementation

2019-10-04 Thread Hadzic Samir 
Allright, this is a fix for JDK-8207957



Commits:
 - 969ebb51: Fixing TableColumnHeaderTest
 - 9d379619: Removing Tablecolumnbasehelper
 - 4fe020fc: Fix javadoc for TableColumnHeader
 - c422c80f: Minor modification and uni test added.
 - b2bdfb5b: Change resizeColumn to protected without static in order to be 
able to override
 - 3b9b7903: Second option for resizeColumnToFitContent in TableColumnHeader
 - d91c56e5: First attempt to extract resizeColumnToFitContent

Changes: https://git.openjdk.java.net/jfx/pull/6/files
 Webrev: https://webrevs.openjdk.java.net/jfx/6/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8207957
  Stats: 523 lines in 4 files changed: 330 ins; 187 del; 6 mod
  Patch: https://git.openjdk.java.net/jfx/pull/6.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6

PR: https://git.openjdk.java.net/jfx/pull/6