Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v3]
> As noted in the corresponding JBS issue, `Axis` does not properly compute its > preferred height when `autoRanging` is turned off. The simplest fix seems to > be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees > if there is not enough room for the category labels to layout horizontally. > This fixes the fact that the axis labels are truncated and also ensures that > the chart does not leave unused space from the layout calculations. > `CategoryAxis` is already setting the `categorySpacing` property when > `autoRanging` is off, so this seems to be an appropriate fix. Jonathan Vusich has updated the pull request incrementally with one additional commit since the last revision: Unrotate labels if there is enough space for them - Changes: - all: https://git.openjdk.java.net/jfx/pull/342/files - new: https://git.openjdk.java.net/jfx/pull/342/files/49a5e1f7..6d83f79c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=342=02 - incr: https://webrevs.openjdk.java.net/?repo=jfx=342=01-02 Stats: 19 lines in 2 files changed: 14 ins; 2 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/342.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/342/head:pull/342 PR: https://git.openjdk.java.net/jfx/pull/342
Re: Request to backport to JavaFX 11 (11.0.10)
Kevin is out until Monday, but you can have a thumbs up from me if that counts. -phil. On 11/25/20, 8:54 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issues to JavaFX 11 (for JavaFX 11.0.10) JDK-8177945: Single cell selection flickers when adding data to TableView JDK-8199592: Control labels truncated at certain DPI scaling levels Both patches apply clean. - Johan
Request to backport to JavaFX 11 (11.0.10)
Hi Kevin, I request permission to backport the following issues to JavaFX 11 (for JavaFX 11.0.10) JDK-8177945: Single cell selection flickers when adding data to TableView JDK-8199592: Control labels truncated at certain DPI scaling levels Both patches apply clean. - Johan
Re: RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v2]
On Tue, 24 Nov 2020 22:21:04 GMT, Kevin Rushforth wrote: >> Can you merge in the latest `jfx/master`? That way the GitHub actions >> build/test will be run (although it won't run the new headful test). You >> also need a copyright header as noted below. > > While this does fix the specific problem, it introduces a new one. If the > labels are initially too big, but after resizing the window would now fit, it > does not recompute the orientation. This means that you are left with labels > that are rotated even when they don't need to be. @kevinrushforth Thank you for catching that. Do you think it would be acceptable to simply rotate the labels back to zero if the user expands the window? - PR: https://git.openjdk.java.net/jfx/pull/342
Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24 [v3]
On Wed, 25 Nov 2020 07:09:09 GMT, Arun Joseph wrote:
>> We should use the public_suffix_list.dat file in the JDK instead. Reading
>> the public_suffix_list.dat file is modified to be similar to
>> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java).
>> If the file is not present, `isPublicSuffix()` returns `false`, which is
>> similar to how WebKit ignores the public suffix check when it is disabled.
>>
>> Test: Run PublicSuffixesTest.java
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Create pslFile variable
modules/javafx.web/src/main/java/com/sun/webkit/network/PublicSuffixes.java
line 76:
> 74: */
> 75: private static final File pslFile = new File(
> 76: System.getProperty("java.home"),
> "lib/security/public_suffix_list.dat");
I think this needs to be in a doPrivileged block. The rest looks good.
-
PR: https://git.openjdk.java.net/jfx/pull/324
