Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners
On Mon, 22 Feb 2021 14:58:45 GMT, Jeanette Winzenburg
wrote:
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from the change listener un/register methods
> - added tests to verify that the new (and old) api is indeed delegating to
> the handler
>
> Note that the null handling is slightly extended: all methods now can handle
> both null consumers (as before) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Not yet reviewed. All of the new API methods need to have an `@since 17`
javadoc tag.
modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
250:
> 248: * @param observable the observable to observe for invalidation
> events
> 249: * @param consumer the consumer
> 250: */
Add `@since 17` javadoc tag.
modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
269:
> 267: * {@link #registerInvalidationListener(Observable, Consumer)}.
> If no consumers have been registered on this
> 268: * property, null will be returned.
> 269: * @since 9
Need to change `9` to `17`.
modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
285:
> 283: * @param observableList the observable list to observe for list
> change events
> 284: * @param consumer the consumer
> 285: */
Add `@since 17` javadoc tag.
modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line
305:
> 303: * {@link #registerListChangeListener(ObservableList,
> Consumer)}. If no consumers have been registered on this
> 304: * list, null will be returned.
> 305: * @since 9
Need to change `9` to `17`.
-
PR: https://git.openjdk.java.net/jfx/pull/409
Bulk request to backport 12 fixes to 11-dev for 11.0.11
Hi Johan, I request approval to backport the following 12 bug fixes to 11-dev for FX 11.0.11: JDK-8254049: Update WebView to public suffix list 2020-04-24 JDK-8259635: Update to 610.2 version of WebKit JDK-8260163: IrresponsiveScriptTest.testInfiniteLoopInScript unit test fails on Windows JDK-8254836: Cherry pick GTK WebKit 2.30.3 changes JDK-8261927: WebKit build fails with Visual Studio 2017 JDK-8202990: javafx webview css filter property with display scaling JDK-8242861: Update ImagePattern to apply SVG pattern transforms JDK-8233678: [macos 10.15] System menu bar does not work initially on macOS Catalina JDK-8257897: Fix webkit build for XCode 12 JDK-8253356: JavaFX Terminology Refresh JDK-8242361: JavaFX Web View crashes with Segmentation Fault, when HTML contains Data-URIs JDK-8213135: HTMLEditorTest.checkStyleProperty fails intermittently Thanks. -- Kevin
Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v13]
> This is a new approach to rewrite parts of gtk glass backend to be more clean. > > I will provide small "manageable" PR to incrementally make the backend better. > > This PR adresses cleanup of the Size and Positioning code. It makes code more > "straightforward" and easier to maintain. > > Current status (Ubuntu 20.04): >  > > (*) Some of the iconify tests are also failing on the main branch. > > `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2 > failures. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Default to 320x200 if no size is assigned - Changes: - all: https://git.openjdk.java.net/jfx/pull/367/files - new: https://git.openjdk.java.net/jfx/pull/367/files/6766502e..0c89a4da Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=367=12 - incr: https://webrevs.openjdk.java.net/?repo=jfx=367=11-12 Stats: 11 lines in 2 files changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/367.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/367/head:pull/367 PR: https://git.openjdk.java.net/jfx/pull/367
Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events
On Wed, 17 Feb 2021 14:14:35 GMT, Arun Joseph wrote: > Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Looks good to me. Verified on Ubuntu 20.04 - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/404
RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners
Changes in Lambda..Handler: - added api and implemenation to support invalidation and listChange listeners in the same way as changeListeners - added java doc - added tests Changes in SkinBase - added api (and implementation delegating to the handler) - copied java doc from the change listener un/register methods - added tests to verify that the new (and old) api is indeed delegating to the handler Note that the null handling is slightly extended: all methods now can handle both null consumers (as before) and null observables (new) - this allows simplified code on rewiring "path" properties (see reference example in the issue) - Commit messages: - 8258777: SkinBase: add api to un-/register invalidation-/listChange Changes: https://git.openjdk.java.net/jfx/pull/409/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=409=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258777 Stats: 970 lines in 6 files changed: 946 ins; 9 del; 15 mod Patch: https://git.openjdk.java.net/jfx/pull/409.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/409/head:pull/409 PR: https://git.openjdk.java.net/jfx/pull/409
