@font-face question
Hi,
I want to have one font that is "regular" and a variation of the same font
as "bold", used when specified "-fx-font-weight: bold".
@font-face {
font-family: 'Gotham Condensed';
src: url('../fonts/GothamCondensed-Book.otf');
}
@font-face {
font-family: 'Gotham Condensed Bold';
src: url('../fonts/GothamCondensed-Bold.otf');
}
.text {
-fx-font-family: 'Gotham Condensed';
}
I have searched online and there are many variations such as:
- @font-face "font-family" is ignored and you have to use the real font
name;
- If you use 'Bold' as a suffix, javafx will use it as bold;
- you have to specify "font-weight: bold" on the @font-face
The last one is what seems that the CSS specs says, but does not seem to
work.
Is it possible?
Thanks.
Re: RFR: 8286261: Selection of non-expanded non-leaf treeItem grows unexpectedly when adding two-level descendants
On Fri, 6 May 2022 10:16:41 GMT, Jose Pereda wrote: > This PR extends the check if a treeItem is expanded to all its ancestors, as > in case one ancestor is collapsed, all its children will be hidden. > > 4 tests are included, two for TreeView and two for TreeTableView. This looks good to me. - Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/791
Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v2]
On Thu, 19 May 2022 22:01:31 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Platform.exit() , removing code block, as it is causing other test fail
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/EventListenerLeakTest.java
> line 637:
>
>> 635: });
>> 636:
>> 637: assertEquals("Click count", 1,
>> listeners1.get(0).getClickCount());
>
> You should add a comment that this check is testing that the immediately
> previous click does _not_ get delivered since the associated DOM node is not
> part of the page any more. This is why the count remains at 1 (from the first
> click on the original page).
>
>
> Also, I think it would be useful here to clear the references to the
> listeners and WebView and make sure that the listener attached to the
> previously loaded page for this WebView gets released. Something like this as
> the final statements of the method:
>
>
> // Clear strong reference to listener and WebView
> listeners1.clear();
> webView1 = null;
>
> // Verify that there is no strong reference to the WebView
> assertNumActive("WebView", webViewRefs, 0);
>
> // Verify that no listeners are strongly held
> assertNumActive("MyListener", listenerRefs, 0);
You will also need to clear the references to the DOM nodes, and set `webView2
= null;` for this to work.
-
PR: https://git.openjdk.java.net/jfx/pull/799
Integrated: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. This pull request has now been integrated. Changeset: 18b2366f Author:Robert Lichtenberger Committer: Ajit Ghaisas URL: https://git.openjdk.java.net/jfx/commit/18b2366f3d0520479f0d9c4af48acf9495d15a72 Stats: 180 lines in 2 files changed: 176 ins; 1 del; 3 mod 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Reviewed-by: mhanl, aghaisas - PR: https://git.openjdk.java.net/jfx/pull/779
Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >> order. >> >> The fix also works for: >> https://bugs.openjdk.java.net/browse/JDK-8269429 >> >> But this one might need another fix: >> https://bugs.openjdk.java.net/browse/JDK-8240640 > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Revert "Set the focus on the latest window when re-enabling them" > > This reverts commit b024de586c187f9000f791dab99507a4979cc027. Marked as reviewed by arapte (Reviewer). The fix look good to me. The other behavior is observed on mac but not on windows. The platform behavior itself looks different. Not sure if should be captured in a JBS (at least for documentation purpose) - PR: https://git.openjdk.java.net/jfx/pull/784
