[9, 8u-dev] Request for review: JDK-8090062 Update java-wrappers for WebKit generated classes following WebKit update

2015-07-29 Thread Anton V. Tarasov

Hi Kevin,

Please, review the fix:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090062
webrev: http://cr.openjdk.java.net/~ant/JDK-8090062/webrev.0

Thanks,
Anton.


[9, 8u-dev] Request for review: JDK-8130740 WebView does not render woff fonts

2015-07-20 Thread Anton V. Tarasov

Hi Kevin,

Please review the fix:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8130740
webrev: http://cr.openjdk.java.net/~ant/JDK-8130740/webrev.0

Thanks,
Anton.


Re: JavaFx: webview print with scale 100%

2015-07-13 Thread Anton V. Tarasov

Hi Alexander,

On 27.06.2015 8:30, Александр Свиридов wrote:

Hi Anton,

I send all files. If you open index.html in IE and printpreview-set scale 100% - print , you 
will get 16.8 cm of div on paper.


If you you print via application I did you will get quite different size.


WebView is a WebKit-based browser, IE is not. It doesn't mean they should behave differently, but 
they can. So, if you want to test WebView, you're better to compare it with the WebKit family 
browsers. Safari or Chrome (based on Blink, a WebKit fork) at least. In most cases WebView should 
behave the same, if it doesn't - this may be a sign of a bug (or it may be a problem of the WebKit 
codebase, WebView is based on currently).


In case of the test you've provided, Chrome behaves the same. I investigated it a little and found 
out that the reason of that the printed content differs in size from the content you see on screen 
is this style defined in the html file:


style
body{
!-- ... ---
min-width: 1000px;
}
/style

For printers and high resolution screens 1px implies multiple device pixels. 
as can be found here:

http://www.w3schools.com/cssref/css_units.asp

I don't know why IE and Chrome produce different results on the same printer, but WebView behaves 
like Chrome in this case. So, I don't see a bug in WebView.


Regards,
Anton.




Пятница, 19 июня 2015, 17:03 +03:00 от Anton V. Tarasov 
anton.tara...@oracle.com:

Hi Alexander,

Could you please create and send a simple test case (fully functioning) 
with the exact URL of
a page
you're printing?

Regards,
Anotn.

On 15.06.2015 8:53, Александр Свиридов wrote:
 To print my html page I use the following code:
 PrinterJob job =PrinterJob.createPrinterJob();if(job !=null 
job.showPrintDialog(null)){
 webView.getEngine().print(job);
 job.endJob();}
 The problem is that webview changes the scale of printing page. For 
example, when I print
this html page in IE with fit to size 100% I get 16.8 cm. When I print in 
my java application
I get 11.4cm. The size in html file I set in pt - my width is 475pt(A4 
width=595pt,so
475pt=16.8cm). How to print with webview and to have 100% width and height?






[9] Request for review: JDK-8090098 [WebView] getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-13 Thread Anton V. Tarasov

Hi Kevin,

Please review the fix suggested by Steve Hruda:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090098
webrev: http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.1

Thanks,
Anton.


Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-10 Thread Anton V. Tarasov

Steve,

Please find my update here:

https://bugs.openjdk.java.net/browse/JDK-8090098

Regards,
Anton.

On 10.07.2015 18:21, Hruda, Steve wrote:

I saw it on the mailing list and I'll give it a try next week.




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, 
Austria, Tel. +43 (1) 9610567-0
The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.


-Original Message-
From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Friday, July 10, 2015 6:19 PM
To: Hruda, Steve
Cc: openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

Thank you, I did =)

Btw, now you can build and explore your fixes as well with the webview deps 
released.

Regards,
Anton.

On 10.07.2015 19:16, Hruda, Steve wrote:

Hi Anton,
Welcome back! I hope you enjoyed your vacation.

Thanks for the update ;-)

Regards,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber Sitz der
Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43
(1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN
116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401,
Steuer-Nummer: 264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber Registered office and
Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel.
+43 (1) 9610567-0 The company is recorded at the commercial court of
Vienna under the company register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.


-Original Message-
From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Friday, July 10, 2015 6:11 PM
To: Hruda, Steve
Cc: openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview -
getTimezoneOffset() of a ISO strings returns a wrong value

Hi Steve,

I was on a short vacation. The testing is in progress yet. I'll update the 
issue when it's done.

Regards,
Anton.

On 08.07.2015 14:57, Hruda, Steve wrote:

Hi Anton,
The issue was last updated on Thursday. Have you found any additional 
LayoutTest issues? Or does everything work?

Regards,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber Sitz der
Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien

Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-10 Thread Anton V. Tarasov

Hi Steve,

I was on a short vacation. The testing is in progress yet. I'll update the 
issue when it's done.

Regards,
Anton.

On 08.07.2015 14:57, Hruda, Steve wrote:

Hi Anton,
The issue was last updated on Thursday. Have you found any additional 
LayoutTest issues? Or does everything work?

Regards,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, 
Austria, Tel. +43 (1) 9610567-0
The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.


-Original Message-
From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of 
Hruda, Steve
Sent: Thursday, July 2, 2015 4:46 PM
To: Anton V. Tarasov
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

Very cool! Thanks for your efforts!

From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Thursday, July 2, 2015 4:44 PM
To: Hruda, Steve
Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

The test passes with this only change. And the original bug is not reproducible.

Ok, I'll need to test it with other date LayoutTests again. Will update in JIRA.

Regards,
Anton.

On 02.07.2015 15:31, Hruda, Steve wrote:
Yes! ;-)

From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Thursday, July 2, 2015 3:26 PM
To: Hruda, Steve
Cc: Kevin Rushforth; 
openjfx-dev@openjdk.java.netmailto:openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

Ok, got it. You suggest trying the only 2-line change?

Anton.

On 02.07.2015 15:54, Hruda, Steve wrote:
HI Anton,
The diff fix must be there.


if (diff0)

diff += secondsPerDay;


… but the following fixes are unnecessary, for the midnight bug. I think one of 
these fixes could be the problem.
http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/http://cr.openjdk.java.net/%7Eant/JDK-8090098/webrev.0/

which contains the following fixed issues:
http://trac.webkit.org/changeset/174377
http://trac.webkit.org/changeset/175078
http://trac.webkit.org/changeset/181360

Regards,
Steve


From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Thursday, July 2, 2015 2:50 PM
To: Hruda, Steve
Cc: Kevin Rushforth; 
openjfx-dev@openjdk.java.netmailto:openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

Hi Steve,

Actually, I already checked that removing

if (diff0)

diff += secondsPerDay;

didn't help.

Regards,
Anton.

On 02.07.2015 13:09, Hruda, Steve wrote:
Hi Anton,
I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098.

We’ve opened the test page which you have mentioned in our own compiled WebKit version 
- clean build  latest version.

Used Timezone: Vienna CEST – current Offset UTC+2:00

Without our Fix:
Only the first and latest test pass.

With our Fix:
The same – only the first and latest test pass.

It seems that one changeset regress this behavior, but not  the our latest “if 
–fix”


if (diff0)

diff += secondsPerDay;

I’m not able to build openjfx because of the missing dependencies (1.3). Please 
can you try what happens if you only apply the diff fix and not the previous 
patch, which includes all other date

webview-deps 1.3 released!

2015-07-10 Thread Anton V. Tarasov

Hi all,

I'm pleased to announce that webview-deps 1.3 are eventually released to Maven 
Central!

http://repo1.maven.org/maven2/com/sun/webkit/webview-deps/1.3/

Enjoy building WebView! =)

http://hg.openjdk.java.net/openjfx/8u-dev/rt
http://hg.openjdk.java.net/openjfx/9-dev/rt

Regards,
Anton.



Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-02 Thread Anton V. Tarasov

Ok, got it. You suggest trying the only 2-line change?

Anton.

On 02.07.2015 15:54, Hruda, Steve wrote:


HI Anton,

The diff fix must be there.

if (diff0)
diff += secondsPerDay;

… but the following fixes are unnecessary, for the midnight bug. I think one of these fixes could 
be the problem.


http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/ 
http://cr.openjdk.java.net/%7Eant/JDK-8090098/webrev.0/


which contains the following fixed issues:

http://trac.webkit.org/changeset/174377
http://trac.webkit.org/changeset/175078
http://trac.webkit.org/changeset/181360

Regards,

Steve

*From:*Anton V. Tarasov [mailto:anton.tara...@oracle.com]
*Sent:* Thursday, July 2, 2015 2:50 PM
*To:* Hruda, Steve
*Cc:* Kevin Rushforth; openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings 
returns a wrong value


Hi Steve,

Actually, I already checked that removing

if (diff0)
diff += secondsPerDay;


didn't help.

Regards,
Anton.

On 02.07.2015 13:09, Hruda, Steve wrote:

Hi Anton,

I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098.

We’ve opened the test page which you have mentioned in our own compiled WebKit 
version -
clean build  latest version.

Used Timezone: Vienna CEST – current Offset UTC+2:00

Without our Fix:

Only the first and latest test pass.

With our Fix:

The same – only the first and latest test pass.

It seems that one changeset regress this behavior, but not  the our latest 
“if –fix”

if (diff0)

diff += secondsPerDay;

I’m not able to build openjfx because of the missing dependencies (1.3). 
Please can you try
what happens if you only apply the diff fix and not the previous patch, 
which includes all
other date fixes.  From my point of view are these fixes (which were 
provided by the patch
file) not necessary to solve our datepicker problem.

Thanks in advance,

Steve

*From:*Kevin Rushforth [mailto:kevin.rushfo...@oracle.com]
*Sent:* Tuesday, June 30, 2015 11:17 PM
*To:* Hruda, Steve
*Cc:* Anton V. Tarasov; openjfx-dev@openjdk.java.net 
mailto:openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - 
getTimezoneOffset() of a ISO
strings returns a wrong value

Not by itself, although regressions are certainly taken very seriously.

In any case, the process is to get this into 9-dev (once it has been 
reviewed), test it
thoroughly, and then consider whether we can make a case for taking it to 
the 8u60 release team.

-- Kevin


Hruda, Steve wrote:

Is a regression not release critical?

  

  

  

  


Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph 
Ges.m.b.H.

Vertretungsberechtigte Geschäftsführer: Maximilian Weber

Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, 
Tel. +43 (1) 9610567-0

Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b

Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, 
Steuer-Nummer: 264/4807

  


This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.

Authorised Managing Directors: Maximilian Weber

Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 
1050 Wien, Austria, Tel. +43 (1) 9610567-0

The company is recorded at the commercial court of Vienna under the 
company register number FN 116859 b

VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

  


Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise 
Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein 
Geschäftsgeheimnis darstellen. Falls Sie diese Nachricht irrtümlicherweise 
erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort 
senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche 
aufgeführten Ansichten oder Meinungen sind ausschließlich diejenigen des Autors 
und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

  


This E-Mail (and any attachments) may be confidential and protected by 
legal privilege. If you are not the intended recipient please notify us 
immediately by replying to the sender and delete this E-Mail and your reply 
from your system. All the views and opinions published here are solely based on 
the author's own opinion and should not be considered necessarily as reflecting 
the opinion of Intergraph.

  

  



Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph 
Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. 
+43 (1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID

Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-02 Thread Anton V. Tarasov

Hi Steve,

Actually, I already checked that removing

if (diff0)

   diff += secondsPerDay;


didn't help.

Regards,
Anton.

On 02.07.2015 13:09, Hruda, Steve wrote:


Hi Anton,

I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098.

We’ve opened the test page which you have mentioned in our own compiled WebKit version - clean 
build  latest version.


Used Timezone: Vienna CEST – current Offset UTC+2:00

Without our Fix:

Only the first and latest test pass.

With our Fix:

The same – only the first and latest test pass.

It seems that one changeset regress this behavior, but not  the our latest “if 
–fix”

if (diff0)
diff += secondsPerDay;

I’m not able to build openjfx because of the missing dependencies (1.3). Please can you try what 
happens if you only apply the diff fix and not the previous patch, which includes all other date 
fixes.  From my point of view are these fixes (which were provided by the patch file) not 
necessary to solve our datepicker problem.


Thanks in advance,

Steve

*From:*Kevin Rushforth [mailto:kevin.rushfo...@oracle.com]
*Sent:* Tuesday, June 30, 2015 11:17 PM
*To:* Hruda, Steve
*Cc:* Anton V. Tarasov; openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings 
returns a wrong value


Not by itself, although regressions are certainly taken very seriously.

In any case, the process is to get this into 9-dev (once it has been reviewed), test it 
thoroughly, and then consider whether we can make a case for taking it to the 8u60 release team.


-- Kevin


Hruda, Steve wrote:

Is a regression not release critical?

  

  

  

  


Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph 
Ges.m.b.H.

Vertretungsberechtigte Geschäftsführer: Maximilian Weber

Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. 
+43 (1) 9610567-0

Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b

Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

  


This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.

Authorised Managing Directors: Maximilian Weber

Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 
Wien, Austria, Tel. +43 (1) 9610567-0

The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b

VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

  


Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise 
Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein 
Geschäftsgeheimnis darstellen. Falls Sie diese Nachricht irrtümlicherweise 
erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort 
senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche 
aufgeführten Ansichten oder Meinungen sind ausschließlich diejenigen des Autors 
und entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

  


This E-Mail (and any attachments) may be confidential and protected by 
legal privilege. If you are not the intended recipient please notify us 
immediately by replying to the sender and delete this E-Mail and your reply 
from your system. All the views and opinions published here are solely based on 
the author's own opinion and should not be considered necessarily as reflecting 
the opinion of Intergraph.

  

  



Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 
(1) 9610567-0
The company is recorded at the commercial court of Vienna under the company register number FN 
116859 b

VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, die vertraulich sind, 
dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis darstellen. Falls Sie diese Nachricht 
irrtümlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort 
senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und entsprechen nicht 
notwendigerweise denen des Unternehmens Intergraph.


This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you are 
not the intended recipient please notify us immediately by replying to the sender and delete

Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-07-02 Thread Anton V. Tarasov

The test passes with this only change. And the original bug is not reproducible.

Ok, I'll need to test it with other date LayoutTests again. Will update in JIRA.

Regards,
Anton.

On 02.07.2015 15:31, Hruda, Steve wrote:


Yes! ;-)

*From:*Anton V. Tarasov [mailto:anton.tara...@oracle.com]
*Sent:* Thursday, July 2, 2015 3:26 PM
*To:* Hruda, Steve
*Cc:* Kevin Rushforth; openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings 
returns a wrong value


Ok, got it. You suggest trying the only 2-line change?

Anton.

On 02.07.2015 15:54, Hruda, Steve wrote:

HI Anton,

The diff fix must be there.

if (diff0)

diff += secondsPerDay;

… but the following fixes are unnecessary, for the midnight bug. I think 
one of these fixes
could be the problem.

http://cr.openjdk.java.net/~ant/JDK-8090098/webrev.0/
http://cr.openjdk.java.net/%7Eant/JDK-8090098/webrev.0/

which contains the following fixed issues:

http://trac.webkit.org/changeset/174377
http://trac.webkit.org/changeset/175078
http://trac.webkit.org/changeset/181360

Regards,

Steve

*From:*Anton V. Tarasov [mailto:anton.tara...@oracle.com]
*Sent:* Thursday, July 2, 2015 2:50 PM
*To:* Hruda, Steve
*Cc:* Kevin Rushforth; openjfx-dev@openjdk.java.net 
mailto:openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - 
getTimezoneOffset() of a ISO
strings returns a wrong value

Hi Steve,

Actually, I already checked that removing

if (diff0)

diff += secondsPerDay;


didn't help.

Regards,
Anton.

On 02.07.2015 13:09, Hruda, Steve wrote:

Hi Anton,

I saw your comments on https://bugs.openjdk.java.net/browse/JDK-8090098.

We’ve opened the test page which you have mentioned in our own compiled 
WebKit version -
clean build  latest version.

Used Timezone: Vienna CEST – current Offset UTC+2:00

Without our Fix:

Only the first and latest test pass.

With our Fix:

The same – only the first and latest test pass.

It seems that one changeset regress this behavior, but not  the our 
latest “if –fix”

if (diff0)

diff += secondsPerDay;

I’m not able to build openjfx because of the missing dependencies 
(1.3). Please can you
try what happens if you only apply the diff fix and not the previous 
patch, which includes
all other date fixes.  From my point of view are these fixes (which 
were provided by the
patch file) not necessary to solve our datepicker problem.

Thanks in advance,

Steve

*From:*Kevin Rushforth [mailto:kevin.rushfo...@oracle.com]
*Sent:* Tuesday, June 30, 2015 11:17 PM
*To:* Hruda, Steve
*Cc:* Anton V. Tarasov; openjfx-dev@openjdk.java.net 
mailto:openjfx-dev@openjdk.java.net
*Subject:* Re: Patch for JDK-8090098 - [regression] Webview - 
getTimezoneOffset() of a ISO
strings returns a wrong value

Not by itself, although regressions are certainly taken very seriously.

In any case, the process is to get this into 9-dev (once it has been 
reviewed), test it
thoroughly, and then consider whether we can make a case for taking it 
to the 8u60 release
team.

-- Kevin


Hruda, Steve wrote:

Is a regression not release critical?

  

  

  

  


Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph 
Ges.m.b.H.

Vertretungsberechtigte Geschäftsführer: Maximilian Weber

Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, 
Österreich, Tel. +43 (1) 9610567-0

Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b

Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, 
Steuer-Nummer: 264/4807

  


This E-Mail has been sent on behalf of the company Intergraph 
Ges.m.b.H.

Authorised Managing Directors: Maximilian Weber

Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 
1050 Wien, Austria, Tel. +43 (1) 9610567-0

The company is recorded at the commercial court of Vienna under the 
company register number FN 116859 b

VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

  


Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise 
Informationen, die vertraulich sind, dem Urheberrecht unterliegen oder ein 
Geschäftsgeheimnis darstellen. Falls Sie diese Nachricht irrtümlicherweise 
erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort 
senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche 
aufgeführten Ansichten oder Meinungen sind ausschließlich diejenigen des Autors 
und entsprechen nicht

Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-06-30 Thread Anton V. Tarasov

On 30.06.2015 21:13, Hruda, Steve wrote:

Hi Anton,
thanks for the detailed information and the good news.

You talk about JDK's jira? Am I right? . I don't have an access for that 
JIRA system since the JavaFX's Jira has moved to the JDK Bug System.


Ah, ok. Then I'll quote your e-mail.



About the Apple stuff.
I know that Apple dropped Windows Safari support and in my opinion is this a 
very bad situation for WebKit (in case of Windows) and especially since 
Google and Opera using Google's Blink engine.

In case of the JDK it would be more practicable to switch from WebKit to Blink, 
because this engine is still used by Companies which have Windows end-users.

There is a high probability that WebKit get more such bugs if there is no big 
player like Google or Apple who has the man power to fix such OS dependent 
issues.


I see. However, switching to Blink is another story. Honestly, we're not planning it in the nearest 
future. This requires extra resources which we don't have at the moment...




Last questions:
Do you need any additional information from my side? And is it possible to 
integrate this fix in 8u60?


From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes well, we can consider 
commiting this to 8u60.


@Kevin, do you think we can?

Also, as an option for you (Steve). You can post the changes to the WebKit alias and ask if they 
think this is a valid fix for the issue. Any confirmation from the WebKit team would help us to make 
sure the fix is reliable.


Thanks!
Anton.



Thanks in advance!
Best Regards,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, 
Austria, Tel. +43 (1) 9610567-0
The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.


-Original Message-
From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Tuesday, June 30, 2015 8:01 PM
To: Hruda, Steve; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

Steve,

I applied your suggestion and it worked on Windows.

The missed check you discovered could really be a mistake in WebKit, because 
Apple dropped releasing (and shipping nightly builds for) Safari for Windows at 
2012.
Safari 5.1.7 was the last version. I downloaded and checked it. The date bug is 
not reproducible with it, but this gives us almost nothing taking into account 
the version is much outdated.

So that Windows code path might not have been well tested, since
http://trac.webkit.org/changeset/159892 was commited...

(WebKit Win port is still supported and can be built on your own.)

What I can do else to verify the changes is to run WebKit LayoutTests aimed at 
date testing and see if there're no regressions.

Also, please put the info you posted into JIRA.

Regards,
Anton.

On 29.06.2015 21:42, Anton Tarasov wrote:

Hi Steve,

Ok, I'll investigate it.

Thanks,
Anton.

On 29.06.2015 18:39, Hruda, Steve wrote:

Hi Anton  Kevin,

we read your comments in the JDK bug system and analyzed WebKit's changesets 
again.

We’ve found the code which made this regression.

http://trac.webkit.org/changeset/159892

This changeset doesn't handle one special case, which was handled by the 
previous code

double diff = ((localSystemTime.wHour - offsetHour) * secondsPerHour)
+ ((localSystemTime.wMinute
- offsetMinute) *60);


(http://trac.webkit.org/browser

Re: JavaFx: webview print with scale 100%

2015-06-30 Thread Anton V. Tarasov

Hi Alexander,

Thanks for posting the samples. I'll check the printing stuff and will update 
on results.

Regards,
Anton.

On 27.06.2015 9:30, Александр Свиридов wrote:

Hi Anton,

I send all files. If you open index.html in IE and printpreview-set scale 100% - print , you 
will get 16.8 cm of div on paper.


If you you print via application I did you will get quite different size.


Пятница, 19 июня 2015, 17:03 +03:00 от Anton V. Tarasov 
anton.tara...@oracle.com:

Hi Alexander,

Could you please create and send a simple test case (fully functioning) 
with the exact URL of
a page
you're printing?

Regards,
Anotn.

On 15.06.2015 8:53, Александр Свиридов wrote:
 To print my html page I use the following code:
 PrinterJob job =PrinterJob.createPrinterJob();if(job !=null 
job.showPrintDialog(null)){
 webView.getEngine().print(job);
 job.endJob();}
 The problem is that webview changes the scale of printing page. For 
example, when I print
this html page in IE with fit to size 100% I get 16.8 cm. When I print in 
my java application
I get 11.4cm. The size in html file I set in pt - my width is 475pt(A4 
width=595pt,so
475pt=16.8cm). How to print with webview and to have 100% width and height?






Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-06-30 Thread Anton V. Tarasov

On 30.06.2015 21:50, Hruda, Steve wrote:

Yesterday I added my patch to the associated bug entry - 
https://bugs.webkit.org/show_bug.cgi?id=137003

It seems that someone landed my patch for automated commit but the WebKit 
Commit Bot rejected my patch because of some stupid formatting mistakes (tabs 
instead of spaces ...).


Oh, don't tab please )



I corrected the styling and uploaded a new patch. I set the commit-queue flag to 
? as mentioned on the https://www.webkit.org/coding/contributing.html  
https://trac.webkit.org/wiki/CommitQueue page.



Sounds great! Looking forward for the results then.

Thanks,
Anton.






Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, 
Austria, Tel. +43 (1) 9610567-0
The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.


-Original Message-
From: Anton V. Tarasov [mailto:anton.tara...@oracle.com]
Sent: Tuesday, June 30, 2015 8:40 PM
To: Hruda, Steve; Kevin Rushforth
Cc: openjfx-dev@openjdk.java.net
Subject: Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() 
of a ISO strings returns a wrong value

On 30.06.2015 21:13, Hruda, Steve wrote:

Hi Anton,
thanks for the detailed information and the good news.

You talk about JDK's jira? Am I right? . I don't have an access for that 
JIRA system since the JavaFX's Jira has moved to the JDK Bug System.

Ah, ok. Then I'll quote your e-mail.


About the Apple stuff.
I know that Apple dropped Windows Safari support and in my opinion is this a 
very bad situation for WebKit (in case of Windows) and especially since 
Google and Opera using Google's Blink engine.

In case of the JDK it would be more practicable to switch from WebKit to Blink, 
because this engine is still used by Companies which have Windows end-users.

There is a high probability that WebKit get more such bugs if there is no big 
player like Google or Apple who has the man power to fix such OS dependent 
issues.

I see. However, switching to Blink is another story. Honestly, we're not 
planning it in the nearest future. This requires extra resources which we don't 
have at the moment...


Last questions:
Do you need any additional information from my side? And is it possible to 
integrate this fix in 8u60?

  From my side, I'll do a sanity check with WebKit LayoutTests, then if it goes 
well, we can consider commiting this to 8u60.

@Kevin, do you think we can?

Also, as an option for you (Steve). You can post the changes to the WebKit 
alias and ask if they think this is a valid fix for the issue. Any confirmation 
from the WebKit team would help us to make sure the fix is reliable.

Thanks!
Anton.


Thanks in advance!
Best Regards,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber Sitz der
Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43
(1) 9610567-0 Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN
116859 b Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401,
Steuer-Nummer: 264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber Registered office and
Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel.
+43 (1) 9610567-0 The company is recorded at the commercial court of
Vienna under the company register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264

Re: Differences between WebView and Webkit

2015-06-25 Thread Anton V. Tarasov

Hi Steve,

You're correct, WebView doesn't include all the features that WebKit provides. This is configured at 
a compile time with a set of preprocessor definitions.


The reason is that a feature may not work from scratch for WebView and may require additional code 
changes in WebView port. So, every feature should be explored before including into WebView.


Regards,
Anton.

On 25.06.2015 7:39, Steve Hannah wrote:

To sort of answer my own question, I found out that the JavaFX webview is
missing quite a few APIs that are present in Webkit.  This is the result of
the HTML test I ran:
https://html5test.com/s/71bdbe284015d02b.html

This gives me a starting point so I can create polyfills if I want to move
forward.

Steve

On Wed, Jun 24, 2015 at 8:41 AM, Steve Hannah st...@weblite.ca wrote:


I have a javascript app that is not loading in the JavaFX webview (JDK8).
   User agent string indicates WebKit 537.44, so I downloaded the nightly
build for WebKit 537.44 to test, and the app works in that.

No errors are reported in the webview (I've hooked up change listeners,
error listeners, etc...), and I hooked up Firebug lite - but it also
doesn't report any errors -- likely either errors are occurring before the
page is loaded (i.e. before Firebug lite is added).

Does WebKit 537.44 use the exact same Javascript engine as the WebView
that reports 537.44 as the webkit version - or are there some differences?

--
Steve Hannah
Web Lite Solutions Corp.








Re: WebView doesn't render html input elements

2015-06-24 Thread Anton V. Tarasov

Hi Alexander,

Yes, the issue exists indeed. I've filed it as: JDK-8129800 
https://bugs.openjdk.java.net/browse/JDK-8129800 [WebView] controls not showing up initially on 
Linux. However, I don't reproduce it with your test but with a slightly different one.


Anyway, thanks for reporting it.

Regards,
Anton.

On 23.06.2015 20:21, Александр Свиридов wrote:

  I have very simple html code (no css, nor js) that includes five inputs with 
type=radio (in one column) and webview in JavaFX 8 which loads this page.

The problem is the following - sometimes these radios are rendered sometimes 
not.

For example, I start application - webview loads page, however there is empty 
space where these radio must be (these inputs are not rendered,they are not 
seen). But, when I move mouse over the area where these radios must be, they 
appear.

I see this problem in Linux - Centos, Ubuntu and Windows XP. I've not seen this 
problem in Win7.

Here is the code I tested. All the program consists of two classes:

public class JavaFXApplication extends Application {
 private int count=0;
 @Override
 public void start(Stage primaryStage) {
 final Button printButton = new Button(Print);
 final WebView webPage = new WebView();
 final WebEngine webEngine = webPage.getEngine();
 printButton.setOnAction(new EventHandlerActionEvent() {
 @Override public void handle(ActionEvent e) {
 String html=html dir=\ltr\head\n +
 meta http-equiv=\content-type\ content=\text/html; charset=utf-8\\n +
/head\n +
body contenteditable=\true\\n +
 \n +
 \n +
 \n +
\n +
\n +
p align=\justify\ style=\text-align: left; margin-bottom: 0in; line-height: 
150%;margin-bottom: 0in; line-height: 100%\\n +
font style=\font-size: 14pt\ face=\serif\Стали бы Вы на пути\n +
грабителя грузового вагона?/font/pp align=\justify\ style=\text-align: left; margin-bottom: 0in; line-height: 
150%;\font style=\font-size: 14pt\ face=\serif\Выберите ответ:/font/p\n +
\n +
form name='mainForm' style='margin-top:15px;'\n +
input type='radio' name='answer' value='641' font size='4'Полностью согласен, полное 
«Да»/fontbr\n +
input type='radio' name='answer' value='642' font size='4'Больше «Да», чем 
«Нет»/fontbr\n +
input type='radio' name='answer' value='643' font size='4'Ни «Да», ни «Нет», нечто 
среднее/fontbr\n +
input type='radio' name='answer' value='644' font size='4'Больше «Нет», чем 
«Да»/fontbr\n +
input type='radio' name='answer' value='645' font size='4'Полное 
«Нет»/fontbr\n +
/formscript type=\text/javascript\\n +
function getAnswerId(){\n +
 var elements = document.getElementsByName(\answer\);\n +
 for (var i=0, len=elements.length; ilen; ++i) {\n +
 if (elements[i].checked) return elements[i].value;\n +
 }\n +
 return null;\n +
}\n +
/script/body/html;
 html+=count;
 count++;
 webEngine.loadContent(html);
 }
 });
 HBox hbox = new HBox();
 hbox.getChildren().addAll(printButton);
 BorderPane borderPane = new BorderPane();
 borderPane.setTop(hbox);
 borderPane.setCenter(webPage);
 Scene scene = new Scene(borderPane, 300, 250);
 primaryStage.setTitle(WebView radio bugs);
 primaryStage.setScene(scene);
  primaryStage.show();
 }
}

And the second class

public class JavaApplication {
 /**
  * @param args the command line arguments
  */
 public static void main(String[] args) {
 Application.launch(JavaFXApplication.class, args);
 }
}

After that I click Print button. After every clicking count++. Compiled openjdk 
1.8.45. Tested winxp oracle 1.8.40, centos71,ubuntu 12 oracle 1.8.60. The image 
from xp. 29 clicks after that no radios. Moved mouse over 1,3,5: . The result 
is on the image I attached. Please, answer.






[9/8u60] Request for review: JDK-8087932 [Mac] intermittent crash on exit in WebView

2015-06-23 Thread Anton V. Tarasov

Hi Kevin,

Please review the fix:

JBS: https://bugs.openjdk.java.net/browse/JDK-8087932
webrev: http://cr.openjdk.java.net/~ant/JDK-8087932/webrev.0

Thanks,
Anton.


Re: Patch for JDK-8090098 - [regression] Webview - getTimezoneOffset() of a ISO strings returns a wrong value

2015-06-23 Thread Anton V. Tarasov

On 23.06.2015 17:48, Kevin Rushforth wrote:

Hi Steve,

Thank you for taking the time to create this patch. I will add this information 
to the bug report.

Since your OCA is in progress we will take a look at your patch, but will need indication from the 
OCA office that it the OCA has been received before we could push it. And just to be clear, you 
won't have access to the repository even with an OCA. What the OCA will do is allow you to 
contribute patches.


I will note that it is likely too late for 8u60, but Anton can evaluate it and post his comment in 
the bug report.


Kevin,

I'm checking it.

Steve, thanks for the participation!

Regards,
Anton.



-- Kevin


Hruda, Steve wrote:

Hi,
I've created a 8u-dev patch for the following WeKit regression which comes with 
8u60.
https://bugs.openjdk.java.net/browse/JDK-8090098

Please can someone of you apply this patch to fix the getTimezoneOffset() issue. I have no access 
to the repository - my OCA is still pending.


In addition I tried to test this patch , but I wasn't able to build the necessary jfxwebkit.dll 
on my windows system (https://www.mail-archive.com/openjfx-dev@openjdk.java.net/msg09439.html 
). but I got no compile erros on Mac.


Patch download:
https://drive.google.com/file/d/0B7P_rknS1TWxM3BSTTU2OVZ4dGM/view?usp=sharing

The patch includes the following WebKit fixes:
Changeset 174377  - [Win] DateMath's calculateUTFOffset does not account for 
DST.
http://trac.webkit.org/changeset/174377

Changeset 175078  - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET
http://trac.webkit.org/changeset/175078

Changeset 181360 - [Win] 17 different JSC tests started to fail in DST
http://trac.webkit.org/changeset/181360

Please let me know if you need further information.

Thanks in advance!
Best Regards
Steve



Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, Austria, Tel. +43 
(1) 9610567-0
The company is recorded at the commercial court of Vienna under the company register number FN 
116859 b

VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, die vertraulich 
sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis darstellen. Falls Sie diese 
Nachricht irrtümlicherweise erhalten haben, benachrichtigen Sie uns bitte umgehend, indem Sie 
eine Antwort senden, und löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche 
aufgeführten Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und entsprechen 
nicht notwendigerweise denen des Unternehmens Intergraph.


This E-Mail (and any attachments) may be confidential and protected by legal privilege. If you 
are not the intended recipient please notify us immediately by replying to the sender and delete 
this E-Mail and your reply from your system. All the views and opinions published here are solely 
based on the author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.







Re: Building OpenJFX with WebKit

2015-06-19 Thread Anton V. Tarasov

Hi Ondra, Michael,

On 16.06.2015 18:04, Michael Hoffer wrote:

Hi Ondra,

I was able to build WebKit after reverting the version number from 1.3 to
1.2. On Linux there should be a package called libicu48. I guess it is
equivalent to webview-deps 1.3. If you install it WebKit should compile.


webview-deps 1.3 for Linux contains the following set of ICU 48:

   libicudata.a
   libicui18n.a
   libicuio.a
   libicuuc.a



Regards,
Michael

2015-06-15 1:02 GMT+02:00 Ondra Pelech ondra.pel...@gmail.com:


Hello,
I'm trying to build OpenJFX with WebKit, but I'm missing the
dependency com.sun.webkit:webview-deps:1.3
I've come across this thread from May
http://comments.gmane.org/gmane.comp.java.openjdk.openjfx.devel/9447
but webkit:webview-deps:1.3 is still not on maven central


We're going to put it in Central soon. Sorry for the delay.

Regards,
Anton.



is there another place I can get it from? or how can I build it myself?

thank you, best regards
Ondra



Building Webkit configuration /Release/ into
/home/ondra/Projects/rt/modules/web/build/linux
:web:compileNativeLinux FAILED

FAILURE: Build failed with an exception.

* Where:
Build file '/home/ondra/Projects/rt/build.gradle' line: 2512

* What went wrong:
Execution failed for task ':web:compileNativeLinux'.

Could not resolve all dependencies for configuration ':web:webkit'.

 Could not find com.sun.webkit:webview-deps:1.3.
  Required by:
  rt:web:unspecified








Re: Windows - Building OpenJFX with Webkit - Missing webview-deps:1.3

2015-06-19 Thread Anton V. Tarasov

Hi Hruda,

On Windows you won't be able to build it with webview-deps 1.2 as you need ICU 
built for static linking.
We're going to resume the activity of pushing the proper deps to Maven Central in the nearest time. 
Sorry for the incovinence.


Anton.

On 18.06.2015 22:05, Hruda, Steve wrote:

Hi,
I tried to build the JFX’s Webkit version by using Michael’s mentioned 
workaround on windows, but I wasn’t successful.

http://mail.openjdk.java.net/pipermail/openjfx-dev/2015-June/017424.html

Is there another workaround?

…Or can anyone send me the needed file so that I can temporary add it to my 
private repository.

Thanks in advance,
Steve




Diese E-Mail wurde versandt im Auftrag des Unternehmens Intergraph Ges.m.b.H.
Vertretungsberechtigte Geschäftsführer: Maximilian Weber
Sitz der Gesellschaft: Margaretenstraße 70/I/1, 1050 Wien, Österreich, Tel. +43 
(1) 9610567-0
Eingetragen beim Handelsgericht Wien, Firmenbuch-Nr.: FN 116859 b
Umsatzsteuer-Identifikationsnummer / VAT-ID: ATU15138401, Steuer-Nummer: 
264/4807

This E-Mail has been sent on behalf of the company Intergraph Ges.m.b.H.
Authorised Managing Directors: Maximilian Weber
Registered office and Austrian headquarters: Margaretenstr. 70/I/1, 1050 Wien, 
Austria, Tel. +43 (1) 9610567-0
The company is recorded at the commercial court of Vienna under the company 
register number FN 116859 b
VAT-ID: ATU15138401, Austrian Tax ID: 264/4807

Diese E-Mail (mit zugehörigen Dateien) enthält möglicherweise Informationen, 
die vertraulich sind, dem Urheberrecht unterliegen oder ein Geschäftsgeheimnis 
darstellen. Falls Sie diese Nachricht irrtümlicherweise erhalten haben, 
benachrichtigen Sie uns bitte umgehend, indem Sie eine Antwort senden, und 
löschen Sie bitte diese E-Mail und Ihre Antwort darauf. Sämtliche aufgeführten 
Ansichten oder Meinungen sind ausschließlich diejenigen des Autors und 
entsprechen nicht notwendigerweise denen des Unternehmens Intergraph.

This E-Mail (and any attachments) may be confidential and protected by legal 
privilege. If you are not the intended recipient please notify us immediately 
by replying to the sender and delete this E-Mail and your reply from your 
system. All the views and opinions published here are solely based on the 
author's own opinion and should not be considered necessarily as reflecting the 
opinion of Intergraph.








[9] request for review: JDK-8089990 [WebView] fix the race with generate/copy the InspectorJS* files

2015-06-18 Thread Anton V. Tarasov

Hi Kevin,

Please, review the fix:

JIRA: https://bugs.openjdk.java.net/browse/JDK-8089990
webrev: http://cr.openjdk.java.net/~ant/JDK-8089990/webrev.0

Thanks,
Anton.



[9] request for review: RT-34644 Webview radio button and checkboxes missing

2015-06-10 Thread Anton V. Tarasov

Hi Kevin,

Please review the fix:

JIRA: https://javafx-jira.kenai.com/browse/RT-34644
webrev: http://cr.openjdk.java.net/~ant/RT-34644/webrev.0

Thanks,
Anton.


[9] request for review: RT-46191 [WebView] zooming google maps hangs

2015-06-09 Thread Anton V. Tarasov

Kevin, Jim,

Please review the fix:

JIRA: https://javafx-jira.kenai.com/browse/RT-46191
webrev: http://cr.openjdk.java.net/~ant/RT-46191/webrev.0

Thanks,
Anton.


[8u60, 9] post-commit notification: RT-40630 [WebView] outstanding resource locks detected when playing youtube

2015-06-02 Thread Anton V. Tarasov

JIRA: https://javafx-jira.kenai.com/browse/RT-40630
webrev: http://cr.openjdk.java.net/~ant/RT-40630/webrev.0

Thanks,
Anton.


Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Anton V. Tarasov

Vote: YES

On 29.05.2015 16:16, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in 
the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in 
[3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin





Re: Compiling OpenJFX + WebKit

2015-05-28 Thread Anton V. Tarasov

Hi Michael,

[Sorry for the delay...]

On 11.05.2015 19:12, Michael Hoffer wrote:

Hi,

I just tried to compile OpenJFX from the 8u-dev branch on OS X and Ubuntu.
Unfortunately, I'm experiencing several problems. Without WebKit everything
works fine. But with WebKit there are several problems:

1. the build script has a webview-deps:1.3 dependency which has not been
published on maven central.

If I revert the version number of the dependency to the 1.2 version (newest
version that is available) I run into the next problem:


As Kevin mentioned you can't build it with webview-deps 1.2 (except may be for OSX where the new 
deps weren't changed).


On Linux webview-deps 1.3 additionally contain ICU 48 libs for static linking:

lib/
  libicudata.a
  libicui18n.a
  libicuio.a
  libicuuc.a

include/unicode/
  a list of related headers

You can take the sources from here and try to build them on your own:

http://site.icu-project.org/download/48



2. WebKit does not compile on Ubuntu because of missing libraries (can be
fixed via sudo apt-get install libqt4-dev)

If I add the missing dependencies I can compile WebKit, but


Does it mean you found the missing ICU static libs in libqt4-dev?...



3. the generated Java code contains errors (also happens on OS X), starting
with

openjfx/rt-8u-dev/modules/web/build/linux/Release/WebCore/generated/java/com/sun/webkit/dom/CounterImpl.java:5:
error: cannot find symbol
import com.sun.webkit.Disposer;
  ^
   symbol:   class Disposer
   location: package com.sun.webkit


The sources in:

rt/modules/web/build/linux/Release/WebCore/generated/java

are copied from:

rt/modules/web/src/main/java-wrappers.

These sources depend on the main sources in: rt/modules/web/src/main/java.

The build process goes in the following order:

1. java sources: rt/modules/web/src/main/java
2. native sources: rt/modules/web/src/main/native
3. generated java sources: 
rt/modules/web/build/linux/Release/WebCore/generated/java

So, on the 3rd step all the main java compiled sources should already be put 
into:

rt/modules/web/build/classes/main

including the com.sun.webkit.Disposer class. So, please check you have it there.

Also, please make sure you have Gradle v1.8 as recommended on the wiki page.

In case you continue facing issues with the generated java sources, please send me the full build 
log file...




Are these known problems? I'd really love to compile my own OpenJFX version
as I did with the first Java 8 preview version where the compilation was
relatively easy to accomplish.

4. In my opinion the wiki should be updated with more recent information on
which os/library/compiler version is needed. On OS X for example, I needed
to use qtmake from qt5 since the qt4 version was missing the correct spec
file for clang. And it was generally unclear whether building on OS X 10.9
or 10.10 is supported.

Any help is appreciated! And I'm also willing to contribute documentation/
fixes if necessary.


(Kevin already responded to this point.)


Thank you for the reporting problems!

With regards,
Anton.



Regards,
Michael Hoffer





Re: Compiling OpenJFX + WebKit

2015-05-28 Thread Anton V. Tarasov

On 11.05.2015 20:06, Kevin Rushforth wrote:

Hi Michael,

Thanks for pointing this out. I'm not sure what we did last time to get the webview-deps into 
maven, but Anton can probably check into it. It will not build successfully with the older version 
of webview-deps so I don't recommend wasting any time trying.


Delivering to Maven Central is still in progress. The activity was suspended for a while (sorry 
about that...) but I'm planning to resume it ASAP.


With regards,
Anton.



In addition, we now rely on upgraded compilers with C++11 support, and also Qt 5.2, to build 
WebView. We can update the Wiki. If you can help (or at least point out all the places that you 
found that are now out of date), that would be great.


Our supported build platforms, which also need to be specified on the Wiki are:

Windows:  Windows 7 or later, VS 2013
Mac: OS X 10.9.5 or later, Xcode 5.1.1
Linux: Ubuntu 14.04 or later (we use Oracle Linux 6.4 with devtoolset-3 gcc 4.9 
compilers)

-- Kevin


Michael Hoffer wrote:

Hi,

I just tried to compile OpenJFX from the 8u-dev branch on OS X and Ubuntu.
Unfortunately, I'm experiencing several problems. Without WebKit everything
works fine. But with WebKit there are several problems:

1. the build script has a webview-deps:1.3 dependency which has not been
published on maven central.

If I revert the version number of the dependency to the 1.2 version (newest
version that is available) I run into the next problem:

2. WebKit does not compile on Ubuntu because of missing libraries (can be
fixed via sudo apt-get install libqt4-dev)

If I add the missing dependencies I can compile WebKit, but

3. the generated Java code contains errors (also happens on OS X), starting
with

openjfx/rt-8u-dev/modules/web/build/linux/Release/WebCore/generated/java/com/sun/webkit/dom/CounterImpl.java:5: 


error: cannot find symbol
import com.sun.webkit.Disposer;
 ^
  symbol:   class Disposer
  location: package com.sun.webkit

Are these known problems? I'd really love to compile my own OpenJFX version
as I did with the first Java 8 preview version where the compilation was
relatively easy to accomplish.

4. In my opinion the wiki should be updated with more recent information on
which os/library/compiler version is needed. On OS X for example, I needed
to use qtmake from qt5 since the qt4 version was missing the correct spec
file for clang. And it was generally unclear whether building on OS X 10.9
or 10.10 is supported.

Any help is appreciated! And I'm also willing to contribute documentation/
fixes if necessary.

Regards,
Michael Hoffer





[8u-dev] post-commit notification: RT-40608, RT-40560, RT-40605, RT-40561

2015-04-22 Thread Anton V. Tarasov

Direct backports:

https://javafx-jira.kenai.com/browse/RT-40608
changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a589b750789f

https://javafx-jira.kenai.com/browse/RT-40560
changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4cf12ed74b40

https://javafx-jira.kenai.com/browse/RT-40605
changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ee7146b4ffc0

https://javafx-jira.kenai.com/browse/RT-40561
changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b88922e7b1e4

Regards,
Anton.


[9] post-commit notification: RT-40605 [WebView] use OUT_PWD for a current build dir

2015-04-22 Thread Anton V. Tarasov

JIRA: https://javafx-jira.kenai.com/browse/RT-40605
Changeset: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ce91d2419086

Regards,
Anton.


[9] post-commit notification: RT-40271 Use application locale setting in WebView language header

2015-04-09 Thread Anton V. Tarasov

JIRA: https://javafx-jira.kenai.com/browse/RT-40271
Changeset: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecf20572029f

Regards,
Anton.


Re: 8u40 is released

2015-03-04 Thread Anton V. Tarasov

Hi Emmanuel,

jfx8u40/WebView (libjfxwebkit.so) doesn't link with icu lib, however it has that option and so it 
contains all the related headers which it nevertheless uses during the build process.


UChar32 was defined as unsigned in older icu versions and it is still that in the jfx8u40/WebView 
sources.


As to the failure you've encountered. It seems like you have libxml2 on your system which was 
compiled/installed with icu-enabled option. I'm afraid you should recompile it with icu disabled in 
order to build WebView.


There's a similar issue reported against Qt WebKit port: 
https://bugs.webkit.org/show_bug.cgi?id=82824

Thanks,
Anton.

On 04.03.2015 17:50, Kevin Rushforth wrote:
Anton Tarasov or Andrew Brygin might be able to provide an answer for you, although our effort 
recently has been focused on getting the updated C++11-based WebKit to build.


-- Kevin


Emmanuel Bourg wrote:

Hi Kevin,

I'm updating the OpenJFX package in Debian to the version 8u40-b25
and I get a compilation failure on WebKit:

In file included from /usr/include/x86_64-linux-gnu/unicode/utypes.h:36:0,
 from /usr/include/x86_64-linux-gnu/unicode/ucnv_err.h:86,
 from /usr/include/x86_64-linux-gnu/unicode/ucnv.h:50,
 from /usr/include/libxml2/libxml/encoding.h:31,
 from /usr/include/libxml2/libxml/parser.h:810,
 from 
../../../../src/main/native/Source/WebCore/xml/XSLStyleSheet.h:32,
 from 
../../../../src/main/native/Source/WebCore/xml/XSLTProcessor.h:29,
 from generated/JSXSLTProcessor.h:27,
 from generated/JSXSLTProcessor.cpp:25:
/usr/include/x86_64-linux-gnu/unicode/umachine.h:298:17: error: conflicting declaration 
‘typedef int32_t UChar32’

 typedef int32_t UChar32;
 ^
In file included from 
../../../../src/main/native/Source/WTF/wtf/unicode/Unicode.h:36:0,
 from 
../../../../src/main/native/Source/WTF/wtf/text/ASCIIFastPath.h:31,
 from 
../../../../src/main/native/Source/WTF/wtf/text/WTFString.h:28,
 from 
../../../../src/main/native/Source/WTF/wtf/DateMath.h:54,
 from 
../../../../src/main/native/Source/WebCore/webcorejava_pch.h:57:
../../../../src/main/native/Source/WTF/wtf/unicode/java/UnicodeJava.h:24:18: note: previous 
declaration as ‘typedef uint32_t UChar32’

 typedef uint32_t UChar32;
  ^

It seems UnicodeJava.h and UnicodeWchar.h define UChar32 as an unsigned int32
whereas icu defines it as a signed int32.

Emmanuel Bourg





[9] Post commit notification: RT-40077: javafx.scene.web.IrresponsiveScriptTest hangs on Linux with new WebKit

2015-03-04 Thread Anton V. Tarasov

Hi Kevin,

I've commited a simple fix for this issue:

https://javafx-jira.kenai.com/browse/RT-40077

(The patch is in the comments.)

Thanks,
Anton.


Re: HEADS-UP: [9] New WebKit + compiler upgrade for FX 9

2015-02-24 Thread Anton V. Tarasov

Hi Mike,

From the very beggining of the WebView project the idea behind it was to provide deep integration 
with JFX and the Java platform itself. That, btw, was one of the reason why the choice was made in 
favor of WebKit, which provided a good level of flexibility. As result, the WebView component has 
become a true JFX Node, smoothly fitting in the GUI (for instance, even the HTML input controls are 
made up of their JFX counterparts). So, WebView rendering design was subordinate to JFX architecture 
and its threading model.


Also, the things like images and media processing are also integrated into JFX. What's specially 
important - networking. All the connections and data exchange are performed on behalf of the Java 
platform, allowing for the corresponding Java security policy to be applied. Thus, WebView relies on 
JFX and Java in terms of global security (this of course doesn't cover the lowlevel security of the 
native code where we rely on WebKit itself).


I'm not aware of the details behind the Chromium sandbox, but AFAICS its total sandboxing is 
achieved by means of deep integration with platform API (on every supported platform). This seems to 
be quite distant from the concepts behind JFX/WebView. What comes into the mind immediately is the 
fact that Chromium model demands a separate renderer (in a separate process) per sandbox, whereas 
JFX has a single Render thread on which WebView is rendered as well. So, switching to this 
architecture would either require serious rewrite of JFX (making it subordinate to WebView), or 
complete separation of WebView itself, virtually making the embedding model heavyweight. 
Heavyweight embedding has its own pros and cons. However, the fact is that the embedding model 
initially chosen for the web component was lightweight.


So, I can just repeat what Kevin said: I wonder if that might make sense some 
day...

Thanks,
Anton.


On 21.02.2015 1:35, Kevin Rushforth wrote:

Quick answers:

1) Yes, we hope to get on a more regular cadence with updates. This one was particularly painful 
because WebKit moved to requiring C++11 meaning it was dependent on the compiler upgrade. The next 
one might be somewhat painful as well since they have moved from Qmake to Automake.


2) We've only thought about using Blink in a Hmm, I wonder if that might make sense some day 
sense. We haven't given any serious thought to it. Anton might have some thoughts on the 
sandboxing question.


-- Kevin


Mike Hearn wrote:


The changeset patch is 185 Mbytes and touches 11,688 files including added, 
removed,
modifiled files. I tried generating a webrev, but it is just too big and 
unweildy to upload
(over 1.6 GBytes).


A 185 megabyte patch!? That is .. mind boggling. I don't envy you guys!

Couple of questions:

1) I'm curious if there are plans to sync with WebKit upstream more frequently from now on to try 
and reduce the pain of upgrades. As WebKit is so complex and security sensitive, and not 
sandboxed in the same way as Chrome, regular updates seem vital for security. Of course this 
doesn't matter if you are just rendering your own content but for displaying potentially hostile 
content, it seems important.



2) Have you considered using Blink instead, perhaps that way you would get the sandboxing tech 
from Chromium? Or does the WebKit JFX uses now have cross-platform sandboxing in it as well?



Thanks!




Re: HEADS-UP: [9] New WebKit + compiler upgrade for FX 9

2015-02-24 Thread Anton V. Tarasov

On 24.02.2015 15:24, Mike Hearn wrote:
I see, thanks for the background Anton. I haven't used WebView in my own app (partly because it's 
security sensitive) so didn't realise how integrated the control is! That's indeed a very 
impressive level of integration.


You're welcome!



It's possible I'm over-thinking this. Disabling JavaScript is probably enough to satisfy many use 
cases with acceptable levels of security.


Alternatively, occasionally I look around for a pure-Java HTML/CSS rendering engine. But most of 
the ones I've found are quite primitive.


I suppose so, because otherwise they would need to compete with WebKit that is 
a challenge...

Regards,
Anton.


[8u60] Review request: RT-37371 IllegalThreadStateException in WebView when loading flickr.com

2015-02-18 Thread Anton V. Tarasov

Hi Kevin, Vadim,

Please review the fix:

https://javafx-jira.kenai.com/browse/RT-37371
http://cr.openjdk.java.net/~ant/RT-37371/webrev.0

Thanks,
Anton.


[8u40] Review request: RT-39332 A typo in ViewPainter.getPixelScaleFactor

2014-11-10 Thread Anton V. Tarasov

Hello,

A typo is fixed:

https://javafx-jira.kenai.com/browse/RT-39332

Thanks,
Anton.


Re: [8u40] Review request for RT-38915: [Mac, JFXPanel] WebView draws duplicate image on Retina display

2014-10-13 Thread Anton V. Tarasov

Sorry, I didn't add the webrev. Done.

Thanks,
Anton.

On 10.10.2014 21:02, Stephen F Northover wrote:

Looks good Anton.  Please make sure the link to the webrev is in the JIRA and I 
will +1 it there.

Steve

On 2014-10-10, 12:40 PM, Anton V. Tarasov wrote:

Hi Steve,

Please, review the fix:

https://javafx-jira.kenai.com/browse/RT-38915
http://cr.openjdk.java.net/~ant/RT-38915/webrev.0

Where some additional cleanup (field reset) is made on JFXPanel disposal.

Thanks,
Anton.






[8u40] Review request for RT-38915: [Mac,JFXPanel] WebView draws duplicate image on Retina display

2014-10-10 Thread Anton V. Tarasov

Hi Steve,

Please, review the fix:

https://javafx-jira.kenai.com/browse/RT-38915
http://cr.openjdk.java.net/~ant/RT-38915/webrev.0

Where some additional cleanup (field reset) is made on JFXPanel disposal.

Thanks,
Anton.


[8u40] Review request: RT-36449 [WebView] URLLoader throws an exception on 401 HTTP error with no body

2014-09-17 Thread Anton V. Tarasov

Hi Leonid, Kevin,

Please review a fix:

https://javafx-jira.kenai.com/browse/RT-36449
http://cr.openjdk.java.net/~ant/RT-36449/webrev.0

Thanks,
Anton.


Re: [8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken

2014-08-27 Thread Anton V. Tarasov

Hi Steve,

Sure, thanks for the reminder.

Anton.

On 27.08.2014 1:11, Stephen F Northover wrote:

Hi Anton T,

The policy for OpenJFX is that code reviews happen in the associated JIRA:

https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews

Thanks for reviewing this code,

Steve

On 2014-08-26, 3:30 PM, Anton V. Tarasov wrote:

Hi Anton,

Does it make sense to add a boolean param to renderLayer() which would tell it if it should 
dispose the layer after rendering? In order to avoid the splitting.


Also, could you please clarify the following.

From your comments:

  72 // WCBufferedContext might be referenced from a client JS code and 
thus
  73 // couldn't be disposed right after rendering operations on it.

However, when it is disposed (will it?) it looks like it will re-render all the layers 
(WCGraphicsPrismContext.dispose). Is it an expected behavior?


Thanks,
Anton.


On 8/20/14 9:26 PM, anton nashatyrev wrote:

Hello,

could you please review the fix for 
https://javafx-jira.kenai.com/browse/RT-38290 ?

Thank you!
Anton.








Re: [8u] Review request: RT-38290: [WebView] HTML canvas clip() functionality broken

2014-08-26 Thread Anton V. Tarasov

Hi Anton,

Does it make sense to add a boolean param to renderLayer() which would 
tell it if it should dispose the layer after rendering? In order to 
avoid the splitting.


Also, could you please clarify the following.

From your comments:

  72 // WCBufferedContext might be referenced from a client JS 
code and thus
  73 // couldn't be disposed right after rendering operations 
on it.


However, when it is disposed (will it?) it looks like it will re-render 
all the layers (WCGraphicsPrismContext.dispose). Is it an expected behavior?


Thanks,
Anton.


On 8/20/14 9:26 PM, anton nashatyrev wrote:

Hello,

could you please review the fix for 
https://javafx-jira.kenai.com/browse/RT-38290 ?


Thank you!
Anton.




Re: Fwd: CFV: New OpenJFX Committer: Vadim Pakhnushev

2013-12-12 Thread Anton V. Tarasov

Vote: YES

Thanks,
Anton.

On 12.12.2013 1:17, David Hill wrote:


I hereby nominate Vadim Pakhnushev to OpenJFX Committer.

Vadim is a member of JavaFX Embedded team at Oracle. Vadim's changes are in 
Glass Windows/D3d:

  hg log -M -u vadim

An incomplete list of Vadim's commits and reviews is also available by the 
following link:

http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=vadim

Votes are due by Dec 25, 2013.

Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in 
the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in 
[3].


[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus

[3] http://openjdk.java.net/projects#project-committer

Thanks,

Dave







Review request: RT-34380 [SWT] FXCanvas: black backwards L rectangle on the right when resized

2013-11-22 Thread Anton V. Tarasov

Hi Felipe,

Please review the updated version:

jira: https://javafx-jira.kenai.com/browse/RT-34380
webrev: http://cr.openjdk.java.net/~ant/RT-34380/webrev.0

Thanks,
Anton.




Re: Multiple JFXPanel?

2013-08-07 Thread Anton V. Tarasov

Hi Pedro,

On 05.08.2013 2:13, Pedro Duque Vieira wrote:

Hi Anton,

Thanks for your reply.

Actually I wasn't clear enough when I explained my app.
My app is composed of a MDI style interface but each window belongs to the same JFrame, so there 
is only one JFrame but multiple internal frames. One of these internal frames has a JFXPanel with 
a scene in it. I intend to migrate the rest of the internal frames to javafx one by one using this 
approach.


Sorry, I didn't get it.



My question was is this a viable way to do this? Or am I going to pay a performance penalty from 
having multiple JFXPanels (hence multiple scenes) inside the same app (the same JFrame)?


Actually, it doesn't matter for an embedded scene where you embed it, to a separate frame or to an 
internal one. In both the cases the embedded scene will have the same machinery behind.

Just for curiosity, I've modified my testcase to be MDI like and got the same 
performance scores.

So, your case should not bring any additional performance decrease, except for the difference b/w 
your fx  swing implementations which may depend.


Thanks,
Anton.



From what people have told me in this mailing list, they are using multiple JFXPanels without any 
significant performance penalty, anyway it would be interesting hearing the opinion from you, 
JavaFX dev team guys.


Thanks once again for your replies, best regards,

On Fri, Aug 2, 2013 at 8:55 AM, Anton V. Tarasov anton.tara...@oracle.com 
mailto:anton.tara...@oracle.com wrote:


Hi Pedro,

I've made the following experiment. I've created two simple test cases: one 
is pure fx stage
showing WebView which animated some guimark2 benchmarks, another one is the 
same WebView
wrapped with JFXPanel put in JFrame.

I ran each test case with a single, two or four toplevels (Stages or 
JFrames, appropriately)
and measured performance difference. I noticed that for the swing test 
case, adding more
toplevels decreased performance with the same proportion like the fx test 
case did (despite
the fact that fx performed relatively faster, of course). For instance, for 
the Vector
Charting Test the ratio was directly proportional to the number of 
toplevels, that is doubling
the toplevels decreased performance by two times equally for both fx and 
swing cases.

This more or less proves the fact that adding another embedded scene into 
your app doesn't
bring anything except another scene.

Thanks,
Anton.


On 01.08.2013 2:45, Pedro Duque Vieira wrote:

Hi,

I have a doubt. I have a swing app with embed javafx scene. My app has 
kind
of a MDI style interface. Right now only one window has been converted 
to
JavaFX, basically it's a window with a JFXPanel in it.
My question is if I want to convert the other windows as well should I 
also
put a JFXPanel in them? I would than have 2 JFXPanels in my app, does 
that
mean I would have 2 JavaFX scenes? Is that the way to do it? Would that
seriously hurt performance?

Thank you in advance, best regards,





--
Pedro Duque Vieira




Re: CFV: New OpenJFX Committer: Petr Pchelko

2013-07-19 Thread Anton V. Tarasov

Vote: yes

On 09.07.2013 14:22, Artem Ananiev wrote:


I hereby nominate Petr Pchelko to OpenJFX Committer.

Petr is a member of AWT group and an active contributor to JDK8 and OpenJFX projects. His primary 
areas of responsibility are AWT, Glass, and Mac OS X. Here is a list of his recent commits to 
OpenJFX:


http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=pchelko

Votes are due by Jul 23, 2013.

Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in 
the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2].

Thanks,

Artem

[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus