Review Request 8176813: Mac: Failure to exit full-screen programmatically in some cases

2017-08-03 Thread Avik Niyogi
Please review the webrev below which tries to fix the issue of GetApplication 
processed for Null values. Any alternatives or suggestions are welcome. This 
fixes the issue presented by the description.
https://bugs.openjdk.java.net/browse/JDK-8176813 
<https://bugs.openjdk.java.net/browse/JDK-8176813>
http://cr.openjdk.java.net/~aniyogi/8176813/webrev.00/ 
<http://cr.openjdk.java.net/~aniyogi/8176813/webrev.00/>
With Regards,
Avik Niyogi

Review Request: JDK-8179514: [macosx] Maximize button is enabled for non-resizable parent window when child window is opened

2017-05-11 Thread Avik Niyogi
Hi All,

Kindly review the following fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-8179514 
<https://bugs.openjdk.java.net/browse/JDK-8179514>

Webrev: http://cr.openjdk.java.net/~aniyogi/8179514/webrev.00/ 
<http://cr.openjdk.java.net/~aniyogi/8179514/webrev.00/>

With Regards,
Avik Niyogi

8089230: Mac: Window.maximize(false) won't restore a window into its original rectangle

2017-05-09 Thread Avik Niyogi


> Begin forwarded message:
> 
> From: Avik Niyogi 
> Subject: 8089230: Mac: Window.maximize(false) won't restore a window into its 
> original rectangle
> Date: 9 May 2017 2:35:39 pm IST
> To: David Hill , Kevin Rushforth 
> , Manajit Halder 
> Cc: Praveen Srivastava 
> 
> Hi All,
> 
> Kindly review the fix for JDK10. 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8089230 
> <https://bugs.openjdk.java.net/browse/JDK-8089230>
> 
> Webrev: http://cr.openjdk.java.net/~aniyogi/8089230/webrev.00/ 
> <http://cr.openjdk.java.net/~aniyogi/8089230/webrev.00/>
> 
> Issue: The test case 
> tests/system/src/test/java/test/javafx/stage/RestoreStagePositionTest.java 
> fails with wrong window position
> 
> Cause:  setFlipFrame method in native Obj C code was implemented wrongly for 
> restorePreZoomedRect method calling method.
> 
> Fix: Significant native changes were implemented to incorporate these changes 
> for this particular case.
> 
> With Regards,
> Avik Niyogi