Re: CFV: New OpenJFX Committer: Guru Hb

[Morris Meyer]

Vote: YES

On 4/28/16 11:16 AM, Kevin Rushforth wrote:

I hereby nominate Guru Hb [1] to OpenJFX Committer.

Guru is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by May 12, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#ghb

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/1ec63f261e9f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/fb4c37073893
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3ccf14ef836f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/45efd3d83bf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/08a57f273c76
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bd97f8ca31fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/0576d7a6f137
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/d4f8c9496683
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/620f5c6b4383
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/aa51df7e1d41

RFR[9] S: 8154579: Pagination demo:thrown java.lang.IllegalArgumentException on console, when clicking the link of "VIEW SOURCE"

[Morris Meyer]

Kevin and Jonathan,

Please review these changes to Ensemble8.  The View Source feature 
parses the source for Strings that look like urls, and was getting 
thrown on using String.format to build a url programmatically.


Thanks,

--morris

BUG - https://bugs.openjdk.java.net/browse/JDK-8154579
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8154579.01/

RFR[9] XS: 8067648: We can not see any radio buttons in Node Properties demo

[Morris Meyer]

David and Kevin,

Please review this comment change to Ensemble8.  I could not find any of 
the PlaygroundProperties for radio buttons in NodePropertiesApp in 8u or 
9-dev.


Thanks,

--morris

BUG - https://bugs.openjdk.java.net/browse/JDK-8087648
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8067648.01/

Re: CFV: New OpenJFX Committer: Murali Billa

[Morris Meyer]

Vote:  YES

On 3/31/16 5:04 PM, Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

Re: Learning Prism

[Morris Meyer]

As the Quantum author I will echo Johan that looking at the 
QuantumToolkit.pulse() and QuantumRenderer.submitRenderJob() are good 
places to start. Ignore the PaintCollector (Pain Collector :-) ) and pay 
attention to the View Painters.


This article has good background.

http://fxexperience.com/2012/02/a-short-tour-through-javafx-ui-common/

The SceneGraph converts SG nodes to Prism NG nodes. The painters convert 
Prism NG nodes into graphics operations. That node graph is rendered 
onto a Prism hardware (or software prism-sw) pipeline.  This winds up at 
the GPU layer in places like native-prism-es2/macosx or native-prism-d3d.


Glass manages operating system resources like menu bars, events, 
dragging, pasteboard, screens and graphical layers.


On Mac OSX drawing winds up in native-glass/mac in places like 
GlassView3D.m (begin, end) and GlassLayer3D.m (drawInCGLContext) - a 
good way to see what is going on at the low level is uncommenting 
VERBOSE in these Glass classes in native-glass/mac and seeing the flow 
at the native level.


There is sort of a separation of Church and State thing going on with 
the Prism native layers (native-prism-es2/macosx vs native-glass/mac) 
that has been very well designed over various iterations by Chein Yang 
in the Java Client Group.


One final note about time from the Quantum dude.  Our JavaFX timebase is 
not driven by a time that is going off at 16 ms to simulate a 60 Hertz 
retrace.  Our pulsed painting timebase (since RT-13660) is driven from 
the vertical retrace interval.  Quantum queues up the pulses from the 
Glass timer at 16 ms (faster than 60 Hz), such that a pulse is waiting 
its turn for the graphics vertical retrace to happen (on Mac, Linux-GPU, 
Windows-D3D and iOS).  The pulse is kicked off immediately after the 
vertical retrace which ensures a rock solid 60 Hz timebase for JavaFX 
animations.


--morris

NP - Young the Giant, Young the Giant, My Body


On 3/7/16 10:45 PM, Jeffrey Guenther wrote:

Hi Devs,

I’m interested in learning more about JavaFX’s low level graphics implementation. 
I’ve spent a couple afternoons source diving in the modules/graphics folder to get 
the lay of the land and now I think I need some help. Can anyone point me to 
documentation describing the system’s high level design? Let’s say one or two levels 
deeper than http://docs.oracle.com/javafx/2/architecture/jfxpub-architecture.htm? 


Ultimately, I’d like to gain a better understanding on how JavaFX lays out and 
renders text for the purposes of understanding how I might be able to 
contribute to a more advanced text API with support for things like kerning.

Secondly, can anyone explain to me how shaders are compiled and passed down to 
the graphics layer? I’d like to gain a better understanding of how a JavaFX 
programmer could leverage/add to Prism such that we can write custom 
shaders/GPU kernels for Effects nodes.

I realize the graphics system in JavaFX is not for the faint of heart. There’s 
much going on beneath the surface. I’m willing to dive deep and do the learning 
to understand the design. Can anyone point me to docs where I can get started? 
Or maybe which class to start with and work out from when I’m source diving?

Jeff

[9-dev] RFR(XS): 8088809: MenuItem.setText() is broken (Mac)

[Morris Meyer]

Kevin, David and David,

Please review this small patch for changing a Mac system menu item, 
where that item is a top level menu in the [NSApp mainMenu] menu bar.


The fix is to look specifically in the main menu for these items, and to 
use the appropriate mechanism to set the title of that top-level menu.


Thanks,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8088809.01/
BUG - https://bugs.openjdk.java.net/browse/JDK-8088809

[9] RFR-XL: 8091485: Ensemble8: Review each sample

[Morris Meyer]

Folks,

Enclosed is my very large webrev for Ensemble8 that has visual 
appearance changes for each and every sample file.


Every sample was gone through and checked for appearance, related docs 
and links.


Every sample code file was scrubbed for bad variable names, long-lines, 
readability, clarity, and comment format.


Every sample now has a link to the JavaFX documentation relevant to that 
sample, an ordered list of API links for the sample and a populated list 
of related samples.


Each link in each sample was tested to verify correct linkage and accuracy.

All changes were to the samples source code and not Samples.java file.

Every import statement in each sample was tested to see if the source 
code actually used it.  Lots of imports were culled.


After these changes Ensemble8 would be much more ready for the Apple App 
Store.


I apologize in advance for the length of this webrev and will buy lunch 
for anyone that actually goes through it next time I'm in Santa Clara.


Use the follow to test out the changes:

ant -Dplatforms.JDK_1.8.home=`/usr/libexec/java_home` 
ensemble-generate-samples-class run


Thanks!

--morris meyer

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8091485.03/
BUG - https://bugs.openjdk.java.net/browse/JDK-8091485

Re: CFV: New OpenJFX Committer: Johan Vos

[Morris Meyer]

Vote: YES

--morris

On 12/21/15 2:45 PM, David Hill wrote:


I hereby nominate Johan Vos to OpenJFX Committer.

Johan Vos (jvos) has been active in the OpenJFX community, and 
instrumental in the maturity of Monocle, the owner of the Android and 
IOS ports and is an OpenJFX Author.


A list of Johan's commits is also available by the following links

http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=jvos
http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=johanvos

Votes are due by January 5th, 2016.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus

[3] http://openjdk.java.net/projects#project-committer

Thanks,

Dave

[9] Review request for JDK-8144789: Incorrect assertion fails in the GlassCursor.m

[Morris Meyer]

Vadim and Kevin,

Please review this fix for the GlassCursor.m assertion failure.

Thanks,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8144780.01a
BUG - https://bugs.openjdk.java.net/browse/JDK-8144780

Re: Pausing Quantum Renderer

[Morris Meyer]

As the original author of the Quantum toolkit and the renderer, this 
sort of addition goes against what I had in mind when designing the 
PaintCollector and the renderer. As the renderer is built around a 
ThreadPoolExecutor, stopping system functionality for an edge case is 
putting the cart before the horse.


When a Window is miniaturized or set to zero size, or moved offscreen, 
there should be no pulses fired at the Window.


This seems more like an issue of ensuring that if the window is 0x0 that 
it is not considered dirty, and if there is no dirty scene that 
nextPulseRequested() is never called.


There does need to be work done on Quantum to ensure that it cycles down 
to no CPU usage when windows are hidden and/or miniaturized on battery 
operated devices. That needs to be done cleanly, but even then pausing 
the ThreadPoolExecutor seems to be the wrong way of going about it.  The 
TPE model is more startup, work, then shutdown, and the QuantumToolkit 
intermediates JavaFX application state with that model.


Best regards,

--morris meyer

On 11/22/15 6:24 AM, Johan Vos wrote:

I implemented this in the javafxports clone of the OpenJFX 8u-dev repo, and
the diff is here:

https://bitbucket.org/javafxports/8u-dev-rt/commits/67a0fded8208095bd04efda6045aa257e245d6bc

I am more than happy to create an issue in the openjdk bug system
(enhancement?) and provide a patch there as well, but I think it needs a
bit more discussion first?

- Johan

On Sat, Nov 21, 2015 at 9:23 PM, Johan Vos <johan@gluonhq.com> wrote:


I have a working implementation that needs more stress-testing on
different platforms, but it seems a good and easy solution so far.
I have this on QuantumToolkit:

 @Override
 public void pauseRenderer(){
 Application.invokeAndWait(() -> this.pause = true);
 PaintCollector.getInstance().waitForRenderingToComplete();
 };

 public void resumeRenderer(){
 Application.invokeAndWait(() -> this.pause = false);
 };

pause is a boolean that is checked for in
void pulse(boolean collect) { ... }

The difficulty I mentioned in my previous mail (how do we know there are
no renderJobs pending/running) was solved easily as there exists this
PaintCollector.waitForRenderingToComplete method.
This might make the pauseRenderer a bit slower, and maybe this is not
needed in all usecases. In that case, we can remove it from the
pauseRenderer() and we can add it either in the Monocle implementation that
will call pauseRenderer, or in a Android/iOS specific code.

However, it seems to me that if you want to pause the renderer, you most
often want to make sure no one is still writing to the glSurface after the
pauseRenderer method is called, so I think it makes sense to keep it there?

- Johan






On Fri, Nov 20, 2015 at 8:14 AM, Johan Vos <johan@gluonhq.com> wrote:


I didn't plan to intercept or cancel pending/submitted jobs, but I have
to wait until they are done before the android callback method returns.

When Android is about to destroy the context, it will call the
surfaceTextureDestroyed method on the Activity (the FXActivity in our
case). As long as that method doesn't return, the context won't be
destroyed. But once that method returns, the context might become invalid
any moment. So if there are still jobs that want to do a swapBuffer after
we return, those can crash or (even worse) corrupt the egl system.

So it seems to me inside the implementation of surfaceTextureDestroyed,
we need to achieve 2 things:
1. make sure no new pulses are generated.
2. don't return while the QuantumRenderer is still executing jobs.

Those 2 things can be combined in a single Toolkit.pauseRenderer() but it
might be better to only achieve the first task in Toolkit.pauseRenderer().
The contract for this method is than that no new pulses will be
generated, but existing renderJobs might still be running when this method
returns.
The second thing, waiting for the renderJobs to be finished, can be done
in the Android specific implementation.

- Johan



On Thu, Nov 19, 2015 at 10:20 PM, Kevin Rushforth <
kevin.rushfo...@oracle.com> wrote:


This might be a tricky semantic to achieve, and great care will be
needed to ensure no deadlocks or race conditions. Not running any more
pulses after this method returns seems fine, but it might be better to let
any existing renderJobs run (possibly discarding the results). This way you
could send the pause message to the renderer as a special renderJob and not
have to worry about jobs that are scheduled but not yet run.

-- Kevin



Johan Vos wrote:


After some experiments, here is my current thinking:

Toolkit can have 2 new methods:
pauseRenderer()
resumeRenderer()

When pauseRenderer is called, it should be guaranteed that after this
call,
no new pulses are fired until resumeRenderer is called.
That is not hard, but it is not enough. Before we pause the pulses, the
previous pulse probably submit

[9] RFR: 8091485: Ensemble8: Review each sample description, playground, appearance, related docs and links

[Morris Meyer]

Kevin, Jonathan and Leif,

Could you please review my changes for 8091485?  The issues that I found 
are enumerated in the bug description.


Thanks much,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8091485.01/
BUG - https://bugs.openjdk.java.net/browse/JDK-8091485

[9-dev] RFR: JDK-8142439: Ensemble8 media player slider issues

[Morris Meyer]

Kevin and Vadim,

Could you please review my changes for the post-commit cleanup to 
JDK-8144354?


Vadim regarding folding:

 if (timeSlider.isValueChanging()) {
 // multiply duration by percentage calculated by 
slider position

 if (duration != null) {
mp.seek(duration.multiply(timeSlider.getValue() / 100.0));
 }
 updateValues();

} else if (Math.abs(now.doubleValue() - 
old.doubleValue()) > 1.5) {
// multiply duration by percentage calculated by 
slider position

if (duration != null) {
mp.seek(duration.multiply(timeSlider.getValue() / 100.0));
}
}

Pretty sure that is correct and cannot be folded as the updateValues() 
is necessary when with a slider changed value, and the click to seek 
value needs to stay unchanged.


Thanks much,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8142439.01/
BUG - https://bugs.openjdk.java.net/browse/JDK-8142439

[9] Review request for 8134366: Modena sample shouldn't access internal JavaFX resources

[Morris Meyer]

Kevin and Jonathan,

Please review my changes to Modena that allow it to work with the 
Jake-JavaFX build.


Thanks much,

--morris meyer

BUG - https://bugs.openjdk.java.net/browse/JDK-8134366
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8134366.03

RFR: JDK-8088993: Accepting object is null after a drop

[Morris Meyer]

Jonathan and Kevin,

Please review this simple fix to DragEvent.java.  It uses the existing 
template for the acceptingObject and has been tested on Mac and Windows.


Thanks much,

--morris

BUG - https://bugs.openjdk.java.net/browse/JDK-8088993
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8088993.01/

[9] Review request: JDK-8087709: Can set only second menu as system, when trying to set two menus at once

[Morris Meyer]

Folks,

For JavaFX on the Mac the system menu bar feature allows us to load a 
JavaFX menu into the top system menu bar.  This issue was caused by the 
MenuBarSkin not previously cleaning out the original loaded system menu 
and un-setting the originally set menu's useSystemMenuBarProperty().


There is a small API change in that the system menu bar property catches 
any attempts at uni-directional binding and throws a RuntimeException 
warning the developer to use bi-directional bindings instead.


Thus the test program should look like:

ToggleButton aAsSystem = new ToggleButton(A as system);
barA.useSystemMenuBarProperty().bindBidirectional(aAsSystem.selectedProperty());
ToggleButton bAsSystem = new ToggleButton(B as system);
barB.useSystemMenuBarProperty().bindBidirectional(bAsSystem.selectedProperty());

Thanks for the review.

--morris meyer

JBS - https://bugs.openjdk.java.net/browse/JDK-8087709
WEBREV - http://cr.openjdk.java.net/~morris/JDK-8087709.01a/

[8u60] Request for Review: 8094649: [Mac] Intermittent crash after starting Multitouch support

[Morris Meyer]

Kevin and David,

Please review the following one-line fix to 8094649.  This issue was 
caused by a race condition between start of touch tracking and the 
closing out the splash screen without removing the touch tracking. It 
was messaging the invalid ObjC object for the GlassViewDelegate and 
crashing.


This has been tested using HelloSanity and using the test app linked in 
this issue.


--morris

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8094649.01/
JBS - https://bugs.openjdk.java.net/browse/JDK-8094649

[9, 8u60] Review request for RT-46170: [Mac] setMaximize stops working

[Morris Meyer]

David and Kevin,

Please review this fix for stage.setMaximize() on Mac.  We were missing 
the update to the Glass Window class that set the underlying window 
state, thus would never maximize again after the first maximize / 
de-maximize iteration.


As this is localized in the one Glass-Mac JNI method it could be a 
possible candidate for inclusion in 8u60.


Thanks much,

--morris meyer

JIRA - https://javafx-jira.kenai.com/browse/RT-46170
WEBREV - http://cr.openjdk.java.net/~morris/RT-46170.01/

[8u60, 9] review request for RT-37411: [Drag and Drop Linux] setDragView still doesn't work on linux

[Morris Meyer]

David, Kevin et al,

Please review this simple fix for RT-37411.  It is pretty low risk 
vis-a-vis 8u60.


Thanks much.

--morris meyer

JIRA - https://javafx-jira.kenai.com/browse/RT-37411
WEBREV - http://cr.openjdk.java.net/~morris/RT-37411.01/

[9-dev] RT-46093: Different months can get the same info You were born yesterday

[Morris Meyer]

For those of us who weren't born yesterday,

Please review the following issue in Ensemble8.  The SimpleDataFormat 
was using minutes in hours instead of months for the formatted string.


Thanks,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-46093.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-46093

Re: App hang and pulse logger stops

[Morris Meyer]

Hi Pedro,

You might want to try setting the flags quantum.debug, quantum.pulse 
and quantum.verbose when launching your application.


Prior to that you might want to try to get a stack trace of the hung 
application using jstack, Visual VM or doing a Ctrl-Break on Windows or 
Control-\ on Mac.


--mm


On 5/11/15 3:03 PM, Pedro Duque Vieira wrote:

Hi,



Already posted this on the OTN forum but got no response.


I have a swing/javafx app that is hanging randomly without any error
information (exceptions thrown, etc). I run the app with the pulse logger
flag active and when it hangs the pulse logger stops.



How can I debug this? What can cause the pulse logger to stop? Is this my
fault or some javafx bug?


Thanks, best regards,

[9-dev] Request for review: RT-40607: Mac resize cursors are wrong

[Morris Meyer]

Kevin and David,

Please review my changes to GlassCursor.m to fix the lack of proper Mac 
NW, SW, SE and NE resize cursors.


As the look-up for these cursors was a little involved, I opted to use a 
one-time cache so as not to induce any noticeable visual lag when 
setting these cursors.


Thanks much,

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-40607
WEBREV - http://cr.openjdk.java.net/~morris/RT-40607.01/

[8u60] request for review: RT-40644: [Mac]: The Custom colors ... dialog can not show as expected

[Morris Meyer]

Jonathan and Leif,

Please review the css changes for Caspian and Modena for the color 
picker custom color chooser.  We need a bit more than 1em for 
settings-unit in CustomColorDialog.java when running on Mac 10.10.  
Tested on 10.10.4.


Thanks much.

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-40644
WEBREV - http://cr.openjdk.java.net/~morris/RT-40644.01/

[8u-dev] Review request: [Windows] Ensemble 8: Spinner example layout is broken

[Morris Meyer]

Jonathan, Kevin and David,

Please review these layout changes to the Spinner Ensemble sample to 
proportionally layout the different Spinners.


Thanks much.

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-40199
WEBREV - http://cr.openjdk.java.net/~morris/RT-40199.01/

[8u60] Request for review: RT-40385: [Mac] NPE in window close unit tests

[Morris Meyer]

David and Kevin,

Please review my fix for the recent regression caused by my fix for 
RT-39813.  Both changes crop up in the systemTests and are necessary to 
adjust for the close sequence timing change introduced in RT-39813.


Tested using:

gradle -PFULL_TEST=true :systemTests:test

Thanks much.

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-40385.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-40385

[8u-dev] Review request: RT-38836: JDK crash on Mac 10.10 with very large stage

[Morris Meyer]

Kevin, David and Chien,

Please review this patch, which fixes RT-38836 (a critical) and RT-23363 
(a medium).  It clips the frame to screen size in Glass-Mac in a similar 
fashion to what happens in Glass-Windows.


Thanks much,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-38836.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-38836

Re: [8u-dev] Review request: RT-38836: JDK crash on Mac 10.10 with very large stage

[Morris Meyer]

I don't have a two monitor display setup for the Mac platform.  Will run 
CircleApp1, CircleApp2, CircleApp3 and MaxStage in applet on both 
Windows 8.1 and Mac and report back.


--mm

On 3/27/15 4:05 PM, Sergey Bylokhov wrote:

Hi, Morris.
Just curiously, does it mean that after the fix, there is no way to 
maximize the window on two monitors in multi-monitors configuration? 
Does this issue affects an applets? Seems that on Windows the clipping 
on the screen bounds is a default native behavior.


27.03.15 22:39, Morris Meyer wrote:

Kevin, David and Chien,

Please review this patch, which fixes RT-38836 (a critical) and 
RT-23363 (a medium).  It clips the frame to screen size in Glass-Mac 
in a similar fashion to what happens in Glass-Windows.


Thanks much,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-38836.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-38836

[8u60] Review request: RT-39813: [Mac] JavaFX core dumps on Stage#close

[Morris Meyer]

Kevin, Chien and David,

Please review my fix for this Mac Stage focus close issue. The Mac OSX 
internals were forcing a callback event onto a non-focused window, and 
this preemptively asserts focus before allowing the event through.


--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-39813.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-39813

[8u-dev] Review request: RT-2298: Mac: implement -Xdock:name support in Glass

[Morris Meyer]

Kevin, David, Danno and Chien,

Please review these changes to add Mac system menu bar naming support to 
JavaFX based on the JavaRuntimeSupport foundation that the JDK uses for 
-Xdock:name via JRSAppkitAWT methods.


On the Mac the application name needs to be available prior to the 
runLoop being viable.  I have made modifications to PlatformImpl to 
differentiate between application class and startup application name to 
provide a route to pass this information into the toolkit startup() 
sequence a priori.


The rest of the changes provide named startup.

The nice part about this change is that we get an immediate system menu 
activation with the application name prior to any Stages getting loaded, 
laid-out and shown, which gives the user an immediate notification of 
the application launch.


Thanks,

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-22988
WEBREV - http://cr.openjdk.java.net/~morris/RT-22988.01
WEBREV - http://cr.openjdk.java.net/~morris/DEPLOY-22988.01

[8u-dev] Review request: RT-39108: [HelloCheckBox] Sample needs additional controls for Accessibility testing

[Morris Meyer]

Kevin, David and Jonathan,

Could you please review my accessibility additions to HelloCheckBox?

Thanks much,

--morris


WEBREV - http://cr.openjdk.java.net/~morris/RT-39108.01
JIRA - https://javafx-jira.kenai.com/browse/RT-39108

[8u-dev] Review request: RT-39797: Glass sometimes prints warning message on exit

[Morris Meyer]

Folks,

Could I get a review of these changes?  As Glass invokeLater is not 
thread-safe, and since the JNI native method 
MacApplication._submitForLaterInvocation() only adds the GlassRunnable 
when the event thread is still running and Java is still around, I'm 
dealing with this extraneous GlassRunnable in a similar manner as RT-39688.


Thanks,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-39797.01a
JIRA - https://javafx-jira.kenai.com/browse/RT-39797

[8u60] Review request: RT-40008: Ensemble8 points to old URL for javadoc

[Morris Meyer]

Kevin, Jonathan and David,

Could you please review these changes to Ensemble8 to update the FX API 
docs urls to point to their proper places?


Thanks much,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-40008.01/
JIRA - https://javafx-jira.kenai.com/browse/RT-40008

[8u-dev] Review request: RT-40032: Nested window open causes repeated shortcut key event after close

[Morris Meyer]

David and Kevin,

Could you review this change?  The change set is per the description in 
JIRA, and has been tested by Nicholas Myers.


Thanks much.

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-40032
WEBREV - http://cr.openjdk.java.net/~morris/RT-40032.01

[8u-dev] Review Request: RT-39869: IndexOutOfBoundsException with Native Menus in Mac

[Morris Meyer]

Kevin and David,

Could you please take a look at this fix to RT-39869?  I added some 
checking to avoid the IOOBE from the native Glass system menus.


Thanks,

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-39869.01
JIRA - https://javafx-jira.kenai.com/browse/RT-39869

[8u-dev] Code Review Request: RT-39855: StageStyle.UNIFIED not working on OSX 10.9.5

[Morris Meyer]

Kevin, David and Chien,

Could you review my fix for this regression?  I have tested this on Mac 
OSX 10.10.3 (pre-release).


Thanks much.

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-39855
WEBREV - http://cr.openjdk.java.net/~morris/RT-39855

Re: Building Openjfx on Centos 6.6

[Morris Meyer]

What JDK are you using?  That looks like an older version of the String class.  
Gradle 1.8 is recommended.

--mm


 On Dec 28, 2014, at 7:35 PM, Nick Pratt nbpr...@gmail.com wrote:
 
 Does anyone have any tips on getting Openjfx (latest source as of
 2014-12-28 19:00 EST) to build on a Centos 6.6 box?
 
 Im following the wiki for Linux builds and grabbed Gradle 1.8 (does the
 latest 2.2 work?) but Im failing to build with the following error:
 
 [work@nyprod1 rt]# /opt/gradle/bin/gradle
 
 :buildSrc:generateGrammarSource UP-TO-DATE
 
 :buildSrc:compileJava UP-TO-DATE
 
 :buildSrc:compileGroovy UP-TO-DATE
 
 :buildSrc:processResources UP-TO-DATE
 
 :buildSrc:classes UP-TO-DATE
 
 :buildSrc:jar UP-TO-DATE
 
 :buildSrc:assemble UP-TO-DATE
 
 :buildSrc:compileTestJava UP-TO-DATE
 
 :buildSrc:compileTestGroovy UP-TO-DATE
 
 :buildSrc:processTestResources UP-TO-DATE
 
 :buildSrc:testClasses UP-TO-DATE
 
 :buildSrc:test UP-TO-DATE
 
 :buildSrc:check UP-TO-DATE
 
 :buildSrc:build UP-TO-DATE
 
 
 FAILURE: Build failed with an exception.
 
 
 * Where:
 
 Script '/work/WorkingCopies/rt/buildSrc/linux.gradle' line: 78
 
 
 * What went wrong:
 
 A problem occurred evaluating script.
 
 Cannot invoke method split() on null object
 
 
 * Try:
 
 Run with --stacktrace option to get the stack trace. Run with --info or
 --debug option to get more log output.
 
 
 BUILD FAILED
 
 
 Total time: 8.96 secs
 
 
 If anyone has any tips or suggestions to get this compiling on Centos 6.x
 they would be most appreciated.

[8u60] Review request for RT-34958: [Ensemble] content in some pages are not centered

[Morris Meyer]

Folks,

Could I get a quick review for this fix-up of the alignment in two 
Ensemble apps?


Thanks much.

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-34958
WEBREV - http://cr.openjdk.java.net/~morris/RT-34958.01

[8u60] Review request for RT-34840: [3DViewer] FileNotFoundException: Jfx3dViewerApp_session.properties (Read-only file system)

[Morris Meyer]

Kevin and Chien,

Please review this simple fix for the 3DViewer SessionManager class to 
take care of read-only file system errors when trying to save the 
session file.


Thanks much,

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-34840
WEBREV - http://cr.openjdk.java.net/~morris/RT-34840.01

[8u60] Review request for RT-39688: Glass-Mac window close deallocation produces a spurious warning

[Morris Meyer]

David and Kevin,

Please review this very small change to prevent a spurious warning when 
de-allocation occurs for a NSWindow instance after the Java VM has shutdown.


Thanks much,

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-39688
WEBREV - http://cr.openjdk.java.net/~morris/RT-39688.01

[8u40]: Review request for RT-39489: Latest 10.10.2 beta update causes NSTouch exceptions continually

[Morris Meyer]

Kevin and David,

Please review this patch for the issue added with the 10.10.2 software 
patch that deals with part of the NSTouch interface changing.


--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-39489
WEBREV - http://cr.openjdk.java.net/~morris/RT-39489.01/

[8u40] Review request: RT-34668 Mac: Assertion failures when exiting VideoCube test

[Morris Meyer]

David, Kevin and Chien,

Please review my fix for RT-34668 to remove the spurious extra runnable 
that sometimes pops up after applications are quit on the Mac.


Thanks,

--morris

BUG - https://javafx-jira.kenai.com/browse/RT-34668
WEBREV - http://cr.openjdk.java.net/~morris/RT-34668.01

[8u40] Review request: RT-38641- Unknown error 0x80DE0001 when trying to drag TreeView node

[Morris Meyer]

David and Kevin,

Could you please review the following change to remove the extraneous 
Windows COM debug output from Glass drag-and-drop?


Thanks much,

--morris

JIRA - https://javafx-jira.kenai.com/browse/RT-38641
WEBREV - http://cr.openjdk.java.net/~morris/RT-38641.01/

8u40 Review Request: [EnsembleApp] Add dialogs sample to Ensemble

[Morris Meyer]

Folks,

Could you please review the new Dialog app for Ensemble8?

Thanks much!

--mm

WEBREV - http://cr.openjdk.java.net/~morris/RT-39121.01
BUG - https://javafx-jira.kenai.com/browse/RT-39121

8u40 Review Request: [EnsembleApp] Icon for Spinner is the same as progress bar

[Morris Meyer]

Folks,

Please review the new icon.

Thanks,
--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-39101.01
BUG - https://javafx-jira.kenai.com/browse/RT-39101

[8u40] Review request for RT-23363: Mac: runtimeException when drawing to a huge window

[Morris Meyer]

Folks,

I've uploaded the initial webrev for this issue for review.

Thanks much!

--morris meyer

JIRA - https://javafx-jira.kenai.com/browse/RT-23363
WEBREV - http://cr.openjdk.java.net/~morris/RT-23363.01

[8u40] Review request for RT-37693: QuadCurve example uses labels that refer to cubic curve

[Morris Meyer]

Folks,

I've uploaded the initial webrev for this issue for review.

Thanks much!

--morris meyer

JIRA - https://javafx-jira.kenai.com/browse/RT-37693
WEBREV - http://cr.openjdk.java.net/~morris/RT-37693.01

Re: [8u40] Review request for RT-38058: Pagination leak

[Morris Meyer]

Here is my latest webrev based on Jonathan's comments in JIRA for RT-38058.

--morris

WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.02

On 10/6/14, 3:53 PM, Morris Meyer wrote:

Here is an open webrev:

WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01


On 10/6/14, 2:50 PM, Morris Meyer wrote:

Jonathan,

I've pulled out the following patch from this JIRA issue and used 
jvisualvm to verify that this indeed does solve our pagination leak 
using the HelloPagination app.


Could you please give this a review?  Thanks.

--morris

BUG - https://javafx-jira.kenai/browse/RT-38058
WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/01/RT-38058

[8u40] Review request for RT-38058: Pagination leak

[Morris Meyer]

Jonathan,

I've pulled out the following patch from this JIRA issue and used 
jvisualvm to verify that this indeed does solve our pagination leak 
using the HelloPagination app.


Could you please give this a review?  Thanks.

--morris

BUG - https://javafx-jira.kenai/browse/RT-38058
WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/01/RT-38058

Re: [8u40] Review request for RT-38058: Pagination leak

[Morris Meyer]

Here is an open webrev:

WEBREV - http://cr.openjdk.java.net/~morris/RT-38058.01


On 10/6/14, 2:50 PM, Morris Meyer wrote:

Jonathan,

I've pulled out the following patch from this JIRA issue and used 
jvisualvm to verify that this indeed does solve our pagination leak 
using the HelloPagination app.


Could you please give this a review?  Thanks.

--morris

BUG - https://javafx-jira.kenai/browse/RT-38058
WEBREV - http://javaweb.us.oracle.com/~mameyer/webrevs/01/RT-38058