RFR: 8090522: Allow support for disabling stage iconification (minimization)

2022-05-19 Thread Paweł Kruszczyński
`Stage` minimalizing (iconified state) cannot be disabled for the user. The 
same for `Stage` closable state.
PR adds these features without breaking backward compatibility.

-

Commit messages:
 - 8090522: Allow support for disabling stage iconification (minimization)

Changes: https://git.openjdk.java.net/jfx/pull/798/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx=798=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8090522
  Stats: 199 lines in 5 files changed: 198 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/798.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/798/head:pull/798

PR: https://git.openjdk.java.net/jfx/pull/798


Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again [v4]

2022-05-19 Thread Paweł Kruszczyński
> `Tooltip` is no longer hiding upon receiving 
> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on 
> overlaying tooltip also kills the tooltip, so the infinite duration tooltip 
> can be closed.

Paweł Kruszczyński has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains four additional 
commits since the last revision:

 - Merge branch 'openjdk:master' into 8261221_tooltip_blinks
 - Merge branch 'openjdk:master' into 8261221_tooltip_blinks
 - 8261221: Tooltip bigger than screen size blinks - applying reviewed fixes
 - 8261221: Tooltip bigger than screen size blinks - shows and hides over and 
over again

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/395/files
  - new: https://git.openjdk.java.net/jfx/pull/395/files/0a175dca..7dc2ff37

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=395=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=395=02-03

  Stats: 5600 lines in 7 files changed: 5583 ins; 3 del; 14 mod
  Patch: https://git.openjdk.java.net/jfx/pull/395.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/395/head:pull/395

PR: https://git.openjdk.java.net/jfx/pull/395


Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2022-05-10 Thread Paweł Kruszczyński
On Wed, 17 Feb 2021 18:50:54 GMT, Kevin Rushforth  wrote:

>> `Tooltip` is no longer hiding upon receiving 
>> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on 
>> overlaying tooltip also kills the tooltip, so the infinite duration tooltip 
>> can be closed.
>
> One more request: Please follow the instructions 
> [here](https://github.com/openjdk/jfx/pull/395/checks) to enable running 
> pre-submit tests.

@kevinrushforth sorry for "little" delay in answering, but I thing that 
previously failing tests have passed as successful now.

-

PR: https://git.openjdk.java.net/jfx/pull/395


Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again [v3]

2022-05-10 Thread Paweł Kruszczyński
> `Tooltip` is no longer hiding upon receiving 
> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on 
> overlaying tooltip also kills the tooltip, so the infinite duration tooltip 
> can be closed.

Paweł Kruszczyński has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains three additional 
commits since the last revision:

 - Merge branch 'openjdk:master' into 8261221_tooltip_blinks
 - 8261221: Tooltip bigger than screen size blinks - applying reviewed fixes
 - 8261221: Tooltip bigger than screen size blinks - shows and hides over and 
over again

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/395/files
  - new: https://git.openjdk.java.net/jfx/pull/395/files/3fb62625..0a175dca

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=395=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=395=01-02

  Stats: 954937 lines in 11930 files changed: 523481 ins; 281758 del; 149698 mod
  Patch: https://git.openjdk.java.net/jfx/pull/395.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/395/head:pull/395

PR: https://git.openjdk.java.net/jfx/pull/395


Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again [v2]

2021-04-22 Thread Paweł Kruszczyński
> `Tooltip` is no longer hiding upon receiving 
> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on 
> overlaying tooltip also kills the tooltip, so the infinite duration tooltip 
> can be closed.

Paweł Kruszczyński has updated the pull request incrementally with one 
additional commit since the last revision:

  8261221: Tooltip bigger than screen size blinks - applying reviewed fixes

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/395/files
  - new: https://git.openjdk.java.net/jfx/pull/395/files/bc6aaba7..3fb62625

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=395=01
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=395=00-01

  Stats: 10 lines in 1 file changed: 0 ins; 1 del; 9 mod
  Patch: https://git.openjdk.java.net/jfx/pull/395.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/395/head:pull/395

PR: https://git.openjdk.java.net/jfx/pull/395


RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2021-02-17 Thread Paweł Kruszczyński
`Tooltip` is no longer hiding upon receiving `MouseEvent.MOUSE_ENTERED_TARGET` 
event inside it. Pressing mouse on overlaying tooltip also kills the tooltip, 
so the infinite duration tooltip can be closed.

-

Commit messages:
 - 8261221: Tooltip bigger than screen size blinks - shows and hides over and 
over again

Changes: https://git.openjdk.java.net/jfx/pull/395/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx=395=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8261221
  Stats: 24 lines in 1 file changed: 24 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/395.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/395/head:pull/395

PR: https://git.openjdk.java.net/jfx/pull/395