RE: [11] Review Request:JDK-8186187 Modify return type of public API StyleConverter.getEnumConverter()

2018-07-05 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Please review the updated patch with test case:

HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8186187/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.01/

 

Regards,

Prem

 

From: Prem Balakrishnan 
Sent: Monday, May 14, 2018 5:04 PM
To: Kevin Rushforth ; Ajit Haribhau Ghaisas 
(ajit.ghai...@oracle.com) ; 
openjfx-dev@openjdk.java.net List 
Subject: [11] Review Request:JDK-8186187 Modify return type of public API 
StyleConverter.getEnumConverter()

 

Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8186187 

 

Webrev:  http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.00/ 

 

Regards,

Prem

[11] Review Request JDK-8201285 DateCell text color are not updated correctly when DateCell with disable = true is reused

2018-05-25 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8201285 

 

Webrev:  HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8201285/webrev00/"http://cr.openjdk.java.net/~pkbalakr/fx/8201285/webrev00/

 

Regards,

Prem

[11] Review Request:JDK-8186187 Modify return type of public API StyleConverter.getEnumConverter()

2018-05-14 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8186187 

 

Webrev:  http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.00/ 

 

Regards,

Prem

[8u-dev]Review Request : JDK-8198200 : Table auto resize ignores column resize policy

2018-04-12 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review this 8u-dev backport :

 

Bug : https://bugs.openjdk.java.net/browse/JDK-8192800 

Webrev : HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8192800/8u/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/fx/8192800/8u/webrev.01/

 

Regards,

Prem

RE: Add missing styleable properties to ImageView?

2018-04-04 Thread Prem Balakrishnan 
Hi Johan,

I was not aware of this PR and hence worked on this RFE separately.
Thanks for bringing it to my notice.

I am watching the thread now and I will let Andres take it forward.

Regards,
Prem

-Original Message-
From: Johan Vos  
Sent: Tuesday, April 03, 2018 6:16 PM
To: openjfx-dev@openjdk.java.net List 
Subject: Add missing styleable properties to ImageView?

There is a discussion on an issue at github whether some properties on 
ImageView need to be css-styleable:
https://github.com/javafxports/openjdk-jfx/issues/29

As not everybody is checking those issues, I want to bring this under the 
attention of the list, as it has important consequences (once we do this, what 
other properties might follow?)

There is a related PR at https://github.com/javafxports/openjdk-jfx/pull/30

I don't have a particular opinion on this topic, but I want to hear what others 
think.

- Johan

[11] Review Request: JDK 8152187 Make fitWidth of ImageView stylable as fit-width

2018-04-02 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8152187 

 

Webrev:  http://cr.openjdk.java.net/~pkbalakr/fx/8152187/webrev.00/

 

Regards,

Prem

[11] Review Request: JDK-8167096 RFE: change the default INITIAL_DURATION_MS to match the behavior of JSpinner

2018-01-15 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8167096  

 

Webrev:  http://cr.openjdk.java.net/~pkbalakr/fx/8167096/webrev00/ 

 

Regards,

Prem

[11] Review Request: JDK-8192800 Table auto resize ignores column resize policy

2018-01-08 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8192800 

 

Webrev:  HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8192800/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8192800/webrev.00/

Regards,

Prem

[11] Review Request: JDK-8190411 NPE in SliderSkin:140 if Slider.Tooltip.autohide is true

2017-12-22 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8190411 

 

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8190411/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8190411/webrev.00/
 

 

Regards,

Prem

[10] Review Request: JDK-8184270 NullPointerException when using Combobox in combination with accessibility app

2017-11-14 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8184270 

 

Webrev: 
http://cr.openjdk.java.net/~pkbalakr/fx/Accessibility/8184270/webrev.00/ 

 

Regards,

Prem

[10] Review Request: JDK-8189732 :TextArea doesn't scroll to bottom when texts becomes long and vertical scrollbar appears

2017-11-13 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8189732 

 

Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8189732/webrev.00/ 

 

Regards,

Prem

[10] Review Request: JDK- 8088077: [Accessibility, JAWS] DatePicker under JAWS speaks the wrong date after using arrow keys to move highlighted date across month boundaries.

2017-10-30 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8088077 

 

Webrev: 
http://cr.openjdk.java.net/~pkbalakr/fx/Accessibility/8088077/webrev.00/ 

 

Regards,

Prem

[10] Review Request: JDK-8087541 : [Accessibility] BubbleChart values are not getting read

2017-10-19 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8087541 

 

Webrev: 
http://cr.openjdk.java.net/~pkbalakr/fx/Accessibility/8087541/webrev.00/ 

 

Regards,

Prem

[10]Review Request: JDK-8189641 : [Accessibility, windows] NPE when navigating to ComboBox with empty string

2017-10-19 Thread Prem Balakrishnan 
Hi Kevin, Ajit

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8189641  

 

Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/Accessibility/8189641/webrev00/ 

 

Regards,

Prem

[10] Review Request : JDK-8167139 Menu's selection disappears on collapsing

2017-06-22 Thread Prem Balakrishnan 
Hi Jonathan,

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8167139 

 

Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167139/webrev.00/ 

 

Regards,

Prem

[10] Review request: JDK-8167209 Menu bar is not selected by right ALT key

2017-06-07 Thread Prem Balakrishnan 
Hi Jonathan,

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8167209 

Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167209/webrev.00/ 

 

Regards,

Prem

[10] Review request: JDK-8088389 : [CSS, HighContrast] Menu - All the menu items look disabled on Mouse Click / Roll Over

2017-05-29 Thread Prem Balakrishnan 
Hi Jonathan,

 

Request you to review following fix:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8088389 

 

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Epkbalakr/fx/8088389/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8088389/webrev.00/
 

 

Regards,

Prem