[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-04-16 Thread Stephen F Northover

Hi Jim,

Please review the lambdification of the buildSrc component (JSL 
portion).  Strangely, there is only one file that is affected.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch in the JIRA

Steve


[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-04-04 Thread Stephen F Northover

Hi Kevin,

Please review the lambdification of the graphics component. You are 
welcome to apply the patch, but there are numerous changes and they are 
all automatic. If you or any of the team have outstanding changes, 
please coordinate with me in the JIRA and I will re-lambdify after you 
have released your changes.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve


Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-06 Thread Kirill Kirichenko

I couldn't find media part in Jira.

On 06.03.2014 00:44, Stephen F Northover wrote:

... of course I mean the media component, not base.  I just change the
template to say your component ...

Steve

On 2014-03-05 3:41 PM, Stephen F Northover wrote:

Hi Kirill,

Please review the lambdification of the base component.  You are
welcome to apply the patch, but there are numerous changes and they
are all automatic.  If you have outstanding changes, please commit
them and I will lambdify once more,

Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve





Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-06 Thread Mike
Follow this thread and open javafx 

Sent from my iPhone

 On Mar 6, 2014, at 1:49 AM, Kirill Kirichenko kirill.kiriche...@oracle.com 
 wrote:
 
 I couldn't find media part in Jira.
 
 On 06.03.2014 00:44, Stephen F Northover wrote:
 ... of course I mean the media component, not base.  I just change the
 template to say your component ...
 
 Steve
 
 On 2014-03-05 3:41 PM, Stephen F Northover wrote:
 Hi Kirill,
 
 Please review the lambdification of the base component.  You are
 welcome to apply the patch, but there are numerous changes and they
 are all automatic.  If you have outstanding changes, please commit
 them and I will lambdify once more,
 
 Jira: https://javafx-jira.kenai.com/browse/RT-35197
 Webrev: See patch is in the JIRA
 
 Steve
 


Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-06 Thread Anthony Petrov

No, it's not. Sorry.

I guess Steve hasn't attached it to the JIRA.

--
best regards,
Anthony

On 3/6/2014 2:12 PM, Anthony Petrov wrote:

I believe the base-lambda.patch in JIRA is what you're looking for.

--
best regards,
Anthony

On 3/6/2014 1:49 PM, Kirill Kirichenko wrote:

I couldn't find media part in Jira.

On 06.03.2014 00:44, Stephen F Northover wrote:

... of course I mean the media component, not base.  I just change the
template to say your component ...

Steve

On 2014-03-05 3:41 PM, Stephen F Northover wrote:

Hi Kirill,

Please review the lambdification of the base component.  You are
welcome to apply the patch, but there are numerous changes and they
are all automatic.  If you have outstanding changes, please commit
them and I will lambdify once more,

Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve





Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-06 Thread Stephen F Northover

Sorry everyone.  The patch is there now.

Steve

On 2014-03-06 6:04 AM, Anthony Petrov wrote:

No, it's not. Sorry.

I guess Steve hasn't attached it to the JIRA.

--
best regards,
Anthony

On 3/6/2014 2:12 PM, Anthony Petrov wrote:

I believe the base-lambda.patch in JIRA is what you're looking for.

--
best regards,
Anthony

On 3/6/2014 1:49 PM, Kirill Kirichenko wrote:

I couldn't find media part in Jira.

On 06.03.2014 00:44, Stephen F Northover wrote:

... of course I mean the media component, not base.  I just change the
template to say your component ...

Steve

On 2014-03-05 3:41 PM, Stephen F Northover wrote:

Hi Kirill,

Please review the lambdification of the base component. You are
welcome to apply the patch, but there are numerous changes and they
are all automatic.  If you have outstanding changes, please commit
them and I will lambdify once more,

Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve







[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-05 Thread Stephen F Northover

Hi Kirill,

Please review the lambdification of the base component.  You are welcome 
to apply the patch, but there are numerous changes and they are all 
automatic.  If you have outstanding changes, please commit them and I 
will lambdify once more,


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve



Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-05 Thread Stephen F Northover
.. of course I mean the media component, not base.  I just change the 
template to say your component ...


Steve

On 2014-03-05 3:41 PM, Stephen F Northover wrote:

Hi Kirill,

Please review the lambdification of the base component.  You are 
welcome to apply the patch, but there are numerous changes and they 
are all automatic.  If you have outstanding changes, please commit 
them and I will lambdify once more,


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve





Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-04 Thread Stephen F Northover

Of course I mean Leonid, who is the owner of web, not Anthony ...

On 2014-03-04 1:18 PM, Stephen F Northover wrote:

Hi Anthony,

Please review the lambdification of the web component. You are welcome 
to apply the patch, but there are numerous changes and they are all 
automatic. If you have outstanding changes, please coordinate with me 
and I will re-lambdify to include the changes.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve




Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-03-03 Thread Stephen F Northover

Hi Anthony,

Please review the lambdification of the swing component. You are welcome 
to apply the patch, but there are numerous changes and they are all 
automatic. If you have outstanding changes, please coordinate with me 
and I will re-lambdify to include the changes.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve


Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples [experiments]

2014-02-28 Thread Stephen F Northover

Hi Lisa,

Please review the lambdification of the experiments component. You are 
welcome to apply the patch, but there are numerous changes and they are 
all automatic.  If you have outstanding changes, please coordinate with 
me and I will re-lambdify to include the changes.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve


[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples [toys]

2014-02-27 Thread Stephen F Northover

Hi Lisa,

Please review the lambdification of the toys component. You are welcome 
to apply the patch, but there are numerous changes and they are all 
automatic.  If you have outstanding changes, please coordinate with me 
and I will re-lambdify to include the changes.


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve


[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-02-26 Thread Stephen F Northover

Hi Martin,

Please review the lambdification of the base component.  You are welcome 
to apply the patch, but there are numerous changes and they are all 
automatic.  If you have outstanding changes, please commit them and I 
will lambdify once more,


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve



Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

2014-02-26 Thread Kevin Rushforth
As a note to NB users, this may cause problems with NB 7.4 so if you use 
NB, and have problems with 7.4, you might want to try it with NB 8 RC1.


-- Kevin


Stephen F Northover wrote:

Hi Martin,

Please review the lambdification of the base component.  You are 
welcome to apply the patch, but there are numerous changes and they 
are all automatic.  If you have outstanding changes, please commit 
them and I will lambdify once more,


Jira: https://javafx-jira.kenai.com/browse/RT-35197
Webrev: See patch is in the JIRA

Steve