Re: [Approved] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-16 Thread Ambarish Rapte 
On Fri, 15 Nov 2019 22:38:56 GMT, Kevin Rushforth  wrote:

> On Fri, 15 Nov 2019 10:33:16 GMT, Ambarish Rapte  wrote:
> 
>> The pull request has been updated with additional changes.
>> 
>> 
>> 
>> Added commits:
>>  - e7856f6e: reenable some more tests and fix review comment
>> 
>> Changes:
>>   - all: https://git.openjdk.java.net/jfx/pull/39/files
>>   - new: https://git.openjdk.java.net/jfx/pull/39/files/5df00884..e7856f6e
>> 
>> Webrevs:
>>  - full: https://webrevs.openjdk.java.net/jfx/39/webrev.01
>>  - incr: https://webrevs.openjdk.java.net/jfx/39/webrev.00-01
>> 
>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8234194
>>   Stats: 14 lines in 3 files changed: 6 ins; 3 del; 5 mod
>>   Patch: https://git.openjdk.java.net/jfx/pull/39.diff
>>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/39/head:pull/39
> 
> Looks good.
> 
> modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java
>  line 102:
> 
>> 101: }
>> 102: 
>> 103: @Ignore("JDK-8234241")
> 
> Based on the description in JBS, I presume that 
> [JDK-8234241](https://bugs.openjdk.java.net/browse/JDK-8234241) is a test 
> bug? If so, can you label the new bug as such?
> 
> 
> 
> Approved by kcr (Lead).

Hi Kevin, I have updated the JBS.

PR: https://git.openjdk.java.net/jfx/pull/39

Re: [Approved] RFR: 8234194: [TEST_BUG] Reenable few graphics unit tests

2019-11-15 Thread Kevin Rushforth 
On Fri, 15 Nov 2019 10:33:16 GMT, Ambarish Rapte  wrote:

> The pull request has been updated with additional changes.
> 
> 
> 
> Added commits:
>  - e7856f6e: reenable some more tests and fix review comment
> 
> Changes:
>   - all: https://git.openjdk.java.net/jfx/pull/39/files
>   - new: https://git.openjdk.java.net/jfx/pull/39/files/5df00884..e7856f6e
> 
> Webrevs:
>  - full: https://webrevs.openjdk.java.net/jfx/39/webrev.01
>  - incr: https://webrevs.openjdk.java.net/jfx/39/webrev.00-01
> 
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8234194
>   Stats: 14 lines in 3 files changed: 6 ins; 3 del; 5 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/39.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/39/head:pull/39

Looks good.

modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java
 line 102:

> 101: }
> 102: 
> 103: @Ignore("JDK-8234241")

Based on the description in JBS, I presume that 
[JDK-8234241](https://bugs.openjdk.java.net/browse/JDK-8234241) is a test bug? 
If so, can you label the new bug as such?



Approved by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/39