Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-19 Thread Johan Vos
On Tue, 18 Feb 2020 21:59:07 GMT, Nir Lisker  wrote:

>> Docs fixes for OpenJFX 14. We can wait with integrating this in case there 
>> are last minute fixes, but reviews can start.
> 
> The pull request has been updated with 2 additional commits.

Marked as reviewed by jvos (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/110


Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Kevin Rushforth
On Tue, 18 Feb 2020 21:59:07 GMT, Nir Lisker  wrote:

>> Docs fixes for OpenJFX 14. We can wait with integrating this in case there 
>> are last minute fixes, but reviews can start.
> 
> The pull request has been updated with 2 additional commits.

Looks good.

-

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/110


Re: [jfx14] [Rev 02] RFR: 8228867: Fix mistakes in FX API docs

2020-02-18 Thread Nir Lisker
> Docs fixes for OpenJFX 14. We can wait with integrating this in case there 
> are last minute fixes, but reviews can start.

The pull request has been updated with 2 additional commits.

-

Added commits:
 - 6ef5518c: Revert copyright year change
 - 200ac8c3: Revert extra }

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/110/files
  - new: https://git.openjdk.java.net/jfx/pull/110/files/75d34b85..6ef5518c

Webrevs:
 - full: https://webrevs.openjdk.java.net/jfx/110/webrev.02
 - incr: https://webrevs.openjdk.java.net/jfx/110/webrev.01-02

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jfx/pull/110.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/110/head:pull/110

PR: https://git.openjdk.java.net/jfx/pull/110