Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v3]

2022-02-10 Thread Kevin Rushforth
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas  wrote:

>> This is a Javadoc cleanup and correction fix for the TabPane as described in 
>> the JBS.
>> 
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the unnecessary docs on property setter/getter and Property method.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Address additional review comments

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/728


Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v3]

2022-02-09 Thread Nir Lisker
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas  wrote:

>> This is a Javadoc cleanup and correction fix for the TabPane as described in 
>> the JBS.
>> 
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the unnecessary docs on property setter/getter and Property method.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Address additional review comments

Marked as reviewed by nlisker (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/728


Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v3]

2022-02-09 Thread Ajit Ghaisas
> This is a Javadoc cleanup and correction fix for the TabPane as described in 
> the JBS.
> 
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary docs on property setter/getter and Property method.

Ajit Ghaisas has updated the pull request incrementally with one additional 
commit since the last revision:

  Address additional review comments

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/728/files
  - new: https://git.openjdk.java.net/jfx/pull/728/files/66630a39..537dcac1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=728=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=728=01-02

  Stats: 25 lines in 1 file changed: 0 ins; 4 del; 21 mod
  Patch: https://git.openjdk.java.net/jfx/pull/728.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/728/head:pull/728

PR: https://git.openjdk.java.net/jfx/pull/728