Re: COMPILE_SWING defaults to false

2018-04-19 Thread Kevin Rushforth 
I guess I should say "for non-desktop platforms" since COMPILE_SWING is 
also false for iOS and dalvik platforms.


-- Kevin

On 4/19/2018 8:21 AM, Kevin Rushforth wrote:
For all platforms or just for arm? The latter should be fine. The 
former would break the build, but fortunately, that flag defaults to 
true on desktop platforms.


buildSrc/linux.gradle:LINUX.compileSwing = true;
buildSrc/mac.gradle:MAC.compileSwing = true;
buildSrc/win.gradle:WIN.compileSwing = true;

Note that COMPILE_SWING is not intended to be set on the command line 
(e.g., not with 'gradle -P') but in the platform-specific 
buildSrc/XXX.gradle file.


-- Kevin


On 4/19/2018 8:10 AM, Johan Vos wrote:

Before pushing
http://cr.openjdk.java.net/~jvos/8195669/webrev.00/rt.patch
as a fix for JDK-8195669 
<https://bugs.openjdk.java.net/browse/JDK-8195669>
  (see https://github.com/javafxports/openjdk-jfx/pull/58) I want to 
double

check that it is fine that COMPILE_SWING defaults to false ?

- Johan

Re: COMPILE_SWING defaults to false

2018-04-19 Thread Kevin Rushforth 
For all platforms or just for arm? The latter should be fine. The former 
would break the build, but fortunately, that flag defaults to true on 
desktop platforms.


buildSrc/linux.gradle:LINUX.compileSwing = true;
buildSrc/mac.gradle:MAC.compileSwing = true;
buildSrc/win.gradle:WIN.compileSwing = true;

Note that COMPILE_SWING is not intended to be set on the command line 
(e.g., not with 'gradle -P') but in the platform-specific 
buildSrc/XXX.gradle file.


-- Kevin


On 4/19/2018 8:10 AM, Johan Vos wrote:

Before pushing
http://cr.openjdk.java.net/~jvos/8195669/webrev.00/rt.patch
as a fix for JDK-8195669 <https://bugs.openjdk.java.net/browse/JDK-8195669>
  (see https://github.com/javafxports/openjdk-jfx/pull/58) I want to double
check that it is fine that COMPILE_SWING defaults to false ?

- Johan

COMPILE_SWING defaults to false

2018-04-19 Thread Johan Vos 
Before pushing
http://cr.openjdk.java.net/~jvos/8195669/webrev.00/rt.patch
as a fix for JDK-8195669 <https://bugs.openjdk.java.net/browse/JDK-8195669>
 (see https://github.com/javafxports/openjdk-jfx/pull/58) I want to double
check that it is fine that COMPILE_SWING defaults to false ?

- Johan