Re: [Integrated] RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote: > It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. This pull request has now been integrated. Changeset: 97499820 Author:Michael Paus Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/97499820 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8246204: No 3D support for newer Intel graphics drivers on Linux Reviewed-by: kcr - PR: https://git.openjdk.java.net/jfx/pull/243
Re: [Rev 01] RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
> It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. Michael Paus has updated the pull request incrementally with one additional commit since the last revision: Remove duplicate GLGPUInfo according to review comment My original intention was to keep two entries in order to make it clearer that there are currently two distinct vendor strings for Intel floating around. But having just one entry which covers both cases is ok for me too. - Changes: - all: https://git.openjdk.java.net/jfx/pull/243/files - new: https://git.openjdk.java.net/jfx/pull/243/files/759af32c..4142adb3 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/243/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/243/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/243/head:pull/243 PR: https://git.openjdk.java.net/jfx/pull/243
Re: RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote:
> It seems to be sufficient to add "intel" as an additional vendor to the list
> in the X11GLFactory class. Tests pass and
> my own application also works with the new build.
modules/javafx.graphics/src/main/java/com/sun/prism/es2/X11GLFactory.java line
46:
> 45: new GLGPUInfo("intel open source technology center", null),
> 46: new GLGPUInfo("intel", null),
> 47: new GLGPUInfo("nvidia", null),
Since the qualification check is `vendor.startsWith(gi.vendor)` you can replace
the previous `"intel open source
technology center"` entry with the new one.
-
PR: https://git.openjdk.java.net/jfx/pull/243
Re: RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
On Mon, 1 Jun 2020 17:52:46 GMT, Michael Paus wrote: > It seems to be sufficient to add "intel" as an additional vendor to the list > in the X11GLFactory class. Tests pass and > my own application also works with the new build. Here is the crosslink to the JBS issue: https://bugs.openjdk.java.net/browse/JDK-8246204 - PR: https://git.openjdk.java.net/jfx/pull/243
RFR: 8246204: No 3D support for newer Intel graphics drivers on Linux
It seems to be sufficient to add "intel" as an additional vendor to the list in the X11GLFactory class. Tests pass and my own application also works with the new build. - Commit messages: - Fix JDK-8246204 Changes: https://git.openjdk.java.net/jfx/pull/243/files Webrev: https://webrevs.openjdk.java.net/jfx/243/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8246204 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/243.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/243/head:pull/243 PR: https://git.openjdk.java.net/jfx/pull/243
