Re: [jfx15] RFR: 8248381: Create a daemon thread for MonocleTimer [v2]
On Sun, 28 Jun 2020 02:28:35 GMT, John Neffenger wrote: >> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381). > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revision: > > Remove POOL_SIZE constant I'm ok with this, as it fixes regression. A longer-term requirement could be the addition of platform-independent start/stop and pause/resume methods, similar to http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/4e1e2f56c7af (https://bugs.openjdk.java.net/browse/JDK-8189926) - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/256
Re: [jfx15] RFR: 8248381: Create a daemon thread for MonocleTimer [v2]
On Sun, 28 Jun 2020 02:28:35 GMT, John Neffenger wrote: >> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381). > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revision: > > Remove POOL_SIZE constant Looks good to me. I verified that it does, in fact, fix the regression. As long as @johanvos also approves, then this is fine to go in for `jfx15` I think we can address any issues relating to Timer start / stop / pause / resume in a subsequent release. There was some work done to support pause / resume as part of [JDK-8189926](https://bugs.openjdk.java.net/browse/JDK-8189926), but it was only implemented on macOS (with follow-up issues filed to implement it on Windows and Linux). It didn't address any issues with start / stop. In particular we have never supported restarting the JavaFX runtime, so unless there are other uses of stop besides shutting down the runtime, I don't know that it matters if the timer can be restarted. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/256
Re: RFR: 8248381: Create a daemon thread for MonocleTimer [v2]
> Fixes [JDK-8248381](https://bugs.openjdk.java.net/browse/JDK-8248381). John Neffenger has updated the pull request incrementally with one additional commit since the last revision: Remove POOL_SIZE constant - Changes: - all: https://git.openjdk.java.net/jfx/pull/256/files - new: https://git.openjdk.java.net/jfx/pull/256/files/c771c242..4ca2bc03 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/256/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/256/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/256.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/256/head:pull/256 PR: https://git.openjdk.java.net/jfx/pull/256
