Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]
On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary wrote: >> Added missing explicit no-arg constructors to classes in package >> javafx.scene, javafx.css and javafx.stage. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: > > Updated comments as per JDK Convention Marked as reviewed by nlisker (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/283
Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]
On Wed, 26 Aug 2020 17:22:36 GMT, Kevin Rushforth wrote: >> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated comments as per JDK Convention > > Looks good. I also verified that the only two class without an explicit > constructor are the two we identified as > needing to be deprecated for removal in a follow-up issue: `Selector` and > `SshapeConverter` I filed the following two follow-up issues: 1. [JDK-8252387](https://bugs.openjdk.java.net/browse/JDK-8252387): Deprecate for removal css Selector and ShapeConverter constructors 2. [JDK-8252389](https://bugs.openjdk.java.net/browse/JDK-8252389): Fix mistakes in FX API docs I also added the note about the PseudoClass docs to: 3. [JDK-8250590](https://bugs.openjdk.java.net/browse/JDK-8250590): Classes and methods in the javafx.css package are missing documentation - PR: https://git.openjdk.java.net/jfx/pull/283
Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]
On Wed, 26 Aug 2020 15:46:46 GMT, Bhawesh Choudhary wrote: >> Added missing explicit no-arg constructors to classes in package >> javafx.scene, javafx.css and javafx.stage. > > Bhawesh Choudhary has updated the pull request incrementally with one > additional commit since the last revision: > > Updated comments as per JDK Convention Looks good. I also verified that the only two class without an explicit constructor are the two we identified as needing to be deprecated for removal in a follow-up issue: `Selector` and `SshapeConverter` - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/283
Re: RFR: 8251353: Many javafx scenegraph classes have implicit no-arg constructors [v5]
> Added missing explicit no-arg constructors to classes in package > javafx.scene, javafx.css and javafx.stage. Bhawesh Choudhary has updated the pull request incrementally with one additional commit since the last revision: Updated comments as per JDK Convention - Changes: - all: https://git.openjdk.java.net/jfx/pull/283/files - new: https://git.openjdk.java.net/jfx/pull/283/files/69b75d69..5bb07901 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/283/webrev.04 - incr: https://webrevs.openjdk.java.net/jfx/283/webrev.03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/283/head:pull/283 PR: https://git.openjdk.java.net/jfx/pull/283
