Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-08 Thread Kevin Rushforth
On Thu, 8 Oct 2020 11:35:15 GMT, Eric Bresie 
 wrote:

>>> What OS are you using? (I'm running a test on Ubuntu 18.04)
>> 
>> I also have 18.04.
>
> Does the 
> [documentation](https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX)
>  need updating to reflect the
> change?

The Wiki doesn't specify the version of gcc (it probably should, though).

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-08 Thread Eric Bresie
On Tue, 6 Oct 2020 13:14:05 GMT, Ambarish Rapte  wrote:

>> Marked as reviewed by jvos (Reviewer).
>
>> What OS are you using? (I'm running a test on Ubuntu 18.04)
> 
> I also have 18.04.

Does the 
[documentation](https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX) 
need updating to reflect the
change?

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Ambarish Rapte
On Tue, 6 Oct 2020 12:59:39 GMT, Johan Vos  wrote:

>> This patch updates the compiler to gcc 10.2 on Linux, in order to match JDK 
>> 16 -- see
>> [JDK-8253616](https://bugs.openjdk.java.net/browse/JDK-8253616).
>> I ran a full build and test, including media and WebKit.
>
> Marked as reviewed by jvos (Reviewer).

> What OS are you using? (I'm running a test on Ubuntu 18.04)

I also have 18.04.

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Johan Vos
On Tue, 6 Oct 2020 12:53:34 GMT, Kevin Rushforth  wrote:

>>> Build and sanity test looks good on my machine.
>> 
>> What OS are you using? (I'm running a test on Ubuntu 18.04)
>
> I've run tests on Ubuntu 16.04, Ubuntu 20.04, and Oracle Linux 7.

I confirm it works on Ubuntu 18.04

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Johan Vos
On Tue, 29 Sep 2020 23:34:55 GMT, Kevin Rushforth  wrote:

> This patch updates the compiler to gcc 10.2 on Linux, in order to match JDK 
> 16 -- see
> [JDK-8253616](https://bugs.openjdk.java.net/browse/JDK-8253616).
> I ran a full build and test, including media and WebKit.

Marked as reviewed by jvos (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Kevin Rushforth
On Tue, 6 Oct 2020 10:47:47 GMT, Johan Vos  wrote:

>> Build and sanity test looks good on my machine.
>
>> Build and sanity test looks good on my machine.
> 
> What OS are you using? (I'm running a test on Ubuntu 18.04)

I've run tests on Ubuntu 16.04, Ubuntu 20.04, and Oracle Linux 7.

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Johan Vos
On Tue, 6 Oct 2020 09:52:34 GMT, Ambarish Rapte  wrote:

> Build and sanity test looks good on my machine.

What OS are you using? (I'm running a test on Ubuntu 18.04)

-

PR: https://git.openjdk.java.net/jfx/pull/311


Re: RFR: 8252191: Update to gcc 10.2 on Linux

2020-10-06 Thread Ambarish Rapte
On Tue, 29 Sep 2020 23:34:55 GMT, Kevin Rushforth  wrote:

> This patch updates the compiler to gcc 10.2 on Linux, in order to match JDK 
> 16 -- see
> [JDK-8253616](https://bugs.openjdk.java.net/browse/JDK-8253616).
> I ran a full build and test, including media and WebKit.

Build and sanity test looks good on my machine.

-

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/311


RFR: 8252191: Update to gcc 10.2 on Linux

2020-09-29 Thread Kevin Rushforth
This patch updates the compiler to gcc 10.2 on Linux, in order to match JDK 16 
-- see
[JDK-8253616](https://bugs.openjdk.java.net/browse/JDK-8253616).

I ran a full build and test, including media and WebKit.

-

Commit messages:
 - 8252191: Update to gcc 10.2 on Linux

Changes: https://git.openjdk.java.net/jfx/pull/311/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=311&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252191
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jfx/pull/311.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/311/head:pull/311

PR: https://git.openjdk.java.net/jfx/pull/311