Re: RFR: 8267551: Support loading images from inline data-URIs [v16]
On Wed, 9 Jun 2021 13:18:29 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added comment, simplified DataURI.matchScheme() > > modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 95: > >> 93: * the protocol handlers that are registered for the application. >> 94: * >> 95: * If a URL uses the "data" scheme, the data must be base64-encoded > > I think these two sentences should be in the same paragraph. Ok. - PR: https://git.openjdk.java.net/jfx/pull/508
Re: RFR: 8267551: Support loading images from inline data-URIs [v16]
On Sat, 5 Jun 2021 17:31:17 GMT, Michael Strauß wrote: >> This PR adds support for loading images from [inline data >> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely >> supported by web browsers. This enables developers to package small images >> in CSS files, rather than separately deploying the images alongside the CSS >> file. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > added comment, simplified DataURI.matchScheme() The docs look good. I left one minor comment inline. You can update the CSR when ready. As I mentioned in a comment in the CSR, the `Specification` section should consist of the diffs to the API documentation. Make sure you note what API element (e.g., class doc, `Image(String url)` constructor, and so forth) each change is for, if it isn't clear from the diffs. You can omit the removal of the `` html tags and the change from `example.` to `example:` from the diffs in the CSR. modules/javafx.graphics/src/main/java/javafx/scene/image/Image.java line 95: > 93: * the protocol handlers that are registered for the application. > 94: * > 95: * If a URL uses the "data" scheme, the data must be base64-encoded I think these two sentences should be in the same paragraph. - PR: https://git.openjdk.java.net/jfx/pull/508
Re: RFR: 8267551: Support loading images from inline data-URIs [v16]
On Sat, 5 Jun 2021 17:31:17 GMT, Michael Strauß wrote: >> This PR adds support for loading images from [inline data >> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely >> supported by web browsers. This enables developers to package small images >> in CSS files, rather than separately deploying the images alongside the CSS >> file. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > added comment, simplified DataURI.matchScheme() Since this implementation doesn't surface any new API, it will not prevent us from removing it at any future time when the "data" protocol might be supported by the JDK. - PR: https://git.openjdk.java.net/jfx/pull/508
Re: RFR: 8267551: Support loading images from inline data-URIs [v16]
> This PR adds support for loading images from [inline data > URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely > supported by web browsers. This enables developers to package small images in > CSS files, rather than separately deploying the images alongside the CSS file. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: added comment, simplified DataURI.matchScheme() - Changes: - all: https://git.openjdk.java.net/jfx/pull/508/files - new: https://git.openjdk.java.net/jfx/pull/508/files/29178487..e490cc04 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=508=15 - incr: https://webrevs.openjdk.java.net/?repo=jfx=508=14-15 Stats: 20 lines in 2 files changed: 3 ins; 14 del; 3 mod Patch: https://git.openjdk.java.net/jfx/pull/508.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/508/head:pull/508 PR: https://git.openjdk.java.net/jfx/pull/508
