Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendrikx has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove remaining references to old JUnit 4.8.2 > - Upgrade to JUnit 4.13.2 Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/633
Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendrikx has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove remaining references to old JUnit 4.8.2 > - Upgrade to JUnit 4.13.2 This looks good. I noticed that the fix for 8276142: Update gradle to version 7.3 was not in the branch for this PR, but merging it manually (which will be done when it is merged here) worked and did not cause issues. I'm running a few more tests, and will approve when they are all green. - PR: https://git.openjdk.java.net/jfx/pull/633
Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendrikx has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove remaining references to old JUnit 4.8.2 > - Upgrade to JUnit 4.13.2 The changes look good to me. The tests work as expected. - Marked as reviewed by mstrauss (Author). PR: https://git.openjdk.java.net/jfx/pull/633
Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendrikx has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove remaining references to old JUnit 4.8.2 > - Upgrade to JUnit 4.13.2 @johanvos @tiainen Can one of you also review this to ensure it causes no problems with your builds? - PR: https://git.openjdk.java.net/jfx/pull/633
Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
On Mon, 22 Nov 2021 13:43:34 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John Hendrikx has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove remaining references to old JUnit 4.8.2 > - Upgrade to JUnit 4.13.2 Looks good. I did a CI build with the latest changes. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/633
Re: RFR: 8274274: Update JUnit to version 5.8.1 [v9]
> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests > still work. Also added a single JUnit 5 tests, and confirmed it works. > > I've updated the Eclipse project file for the base module only. John Hendrikx has updated the pull request incrementally with two additional commits since the last revision: - Remove remaining references to old JUnit 4.8.2 - Upgrade to JUnit 4.13.2 - Changes: - all: https://git.openjdk.java.net/jfx/pull/633/files - new: https://git.openjdk.java.net/jfx/pull/633/files/f556a1ae..5f4f695b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=633&range=08 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=633&range=07-08 Stats: 10 lines in 2 files changed: 1 ins; 8 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/633.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/633/head:pull/633 PR: https://git.openjdk.java.net/jfx/pull/633
