Re: RFR: 8275848: Deprecate mistakenly exposed field from class javafx.scene.shape.Box

2021-10-29 Thread Kevin Rushforth 
On Fri, 29 Oct 2021 07:31:05 GMT, Ajit Ghaisas  wrote:

> This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.

This looks good with one minor comment. Please also change the title of the JBS 
issues (both the bug and the CSR) and this PR to add "for removal" after 
"Deprecate". So maybe:


Deprecate for removal mistakenly exposed field from javafx.scene.shape.Box

modules/javafx.graphics/src/main/java/javafx/scene/shape/Box.java line 90:

> 88: /**
> 89:  * Default size of the {@code Box}.
> 90:  * @deprecated This field was exposed mistakenly and will be removed

Can you add a period at the end?

-

PR: https://git.openjdk.java.net/jfx/pull/655

RFR: 8275848: Deprecate mistakenly exposed field from class javafx.scene.shape.Box

2021-10-29 Thread Ajit Ghaisas 
This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.

-

Commit messages:
 - Deprecate DEFAULT_SIZE constant field

Changes: https://git.openjdk.java.net/jfx/pull/655/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx=655=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8275848
  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/655.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/655/head:pull/655

PR: https://git.openjdk.java.net/jfx/pull/655