Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589 [v4]

2021-12-03 Thread Kevin Rushforth
On Fri, 3 Dec 2021 20:46:46 GMT, Johan Vos  wrote:

>> After (re)setting the number of elements, make sure to do at least some 
>> estimation of the total size.
>> Added a testcase for this scenario.
>
> Johan Vos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add checks on positive values on counters

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/683


Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589 [v4]

2021-12-03 Thread Michael Strauß
On Fri, 3 Dec 2021 20:46:46 GMT, Johan Vos  wrote:

>> After (re)setting the number of elements, make sure to do at least some 
>> estimation of the total size.
>> Added a testcase for this scenario.
>
> Johan Vos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add checks on positive values on counters

Marked as reviewed by mstrauss (Author).

-

PR: https://git.openjdk.java.net/jfx/pull/683


Re: RFR: 8276553: ListView scrollTo() is broken after fix for JDK-8089589 [v4]

2021-12-03 Thread Johan Vos
> After (re)setting the number of elements, make sure to do at least some 
> estimation of the total size.
> Added a testcase for this scenario.

Johan Vos has updated the pull request incrementally with one additional commit 
since the last revision:

  add checks on positive values on counters

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/683/files
  - new: https://git.openjdk.java.net/jfx/pull/683/files/1a25a6d5..35713395

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=683=03
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=683=02-03

  Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jfx/pull/683.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/683/head:pull/683

PR: https://git.openjdk.java.net/jfx/pull/683