Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
On Thu, 16 Dec 2021 12:54:27 GMT, Jeanette Winzenburg wrote: >> Extracted static test utility methods from EditAndScrollTest into new >> VirtualizedControlTestUtils, added rudimentary tests for the methods. > > Jeanette Winzenburg has updated the pull request incrementally with one > additional commit since the last revision: > > fixed c&p error in doc Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
> Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision: fixed c&p error in doc - Changes: - all: https://git.openjdk.java.net/jfx/pull/690/files - new: https://git.openjdk.java.net/jfx/pull/690/files/c2642bbe..1f2a9815 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=690&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=690&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/690.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/690/head:pull/690 PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest) [v2]
On Thu, 16 Dec 2021 11:00:39 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed c&p error in doc > > modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualizedControlTestUtils.java > line 86: > >> 84: >> 85: /** >> 86: * Returns a vertical ScrollBar of the control. > > I found this typo. I know, you just moved it from one file to another.. but, > it would be good to fix in this PR :) > Typo : This should be - "Returns a horizontal..." actually, it was me who introduced it - in the previous PR 😁 Thanks for spotting! - PR: https://git.openjdk.java.net/jfx/pull/690
Re: RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg wrote: > Extracted static test utility methods from EditAndScrollTest into new > VirtualizedControlTestUtils, added rudimentary tests for the methods. This looks good except for a typo which is not introduced by you! modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualizedControlTestUtils.java line 86: > 84: > 85: /** > 86: * Returns a vertical ScrollBar of the control. I found this typo. I know, you just moved it from one file to another.. but, it would be good to fix in this PR :) Typo : This should be - "Returns a horizontal..." - PR: https://git.openjdk.java.net/jfx/pull/690
RFR: 8278134: Move static utility methods to infrastructure (EditAndScrollTest)
Extracted static test utility methods from EditAndScrollTest into new VirtualizedControlTestUtils, added rudimentary tests for the methods. - Commit messages: - 8278134: Move static utility methods to infrastructure Changes: https://git.openjdk.java.net/jfx/pull/690/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=690&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278134 Stats: 348 lines in 3 files changed: 290 ins; 57 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/690.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/690/head:pull/690 PR: https://git.openjdk.java.net/jfx/pull/690
