Re: RFR: 8278860: Streamline properties for Monocle [v2]
On Fri, 17 Dec 2021 13:54:10 GMT, Johan Vos wrote: >> Base decisions in prism for embedded cases on the same glass.platform >> property that is also used in glass. >> This PR replaces the property `embedded` with the property `glass.platform` . >> >> There is only 1 place where the property `embedded` was read, which is in >> the PlatformUtil.java. >> >> There are only 2 places where the value of that property is used, and in >> both cases the only check is to detect whether or not that property has a >> value of "monocle". > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Add space after comma Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/696
Re: RFR: 8278860: Streamline properties for Monocle [v2]
On Thu, 16 Dec 2021 00:20:06 GMT, Michael Strauß wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add space after comma
>
> modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 67:
>
>> 65:
>> 66: @SuppressWarnings("removal")
>> 67: String str2 =
>> AccessController.doPrivileged((PrivilegedAction) () ->
>> System.getProperty("glass.platform","").toLowerCase(Locale.ROOT));
>
> Minor: maybe add a space after the comma
done
-
PR: https://git.openjdk.java.net/jfx/pull/696
Re: RFR: 8278860: Streamline properties for Monocle [v2]
> Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property `embedded` was read, which is in the > PlatformUtil.java. > > There are only 2 places where the value of that property is used, and in both > cases the only check is to detect whether or not that property has a value of > "monocle". Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add space after comma - Changes: - all: https://git.openjdk.java.net/jfx/pull/696/files - new: https://git.openjdk.java.net/jfx/pull/696/files/00146dd1..a0af3c6b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=696=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=696=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/696.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/696/head:pull/696 PR: https://git.openjdk.java.net/jfx/pull/696
Re: RFR: 8278860: Streamline properties for Monocle
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property `embedded` was read, which is in the > PlatformUtil.java. > > There are only 2 places where the value of that property is used, and in both > cases the only check is to detect whether or not that property has a value of > "monocle". Looks good. If you want to add the missing space I'll reapprove. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/696
Re: RFR: 8278860: Streamline properties for Monocle
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote:
> Base decisions in prism for embedded cases on the same glass.platform
> property that is also used in glass.
> This PR replaces the property `embedded` with the property `glass.platform` .
>
> There is only 1 place where the property `embedded` was read, which is in the
> PlatformUtil.java.
>
> There are only 2 places where the value of that property is used, and in both
> cases the only check is to detect whether or not that property has a value of
> "monocle".
modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 67:
> 65:
> 66: @SuppressWarnings("removal")
> 67: String str2 =
> AccessController.doPrivileged((PrivilegedAction) () ->
> System.getProperty("glass.platform","").toLowerCase(Locale.ROOT));
Minor: maybe add a space after the comma
-
PR: https://git.openjdk.java.net/jfx/pull/696
RFR: 8278860: Streamline properties for Monocle
Base decisions in prism for embedded cases on the same glass.platform property that is also used in glass. This PR replaces the property `embedded` with the property `glass.platform` . There is only 1 place where the property `embedded` was read, which is in the PlatformUtil.java. There are only 2 places where the value of that property is used, and in both cases the only check is to detect whether or not that property has a value of "monocle". - Commit messages: - Base decisions in prism for embedded cases on the same glass.platform property Changes: https://git.openjdk.java.net/jfx/pull/696/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=696=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278860 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/696.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/696/head:pull/696 PR: https://git.openjdk.java.net/jfx/pull/696
