Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar  wrote:

>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous 
> commits have been removed. Incremental views are not available. The pull 
> request now contains one commit:
> 
>   8282134: Certain regex can cause a JS trap in WebView

Marked as reviewed by kcr (Lead).

-

PR: https://git.openjdk.java.net/jfx/pull/739


Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Jay Bhaskar
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar  wrote:

>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous 
> commits have been removed. Incremental views are not available. The pull 
> request now contains one commit:
> 
>   8282134: Certain regex can cause a JS trap in WebView

Author name Change , due to bot comment

⚠️ @jaybhaskar the full name on your profile does not match the author name in 
this pull requests' 
[HEAD](https://git.openjdk.java.net/jfx/pull/739/commits/6319c639e244f20e9ff6846c9bdcd04fb189d89d)
 commit. If this pull request gets integrated then the author name from this 
pull requests' 
[HEAD](https://git.openjdk.java.net/jfx/pull/739/commits/6319c639e244f20e9ff6846c9bdcd04fb189d89d)
 commit will be used for the resulting commit. If you wish to push a new commit 
with a different author name, then please run the following commands in a local 
repository of your personal fork:

$ git checkout public-sec-bug
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full 
name'
$ git push

-

PR: https://git.openjdk.java.net/jfx/pull/739


Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar  wrote:

>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous 
> commits have been removed. Incremental views are not available. The pull 
> request now contains one commit:
> 
>   8282134: Certain regex can cause a JS trap in WebView

Marked as reviewed by arapte (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/739


Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Kevin Rushforth
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar  wrote:

>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous 
> commits have been removed. Incremental views are not available. The pull 
> request now contains one commit:
> 
>   8282134: Certain regex can cause a JS trap in WebView

In general, we prefer that you not force push your branch once the associated 
PR is under review. In this case, it seems that an incorrect Skara message led 
you to amend the existing commit, rather than adding a new empty commit as 
intended. I'll file a bug against Skara.

-

PR: https://git.openjdk.java.net/jfx/pull/739


Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Ambarish Rapte
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar  wrote:

>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous 
> commits have been removed. Incremental views are not available. The pull 
> request now contains one commit:
> 
>   8282134: Certain regex can cause a JS trap in WebView

Marked as reviewed by arapte (Reviewer).

-

PR: https://git.openjdk.java.net/jfx/pull/739


Re: RFR: 8282134: Certain regex can cause a JS trap in WebView [v3]

2022-02-22 Thread Jay Bhaskar
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can 
> cause a JS trap in WebView

Jay Bhaskar has refreshed the contents of this pull request, and previous 
commits have been removed. Incremental views are not available. The pull 
request now contains one commit:

  8282134: Certain regex can cause a JS trap in WebView

-

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/739/files
  - new: https://git.openjdk.java.net/jfx/pull/739/files/a041e77e..3fad1fc9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx=739=02
 - incr: https://webrevs.openjdk.java.net/?repo=jfx=739=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/739.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/739/head:pull/739

PR: https://git.openjdk.java.net/jfx/pull/739