Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and WebKit. Successfully managed to run a build and test with VS 2022 17.1.0. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.java.net/jfx/pull/766
Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and WebKit. lgtm. Verified build and sanity test. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/766
Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
On Mon, 4 Apr 2022 11:14:27 GMT, Joeri Sykora wrote: > Which versions were chosen for the build tools, redistributables and the CRT? > Do we still use the same ones as with Visual Studio 2019? Each version of Visual Studio has its own set of compilers and redistributables. Visual Studio 2022 version 17.1.0 corresponds to VC version `14.31.31103`. The redistributables should be in `redist/x64/Microsoft.VC143.CRT`. - PR: https://git.openjdk.java.net/jfx/pull/766
Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and WebKit. @kevinrushforth Which versions were chosen for the build tools, redistributables and the CRT? Do we still use the same ones as with Visual Studio 2019? - PR: https://git.openjdk.java.net/jfx/pull/766
RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
This patch updates the compiler to Visual Studio 2022 version 17.1.0 on Windows, in order to match JDK 19 -- see [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). I ran a full build and test, including media and WebKit. - Commit messages: - 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows Changes: https://git.openjdk.java.net/jfx/pull/766/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=766=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283786 Stats: 9 lines in 3 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jfx/pull/766.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/766/head:pull/766 PR: https://git.openjdk.java.net/jfx/pull/766
