Re: [Rev 02] RFR: 8223298: SVG patterns are drawn wrong
On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote: >> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the >> native side which is propagated to the java >> side as well. But, as transform initialization takes place after scaling, >> the transform is reset to default value. >> Fix: Override scale() method in WCBufferedContext class to call init() >> before scaling. > > Arun Joseph has updated the pull request incrementally with one additional > commit since the last revision: > > Added SVGTest Looks good to me , verified on mac os x and windows. - Marked as reviewed by ghb (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/164
Re: [Rev 02] RFR: 8223298: SVG patterns are drawn wrong
> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the > native side which is propagated to the java > side as well. But, as transform initialization takes place after scaling, the > transform is reset to default value. > Fix: Override scale() method in WCBufferedContext class to call init() before > scaling. Arun Joseph has updated the pull request incrementally with one additional commit since the last revision: Added SVGTest - Changes: - all: https://git.openjdk.java.net/jfx/pull/164/files - new: https://git.openjdk.java.net/jfx/pull/164/files/fb1c3934..86674653 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/164/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/164/webrev.01-02 Stats: 132 lines in 1 file changed: 132 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/164.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/164/head:pull/164 PR: https://git.openjdk.java.net/jfx/pull/164