Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Wed, 16 Oct 2019 15:54:54 GMT, Arunprasad Rajkumar wrote: > On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > >> On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >>> wrote: >>> 8232158: [macOS] Fallback to command line tools if xcode is missing Commits: - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is missing Changes: https://git.openjdk.java.net/jfx/pull/13/files Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod Patch: https://git.openjdk.java.net/jfx/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 >>> >>> @kevinrushforth Am I missing anything here which prevents the review >>> process? >> >> No, I have just been swamped the last few days. It's on my list to review. >> Sorry for the delay. > > Thanks @kevin. @johanvos , Do you have any concern? In short, this fix allows developers to build jfx on mac without full Xcode install. It would be useful for CI/CD. PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >> wrote: >> >>> 8232158: [macOS] Fallback to command line tools if xcode is missing >>> >>> >>> >>> Commits: >>> - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode >>> is missing >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/13/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 >>> Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/13.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 >> >> @kevinrushforth Am I missing anything here which prevents the review process? > > No, I have just been swamped the last few days. It's on my list to review. > Sorry for the delay. Thanks @kevin. PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar wrote: > On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar > wrote: > >> 8232158: [macOS] Fallback to command line tools if xcode is missing >> >> >> >> Commits: >> - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is >> missing >> >> Changes: https://git.openjdk.java.net/jfx/pull/13/files >> Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 >> Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod >> Patch: https://git.openjdk.java.net/jfx/pull/13.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 > > @kevinrushforth Am I missing anything here which prevents the review process? No, I have just been swamped the last few days. It's on my list to review. Sorry for the delay. PR: https://git.openjdk.java.net/jfx/pull/13
Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missing > > Changes: https://git.openjdk.java.net/jfx/pull/13/files > Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8232158 > Stats: 33 lines in 1 file changed: 15 ins; 1 del; 17 mod > Patch: https://git.openjdk.java.net/jfx/pull/13.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/13/head:pull/13 @kevinrushforth Am I missing anything here which prevents the review process? PR: https://git.openjdk.java.net/jfx/pull/13
