Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > check length of DashArray Looks safe and minimal change. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/765
Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > check length of DashArray Yes, i will file a new follow up bug - PR: https://git.openjdk.java.net/jfx/pull/765
Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]
On Thu, 7 Apr 2022 09:55:36 GMT, Jay Bhaskar wrote: >> Issue: Floating point overflow , when making end point for line drawing as >> FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); >> Solution: traverse widths to calculate end point and increment start point. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > check length of DashArray Looks good. I confirm that it fixes the crash. Can you file the follow-on bug to investigate our use of the `widths` list? - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/765
Re: RFR: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/ [v2]
> Issue: Floating point overflow , when making end point for line drawing as > FloatPoint endPoint = startPoint + FloatPoint(widths.last(), 0); > Solution: traverse widths to calculate end point and increment start point. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: check length of DashArray - Changes: - all: https://git.openjdk.java.net/jfx/pull/765/files - new: https://git.openjdk.java.net/jfx/pull/765/files/feda90ec..5c503f5e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=765=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=765=00-01 Stats: 10 lines in 1 file changed: 3 ins; 3 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/765.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/765/head:pull/765 PR: https://git.openjdk.java.net/jfx/pull/765
