Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView [v2]
On Tue, 24 May 2022 09:51:29 GMT, Jose Pereda wrote: >> This PR fixes an issue with selection of multiple items in TableView and >> TreeTableView controls that gets moved unexpectedly when new items are added >> even way below the selected items. >> >> A couple of tests have been added. They fail without this PR (first >> selected item gets deselected, and table anchor gets moved), and pass with >> this PR (first selected item keeps selected, and table anchor remains at the >> same place). > > Jose Pereda has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into 8284665-tableviewanchor > - Only shift anchor if existing one is affected by the change event, and > tests Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/790
Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets deselected, and table anchor gets moved), and pass with this PR > (first selected item keeps selected, and table anchor remains at the same > place). I've merged from head to fix conflicts, I guess it needs to be reviewed again? - PR: https://git.openjdk.java.net/jfx/pull/790
Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView [v2]
> This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets deselected, and table anchor gets moved), and pass with this PR > (first selected item keeps selected, and table anchor remains at the same > place). Jose Pereda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into 8284665-tableviewanchor - Only shift anchor if existing one is affected by the change event, and tests - Changes: https://git.openjdk.java.net/jfx/pull/790/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=790=01 Stats: 101 lines in 4 files changed: 99 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/790.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/790/head:pull/790 PR: https://git.openjdk.java.net/jfx/pull/790
Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets deselected, and table anchor gets moved), and pass with this PR > (first selected item keeps selected, and table anchor remains at the same > place). This looks simple enough that a single reviewer is sufficient. - PR: https://git.openjdk.java.net/jfx/pull/790
Re: RFR: 8284665: First selected item of a TreeItem multiple selection gets removed if new items are constantly added to the TreeTableView
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote: > This PR fixes an issue with selection of multiple items in TableView and > TreeTableView controls that gets moved unexpectedly when new items are added > even way below the selected items. > > A couple of tests have been added. They fail without this PR (first selected > item gets deselected, and table anchor gets moved), and pass with this PR > (first selected item keeps selected, and table anchor remains at the same > place). The fix looks good. I verified that tests fail without this fix and pass with it. - Marked as reviewed by aghaisas (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/790
