Re: hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-27 Thread Tom Schindl 
The class is showing com.sun.istack.internal.NotNull in it's API! Is
this really a good idea?

Tom

On 26.06.14 21:48, david.gri...@oracle.com wrote:
 Changeset: 8d41ccb6bcdb
 Author:David Grievedavid.gri...@oracle.com
 Date:  2014-06-26 15:47 -0400
 URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb
 
 Take public off StyleablePropertyFactory pending further review of RT-36501: 
 Reduce CssMetaData boilerplate code
 
 ! modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java

Re: hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-27 Thread Stephen F Northover 

Hi Tom,

The code got away too soon.  Please add your comment to the JIRA so that 
we can take it into account.


Thanks,
Steve

On 2014-06-27, 6:06 AM, Tom Schindl wrote:

The class is showing com.sun.istack.internal.NotNull in it's API! Is
this really a good idea?

Tom

On 26.06.14 21:48, david.gri...@oracle.com wrote:

Changeset: 8d41ccb6bcdb
Author:David Grievedavid.gri...@oracle.com
Date:  2014-06-26 15:47 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb

Take public off StyleablePropertyFactory pending further review of RT-36501: 
Reduce CssMetaData boilerplate code

! modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java

Re: hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-27 Thread Stephen F Northover 

It was a typo.  I added your comment.

Steve

On 2014-06-27, 9:43 AM, Tom Schindl wrote:

What is the correct JIRA? RT-36501 is a completely different entry.

Tom

On 27.06.14 15:39, Stephen F Northover wrote:

Hi Tom,

The code got away too soon.  Please add your comment to the JIRA so that
we can take it into account.

Thanks,
Steve

On 2014-06-27, 6:06 AM, Tom Schindl wrote:

The class is showing com.sun.istack.internal.NotNull in it's API! Is
this really a good idea?

Tom

On 26.06.14 21:48, david.gri...@oracle.com wrote:

Changeset: 8d41ccb6bcdb
Author:David Grievedavid.gri...@oracle.com
Date:  2014-06-26 15:47 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb

Take public off StyleablePropertyFactory pending further review of
RT-36501: Reduce CssMetaData boilerplate code

!
modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java

Re: hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-27 Thread Tom Schindl 
What is the correct JIRA? RT-36501 is a completely different entry.

Tom

On 27.06.14 15:39, Stephen F Northover wrote:
 Hi Tom,
 
 The code got away too soon.  Please add your comment to the JIRA so that
 we can take it into account.
 
 Thanks,
 Steve
 
 On 2014-06-27, 6:06 AM, Tom Schindl wrote:
 The class is showing com.sun.istack.internal.NotNull in it's API! Is
 this really a good idea?

 Tom

 On 26.06.14 21:48, david.gri...@oracle.com wrote:
 Changeset: 8d41ccb6bcdb
 Author:David Grievedavid.gri...@oracle.com
 Date:  2014-06-26 15:47 -0400
 URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb

 Take public off StyleablePropertyFactory pending further review of
 RT-36501: Reduce CssMetaData boilerplate code

 !
 modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java

Re: hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-27 Thread Stephen F Northover 

https://javafx-jira.kenai.com/browse/RT-36510

On 2014-06-27, 9:43 AM, Tom Schindl wrote:

What is the correct JIRA? RT-36501 is a completely different entry.

Tom

On 27.06.14 15:39, Stephen F Northover wrote:

Hi Tom,

The code got away too soon.  Please add your comment to the JIRA so that
we can take it into account.

Thanks,
Steve

On 2014-06-27, 6:06 AM, Tom Schindl wrote:

The class is showing com.sun.istack.internal.NotNull in it's API! Is
this really a good idea?

Tom

On 26.06.14 21:48, david.gri...@oracle.com wrote:

Changeset: 8d41ccb6bcdb
Author:David Grievedavid.gri...@oracle.com
Date:  2014-06-26 15:47 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb

Take public off StyleablePropertyFactory pending further review of
RT-36501: Reduce CssMetaData boilerplate code

!
modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java

hg: openjfx/8u-dev/rt: Take public off StyleablePropertyFactory pending further review of RT-36501: Reduce CssMetaData boilerplate code

2014-06-26 Thread david . grieve 
Changeset: 8d41ccb6bcdb
Author:David Grievedavid.gri...@oracle.com
Date:  2014-06-26 15:47 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8d41ccb6bcdb

Take public off StyleablePropertyFactory pending further review of RT-36501: 
Reduce CssMetaData boilerplate code

! modules/graphics/src/main/java/javafx/css/StyleablePropertyFactory.java