AW: JEP 253: Prepare JavaFX UI Controls CSS APIs for Modularization

2015-05-29 Thread Robert Zenz
Okay, I think I slowly start to see how this will be working. But the logic
within the Behaviors won't go away or be moved, am I seeing this correct?

Maybe I should start with the viewpoint from which I'm looking at it.
The Behaviors contain logic at the moment, various functions that are used
by the skin or the behavior itself (for example the selectNextTab() function
in the TabPaneBehavior). What I'm arguing for is having the possibility to
override such functions at one central point, currently these functions are
called from multiple locations, the skin and the behavior itself. So if I want
to change that function, I can extend the behavior and override the function.

Will such a thing be possible with the new InputMaps, or will I have to rewire
all mappings that use a function in the behavior? What about hard coded calls
to functions in the behavior?


---
Von: Jonathan Giles [mailto:jonathan.gi...@oracle.com] 
Gesendet: Dienstag, 19. Mai 2015 10:50
An: Robert Zenz; openjfx-dev@openjdk.java.net
Betreff: Re: JEP 253: Prepare JavaFX UI Controls  CSS APIs for Modularization

It's late and I'm writing this on my phone, but briefly, I think you've missed
the 'project two' section: input maps are how behaviors are now specified,
as a collection of inputs that map to some event handling code.

All skins do in this environment is install a series of these mappings into
the control input map. These are all accessible as public API.

The big thing you miss out on is actually having access to the code within
these event handlers (wish are all gathered in the behavior class). But you can
always replace an input mapping with new code.

I can clarify more tomorrow if things are unclear or if you have any further
questions.

-- Jonathan
Sent from a touch device. Please excuse my brevity.


[8u60, 9] Review request for RT-40743: [WebView] IllegalArgumentException when dragging in google maps

2015-05-29 Thread Anton Nashatyrev

Hi Anton, All

can you please review the fix:
https://javafx-jira.kenai.com/browse/RT-40743
http://cr.openjdk.java.net/~anashaty/RT-40743/webrev.00/ 
http://cr.openjdk.java.net/%7Eanashaty/RT-40743/webrev.00/


Thanks!
Anton.


CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Kevin Rushforth

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2]. Nomination to a project 
Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin



Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread David Hill

YES

On 5/29/15, 9:16 AM, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [2]. Nomination to a project 
Committer is described in [3].

[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin




--
David Hilldavid.h...@oracle.com
Java Embedded Development

A man's feet should be planted in his country, but his eyes should survey the 
world.
-- George Santayana (1863 - 1952)



Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Vadim Pakhnushev

Vote: yes

On 29.05.2015 16:16, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin





Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Alexander Zvegintsev

Vote: yes

--
Thanks,
Alexander.

On 05/29/2015 04:16 PM, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin





Re: CFV: New OpenJFX Committer: Anton Nashatyrev

2015-05-29 Thread Anton V. Tarasov

Vote: YES

On 29.05.2015 16:16, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this nomination. Votes must be cast in 
the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2]. Nomination to a project Committer is described in 
[3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin





In(Sanity) Testing Mondays

2015-05-29 Thread Vadim Pakhnushev

Reminder, Monday is our weekly sanity testing.

You can find your testing assignment at:

https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing

Also please remember that the repo will be locked from 1am PDT until 1pm 
PDT.


Happy testing!

Thanks,
Vadim


Re: JEP 253: Prepare JavaFX UI Controls CSS APIs for Modularization

2015-05-29 Thread Tomas Mikula
Hi Robert,

 The Behaviors contain logic at the moment, various functions that are used
 by the skin or the behavior itself (for example the selectNextTab() function
 in the TabPaneBehavior).

In my view, such code should be refactored to not have any
back-reference from skin to behavior. As a result, it will be
impossible for the skin to directly call methods of behavior.

Tomas