Re: [9] Review request for 8131066: JavaFX MediaPlayer crashes on dispose with certain MP4s

2015-09-01 Thread David DeHaven 

> Hi David,
> 
> Please review the fix:
> https://bugs.openjdk.java.net/browse/JDK-8131066
> http://cr.openjdk.java.net/~almatvee/8131066/webrev.00/
> 
> Crash happens, because AVPlayer was trying to notify AVFMediaPlayer about 
> frame change after AVFMediaPlayer was released. Fixed by unregistering 
> notification callback before AVFMediaPlayer is released.

Change looks good, approved. I also updated the JBS issue.

-DrD-

Re: hg: openjfx/9-dev/rt: 8043352: JEP 257: Update JavaFX/Media to Newer Version of GStreamer

2015-09-01 Thread David DeHaven 

> On Aug 27, 2015, at 6:08 PM, kevin.rushfo...@oracle.com wrote:
> 
> Changeset: 241f9696e3ad
> Author:almatvee
> Date:  2015-08-27 14:35 -0700
> URL:   http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/241f9696e3ad
> 
> 8043352: JEP 257: Update JavaFX/Media to Newer Version of GStreamer
> Reviewed-by: stayer, ddehaven, kcr




-DrD-