[9] Review request: JDK-8174842 Uninitialized variable in PosixPlatform.cpp

2017-02-13 Thread Chris Bensen 
Victor,

Please review the fix for initializing the uninitialized variable.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8174842 

Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174842/webrev.00/ 


Chris

[9] Review request: 8172526: Third-party licenses for javafx.* modules are missing

2017-02-13 Thread Kevin Rushforth 

Dave & Mandy,

Please review the following fix to deliver the JavaFX third-party 
license content into the JDK build.


https://bugs.openjdk.java.net/browse/JDK-8172526
http://cr.openjdk.java.net/~kcr/8172526/webrev.00/

Thanks.

-- Kevin

Re: [9] Review request: 8172526: Third-party licenses for javafx.* modules are missing

2017-02-13 Thread Kevin Rushforth 

Fixed. Thanks.

http://cr.openjdk.java.net/~kcr/8172526/webrev.01/

-- Kevin


Mandy Chung wrote:

On Feb 13, 2017, at 1:50 PM, Kevin Rushforth  wrote:

Dave & Mandy,

Please review the following fix to deliver the JavaFX third-party license 
content into the JDK build.

https://bugs.openjdk.java.net/browse/JDK-8172526
http://cr.openjdk.java.net/~kcr/8172526/webrev.00/




javafx.graphics/src/main/legal/jpeg_v7.md

   5 jcapimin.c
   6  *

/* is missing.

Otherwise looks okay.

Mandy

Re: [9] Review request: 8172526: Third-party licenses for javafx.* modules are missing

2017-02-13 Thread Mandy Chung 
+1

Mandy

> On Feb 13, 2017, at 5:30 PM, Kevin Rushforth  
> wrote:
> 
> Fixed. Thanks.
> 
> http://cr.openjdk.java.net/~kcr/8172526/webrev.01/ 
> 
> 
> -- Kevin
> 
> 
> Mandy Chung wrote:
>> 
>>> On Feb 13, 2017, at 1:50 PM, Kevin Rushforth  
>>>  wrote:
>>> 
>>> Dave & Mandy,
>>> 
>>> Please review the following fix to deliver the JavaFX third-party license 
>>> content into the JDK build.
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8172526 
>>> 
>>> http://cr.openjdk.java.net/~kcr/8172526/webrev.00/ 
>>> 
>>> 
>> 
>> 
>> javafx.graphics/src/main/legal/jpeg_v7.md
>> 
>>5 jcapimin.c
>>6  *
>> 
>> /* is missing.
>> 
>> Otherwise looks okay.
>> 
>> Mandy

Re: [9] Review request: 8172526: Third-party licenses for javafx.* modules are missing

2017-02-13 Thread Mandy Chung 

> On Feb 13, 2017, at 1:50 PM, Kevin Rushforth  
> wrote:
> 
> Dave & Mandy,
> 
> Please review the following fix to deliver the JavaFX third-party license 
> content into the JDK build.
> 
> https://bugs.openjdk.java.net/browse/JDK-8172526
> http://cr.openjdk.java.net/~kcr/8172526/webrev.00/


javafx.graphics/src/main/legal/jpeg_v7.md

   5 jcapimin.c
   6  *

/* is missing.

Otherwise looks okay.

Mandy