Re: RFR: 8327179: Update the 3D lighting application [v4]
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote: >> Update for the 3D lighting test tool as described in the JBS issue. > > Nir Lisker has updated the pull request incrementally with five additional > commits since the last revision: > > - Added spacing > - Renamed constant > - Updated benchmark reset message > - Simplified models creation > - Revert resource package I can reproduce the exception if I compile the test program from the command line in the `.../src/main/java` dir using javac and run the program from there. The reason that happens is the separation of the resources into a separate directory tree. One way to solve this, so we can still easily compile and run it from the command line, is to provide an "ant" or "gradle" script as was done for `MonkeyTester` and `FXMediaPlayer` - PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-2018870284
Re: RFR: 8327179: Update the 3D lighting application [v4]
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote: >> Update for the 3D lighting test tool as described in the JBS issue. > > Nir Lisker has updated the pull request incrementally with five additional > commits since the last revision: > > - Added spacing > - Renamed constant > - Updated benchmark reset message > - Simplified models creation > - Revert resource package I can't reproduce the exception. The path to the image is correct. Both the class and the image are under the `attenuation` package. Here is my launch command: C:\Program Files\Java\jdk-21\bin\javaw.exe "-Djava.library.path=C:\Users\Nir\git\jfx\modules\javafx.graphics\build\module-lib" --add-modules=javafx.controls,javafx.swing -Dfile.encoding=UTF-8 -Dstdout.encoding=UTF-8 -Dstderr.encoding=UTF-8 -p "C:\Users\Nir\git\jfx\modules\javafx.controls\bin;C:\Users\Nir\git\jfx\modules\javafx.graphics\bin;C:\Users\Nir\git\jfx\modules\javafx.base\bin;C:\Users\Nir\git\jfx\modules\javafx.swing\bin" -classpath "C:\Users\Nir\git\jfx\tests\performance\3DLighting\bin" -XX:+ShowCodeDetailsInExceptionMessages --add-exports javafx.graphics/test.com.sun.javafx.pgstub=javafx.controls --add-exports javafx.base/test.com.sun.javafx.binding=javafx.controls --add-exports javafx.base/test.util.memory=javafx.controls --add-exports javafx.base/test.javafx.collections=javafx.controls --add-exports javafx.base/com.sun.javafx.property=javafx.graphics --add-exports javafx.base/test.javafx.collections=javafx.graphics --add-exports javafx.base/test.util.memory=javafx.graphics --add-exports java.base/sun.security.util=javafx.graphics --add-reads javafx.base=java.management --add-reads javafx.base=jdk.management attenuation.LightingApplication Perhaps it's a platform-dependent path issue? - PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-2018183992
Re: RFR: 8327179: Update the 3D lighting application [v4]
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote: >> Update for the 3D lighting test tool as described in the JBS issue. > > Nir Lisker has updated the pull request incrementally with five additional > commits since the last revision: > > - Added spacing > - Renamed constant > - Updated benchmark reset message > - Simplified models creation > - Revert resource package Even after reverting package name i continue to see that 3DLighting throws exception when we manually launch it: javafx.graphics@23-internal/javafx.scene.image.Image.validateInputStream(Image.java:1140) at javafx.graphics@23-internal/javafx.scene.image.Image.(Image.java:707) at attenuation.Environment.(Environment.java:64) - PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-2017939695
Re: RFR: 8327179: Update the 3D lighting application [v4]
> Update for the 3D lighting test tool as described in the JBS issue. Nir Lisker has updated the pull request incrementally with five additional commits since the last revision: - Added spacing - Renamed constant - Updated benchmark reset message - Simplified models creation - Revert resource package - Changes: - all: https://git.openjdk.org/jfx/pull/1387/files - new: https://git.openjdk.org/jfx/pull/1387/files/3f2994ff..9b3f0c5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx=1387=03 - incr: https://webrevs.openjdk.org/?repo=jfx=1387=02-03 Stats: 48 lines in 6 files changed: 9 ins; 5 del; 34 mod Patch: https://git.openjdk.org/jfx/pull/1387.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1387/head:pull/1387 PR: https://git.openjdk.org/jfx/pull/1387
