Re: RFR: 8327179: Update the 3D lighting application [v3]

2024-03-13 Thread Nir Lisker 
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte  wrote:

>> Nir Lisker has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49:
> 
>> 47: stopGraphic.setBoundsType(TextBoundsType.VISUAL);
>> 48: stopGraphic.setFill(Color.RED);
>> 49: stopGraphic.setFont(Font.font(20));
> 
> Play and Stop button could be same size. It would be good to look at. 
> Currently the Stop button seems lesser than half size of play button.

As you will see, the font sizes and visual sizes don't render as you would 
expect. Not sure why, but this way they look better. Perhaps small adjustments 
are in order, but if you match the sizes it comes out off.

-

PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r1523953194

Re: RFR: 8327179: Update the 3D lighting application [v3]

2024-03-13 Thread Nir Lisker 
> Update for the 3D lighting test tool as described in the JBS issue.

Nir Lisker has updated the pull request incrementally with one additional 
commit since the last revision:

  copyright headers

-

Changes:
  - all: https://git.openjdk.org/jfx/pull/1387/files
  - new: https://git.openjdk.org/jfx/pull/1387/files/2646489d..3f2994ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1387&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1387&range=01-02

  Stats: 80 lines in 8 files changed: 75 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/1387.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1387/head:pull/1387

PR: https://git.openjdk.org/jfx/pull/1387