Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
Hi Bastian, We're not trying to discourage you from contributing at all, and we'd never stop someone from contributing. We just want the contribution to line up better with the project's greater goals. If you have the motivation and the time to do it, that is awesome and we'd love you to do it. We just want to make sure that we are not negatively affecting existing platforms or plans. Having a discussion on our mailing list would make sure that all the issues that we are already aware of are discussed and we come up with a solution that works for most (or even all) situations. -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
I see. The only change that would influence distributing via a Linux packaging system is the introduction of the vlc module as a new dependency. The other changes do not interfere if the Linux packages install python packages with their Python dist information which is the case for all the Linux distributions that I use. The vlc module available for Arch in the AUR. For Debian there is a Request For Packaging and on Fedora there is at least an old version for Python 2. I am happy to discuss changes. In my experience it is far better to have something to offer as a base for discussion in free software projects. If you just come with suggestions, the developers usually say: "Good idea! Maybe next year when someone has time..." The point of having a working setup.py is that you can install OpenLP on any platform that supports Python and Qt5. In the current state if you want to install e.g. on OpenBSD and did not know about scripts/check_dependencies.py you would have to go through a lot of files to get an idea of what dependencies are needed. And you could not be sure to be right so even if the program starts there could be a thing that you missed. E.g. I found the pyxdg when I started to scan OpenLP for license violations after I found the first one. It is not noted in check_dependencies at all. The same would be true for a developer with a Windows environment who wants to work on trunk. -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
Re: [Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
Review: Disapprove Hi Bastian, Thank you for contributing to OpenLP! It's great to see some of the issues I've seen in OpenLP finally addressed. We have not had the time to look into these issues, and we're happy to see someone looking into them. Unfortunately your changes are not compatible with distributing OpenLP via Linux distributions. While you have highlighted some very real problems in this merge proposal, your proposed fixes do not take into account the multiple ways OpenLP is distributed. While I am happy to make OpenLP installable via PyPI, it is not our primary way to distribute OpenLP. Most of our users are not developers or terribly computer literate for that matter, and certainly over 90% of them have never heard of or used PyPI. Please discuss your changes with the rest of the team on our mailing list. We have discussed some of the issues you have highlighted, and it would be better to engage the whole team and hear what we have already discussed and come up with a solution that works for everyone. Renaming openlp.py: https://lists.openlp.io/pipermail/openlp-dev/2017-March/000186.html Using Python 3.6: https://lists.openlp.io/pipermail/openlp-dev/2018-June/000402.html -- https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Commit message changed to: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.5 because the async/await feature is in use in the code base. Additionally the vendored vlc module is replaced by its version on PyPI. For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 -- Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/setup into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Description changed to: For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 -- Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/setup into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp
[Openlp-core] [Merge] lp:~bastian-germann/openlp/setup into lp:openlp
The proposal to merge lp:~bastian-germann/openlp/setup into lp:openlp has been updated. Description changed to: This fixes setuptools' dependencies according to scripts/check_dependencies.py. The minimum Python version is set to 3.5 because the async/await feature is in use in the code base. Additionally the vendored vlc module is replaced by its version on PyPI. For more details, see: https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356147 -- Your team OpenLP Core is requested to review the proposed merge of lp:~bastian-germann/openlp/setup into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~openlp-core More help : https://help.launchpad.net/ListHelp